From: Paulo Alcantara <pc@manguebit.org>
To: henrymei <ljp1205831794@gmail.com>, sfrench@samba.org
Cc: ronniesahlberg@gmail.com, sprasad@microsoft.com, tom@talpey.com,
bharathsm@microsoft.com, linux-cifs@vger.kernel.org,
samba-technical@lists.samba.org, Aohan Mei <henrymei@tencent.com>,
TencentOS Corvus AI <corvus@tencent.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] smb: client: reject userspace cifs.idmap descriptions
Date: Wed, 02 Sep 2026 15:30:48 -0300 [thread overview]
Message-ID: <7f452eb86fd82bbe990601df42714cc9@manguebit.org> (raw)
In-Reply-To: <20260902125217.3951486-1-henrymei@tencent.com>
henrymei <ljp1205831794@gmail.com> writes:
> From: Aohan Mei <henrymei@tencent.com>
>
> cifs.idmap key descriptions carry authority-bearing fields (owner and
> group SIDs and uid/gid values in "os:"/"gs:"/"oi:"/"gi:" form) that the
> cifs.idmap upcall helper treats as kernel-originating inputs. Unlike
> its sibling cifs.spnego, the cifs.idmap key type has no vet_description
> hook, so userspace can create keys of this type through
> request_key(2)/add_key(2) and supply those fields without CIFS origin.
> A request_key(2) call with a non-NULL callout then drives a root
> usermodehelper upcall (/sbin/request-key -> cifs.idmap) that consumes
> the unvetted description in root context.
>
> Only accept cifs.idmap descriptions while CIFS is using its private
> root_cred to request the key. id_to_sid()/sid_to_id() already run
> under override_creds(root_cred), so the kernel-originated path is
> unaffected.
> ...
Applied.
prev parent reply other threads:[~2026-09-02 18:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-02 12:52 [PATCH] smb: client: reject userspace cifs.idmap descriptions henrymei
2026-09-02 18:30 ` Paulo Alcantara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f452eb86fd82bbe990601df42714cc9@manguebit.org \
--to=pc@manguebit.org \
--cc=bharathsm@microsoft.com \
--cc=corvus@tencent.com \
--cc=henrymei@tencent.com \
--cc=linux-cifs@vger.kernel.org \
--cc=ljp1205831794@gmail.com \
--cc=ronniesahlberg@gmail.com \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
--cc=sprasad@microsoft.com \
--cc=stable@vger.kernel.org \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.