From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6A5FFC433EF for ; Tue, 17 May 2022 10:36:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TOw04jt+JjVK3znPYvgaLzYpkHUmShlrTfPS6615k+E=; b=RxGKAXeTdWiEUq 7TWwweo+CM5r/StiM1uAgjeOADll/PEvB9kqM8lW/bMvj3SYj8BmEK0Dm3L7jPhesVoFKXpSxbX81 SMx1lcoiw5NiI52vM5NK5EMpXgX39tPgm44aSP4vKoZ/XMH5thH8zuAl5aQVQVi4Sluiq+NvXjXfL 6G61NqNJlpBK/MDVqfdYR6N5tdjNZTzBucyrs169tJ5VoE1NVqPRkngSCVdhZVnBrM0Dgh+D+VvfO Q3UuameY6bG2CqzO6090PoHHckM0/H2sBAfmCaA3G7scACe5hFeQegYpXUWmr+mAVC4TyF3/Q/g06 kcYqroPYCI1Cx2C27JPQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nquYe-00D8cV-RB; Tue, 17 May 2022 10:36:04 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nquYR-00D8Vw-Ih; Tue, 17 May 2022 10:35:53 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: kholk11) with ESMTPSA id CE2101F44492 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1652783750; bh=wpmWddblxYyDkBmT+shBpq8yfbqgog90VUPSoVh9U78=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=QV0ki/Z8y09yodZ2xxdyb0epnntinN05WbfPtvPW7os5p9uqkYFgi10FEYcuA2AhF LR4xSTOcpw5+u7037yRzO622+rc+TqcXTxWRPGTGfFDYBqYVp7Eo2Ry62RMydmeVnM hD++8l2KKSLzi5F9sWqcc9w7N+lDX0DAvEye/kt0NPVWTtrCOifeJR2ME74hJt6FIV GJ2RQLsWuorKNkNWhfKLwTC++Ikb/W3emy6hBJHRZ9mY/YITDykiVUzjpvfmBC+4cb GqkIUWiV3qz4gFxVi+g7nT1kAMX9dSdXIVYngBVY3KCpx4afYMxtfKJGmB23DcpeTZ m20C0aYGtQQ0A== Message-ID: <7f4f12ef-4fda-2092-1129-d0be498c7b20@collabora.com> Date: Tue, 17 May 2022 12:35:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v3 3/5] soc: mediatek: pwrap: Move and check return value of platform_get_irq() Content-Language: en-US To: Matthias Brugger Cc: linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, nfraprado@collabora.com, rex-bc.chen@mediatek.com, zhiyong.tao@mediatek.com References: <20220516124659.69484-1-angelogioacchino.delregno@collabora.com> <20220516124659.69484-4-angelogioacchino.delregno@collabora.com> <03ac9b18-cb5d-5ff6-d220-f2f4062cea7e@collabora.com> From: AngeloGioacchino Del Regno In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220517_033551_788945_26CD0180 X-CRM114-Status: GOOD ( 23.41 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org SWwgMTcvMDUvMjIgMTE6NDksIE1hdHRoaWFzIEJydWdnZXIgaGEgc2NyaXR0bzoKPiAKPiAKPiBP biAxNy8wNS8yMDIyIDExOjM0LCBBbmdlbG9HaW9hY2NoaW5vIERlbCBSZWdubyB3cm90ZToKPj4g SWwgMTcvMDUvMjIgMTE6MTgsIE1hdHRoaWFzIEJydWdnZXIgaGEgc2NyaXR0bzoKPj4+Cj4+Pgo+ Pj4gT24gMTYvMDUvMjAyMiAxNDo0NiwgQW5nZWxvR2lvYWNjaGlubyBEZWwgUmVnbm8gd3JvdGU6 Cj4+Pj4gTW92ZSB0aGUgY2FsbCB0byBwbGF0Zm9ybV9nZXRfaXJxKCkgZWFybGllciBpbiB0aGUg cHJvYmUgZnVuY3Rpb24KPj4+PiBhbmQgY2hlY2sgZm9yIGl0cyByZXR1cm4gdmFsdWU6IGlmIG5v IGludGVycnVwdCBpcyBzcGVjaWZpZWQsIGl0Cj4+Pj4gd291bGRuJ3QgbWFrZSBzZW5zZSB0byB0 cnkgdG8gY2FsbCBkZXZtX3JlcXVlc3RfaXJxKCkgc28sIGluIHRoYXQKPj4+PiBjYXNlLCB3ZSBj YW4gc2ltcGx5IHJldHVybiBlYXJseS4KPj4+Pgo+Pj4+IE1vdmluZyB0aGUgcGxhdGZvcm1fZ2V0 X2lycSgpIGNhbGwgYWxzbyBtYWtlcyBpdCBwb3NzaWJsZSB0byB1c2UKPj4+PiBvbmUgbGVzcyBn b3RvLCBhcyBjbG9ja3MgYXJlbid0IHJlcXVpcmVkIGF0IHRoYXQgc3RhZ2UuCj4+Pj4KPj4+PiBT aWduZWQtb2ZmLWJ5OiBBbmdlbG9HaW9hY2NoaW5vIERlbCBSZWdubyAKPj4+PiA8YW5nZWxvZ2lv YWNjaGluby5kZWxyZWdub0Bjb2xsYWJvcmEuY29tPgo+Pj4+IFJldmlld2VkLWJ5OiBOw61jb2xh cyBGLiBSLiBBLiBQcmFkbyA8bmZyYXByYWRvQGNvbGxhYm9yYS5jb20+Cj4+Pj4gVGVzdGVkLWJ5 OiBOw61jb2xhcyBGLiBSLiBBLiBQcmFkbyA8bmZyYXByYWRvQGNvbGxhYm9yYS5jb20+Cj4+Pj4g LS0tCj4+Pj4gwqAgZHJpdmVycy9zb2MvbWVkaWF0ZWsvbXRrLXBtaWMtd3JhcC5jIHwgNSArKysr LQo+Pj4+IMKgIDEgZmlsZSBjaGFuZ2VkLCA0IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkK Pj4+Pgo+Pj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3NvYy9tZWRpYXRlay9tdGstcG1pYy13cmFw LmMgCj4+Pj4gYi9kcml2ZXJzL3NvYy9tZWRpYXRlay9tdGstcG1pYy13cmFwLmMKPj4+PiBpbmRl eCA4NTI1MTQzNjZmMWYuLjMzMmNiY2FiYzI5OSAxMDA2NDQKPj4+PiAtLS0gYS9kcml2ZXJzL3Nv Yy9tZWRpYXRlay9tdGstcG1pYy13cmFwLmMKPj4+PiArKysgYi9kcml2ZXJzL3NvYy9tZWRpYXRl ay9tdGstcG1pYy13cmFwLmMKPj4+PiBAQCAtMjIwNCw2ICsyMjA0LDEwIEBAIHN0YXRpYyBpbnQg cHdyYXBfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPj4+PiDCoMKgwqDCoMKg IGlmICghd3JwKQo+Pj4+IMKgwqDCoMKgwqDCoMKgwqDCoCByZXR1cm4gLUVOT01FTTsKPj4+PiAr wqDCoMKgIGlycSA9IHBsYXRmb3JtX2dldF9pcnEocGRldiwgMCk7Cj4+Pj4gK8KgwqDCoCBpZiAo aXJxIDwgMCkKPj4+PiArwqDCoMKgwqDCoMKgwqAgcmV0dXJuIGlycTsKPj4+PiArCj4+Pj4gwqDC oMKgwqDCoCBwbGF0Zm9ybV9zZXRfZHJ2ZGF0YShwZGV2LCB3cnApOwo+Pj4+IMKgwqDCoMKgwqAg d3JwLT5tYXN0ZXIgPSBvZl9kZXZpY2VfZ2V0X21hdGNoX2RhdGEoJnBkZXYtPmRldik7Cj4+Pj4g QEAgLTIzMTYsNyArMjMyMCw2IEBAIHN0YXRpYyBpbnQgcHdyYXBfcHJvYmUoc3RydWN0IHBsYXRm b3JtX2RldmljZSAqcGRldikKPj4+PiDCoMKgwqDCoMKgIGlmIChIQVNfQ0FQKHdycC0+bWFzdGVy LT5jYXBzLCBQV1JBUF9DQVBfSU5UMV9FTikpCj4+Pj4gwqDCoMKgwqDCoMKgwqDCoMKgIHB3cmFw X3dyaXRlbCh3cnAsIHdycC0+bWFzdGVyLT5pbnQxX2VuX2FsbCwgUFdSQVBfSU5UMV9FTik7Cj4+ Pj4gLcKgwqDCoCBpcnEgPSBwbGF0Zm9ybV9nZXRfaXJxKHBkZXYsIDApOwo+Pj4KPj4+IEZvciBi ZXR0ZXIgcmVhZGFiaWxpdHkgb2YgdGhlIGNvZGUgSSdkIHByZWZlciB0byBrZWVwIHBsYXRmb3Jt X2dldF9pcnEgbmV4dCB0byAKPj4+IGRldm1fcmVxdWVzdF9pcnEuIEkgdW5kZXJzdGFuZCB0aGF0 IHlvdSBkaWQgdGhpcyBjaGFuZ2Ugc28gdGhhdCB5b3UgZG9uJ3QgaGF2ZSAKPj4+IHRvIGNvZGUK Pj4+IGlmIChpcnEgPCAwKSB7Cj4+PiDCoMKgwqDCoCByZXQgPSBpcnE7Cj4+PiDCoMKgwqDCoCBn b3RvIGVycl9vdXQyOwo+Pj4gfQo+Pj4KPj4+IE9yIGRvIEkgbWlzcyBzb21ldGhpbmc/Cj4+Pgo+ Pgo+PiBUaGF0J3MgZm9yIHRoZSBzYWtlIG9mIHJlZHVjaW5nIGdvdG9zIGluIHRoZSBjb2RlLi4u IGJ1dCB0aGVyZSdzIGEgYmlnZ2VyCj4+IHBpY3R1cmUgdGhhdCBJIGhhdmVuJ3QgZXhwbGFpbmVk IGluIHRoaXMgY29tbWl0IGFuZCB0aGF0IHdpbGwgY29tZSBsYXRlcgo+PiBiZWNhdXNlIEkgY3Vy cmVudGx5IGRvbid0IGhhdmUgdGhlIG5lY2Vzc2FyeSB0aW1lIHRvIHBlcmZvcm0gYSAiZGVjZW50 Igo+PiB0ZXN0aW5nLgo+Pgo+PiBBcyBJIHdhcyBleHBsYWluaW5nIC0gdGhlIGJpZ2dlciBwaWN0 dXJlcyBpbXBsaWVzIGFkZGluZyBhIG5ldyBmdW5jdGlvbiBmb3IKPj4gY2xvY2sgdGVhcmRvd24s IHRoYXQgd2Ugd2lsbCBhZGQgYXMgYSBkZXZtIGFjdGlvbjoKPj4KPj4gZGV2bV9hZGRfYWN0aW9u X29yX3Jlc2V0KCZwZGV2LT5kZXYsIHB3cmFwX2Nsa19kaXNhYmxlX3VucHJlcGFyZSwgd3JwKQo+ Pgo+PiAuLi5zbyB0aGF0IHdlIHdpbGwgYmUgYWJsZSB0byByZW1vdmUgKmFsbCogZ290b3MgZnJv bSB0aGUgcHJvYmUgZnVuY3Rpb24uCj4+Cj4+IFNvdW5kcyBnb29kPwo+Pgo+IAo+IFNvdW5kcyBn b29kLCBidXQgdGhhdCBtZWFucyB3ZSBjb3VsZCBnZXQgcmlkIG9mIHRoZSBnb3RvIGFzIHdlbGwu IEFueXdheSBJIHByZWZlciAKPiB0byBoYXZlIHBsYXRmb3JtX2dldF9pcnEgbmV4dCB0byBkZXZt X3JlcXVlc3RfaXJxLiBJZiB3ZSBjYW4gZ2V0IHJpZCBvZiB0aGUgZ290byBpbiAKPiB0aGUgZnV0 dXJlLCBncmVhdC4KCk9raSwgdGhlbiBJJ2xsIHNlbmQgYSB2NCBhbmQgYXZvaWQgdG8gbW92ZSB0 aGF0IG9uZSBlbHNld2hlcmUgLSB3aWxsIGtlZXAgdGhlIGdvdG8KYXMgd2VsbC4KCkxvb2tpbmcg YmFjayBhdCBpdCwgZWZmZWN0aXZlbHksIGl0IGRvZXNuJ3QgcmVhbGx5IG1ha2Ugc2Vuc2UgdG8g bW92ZSB0aGF0IGNhbGwhCgpDaGVlcnMsCkFuZ2VsbwoKCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4LW1lZGlhdGVrIG1haWxpbmcgbGlzdApMaW51 eC1tZWRpYXRla0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3Jn L21haWxtYW4vbGlzdGluZm8vbGludXgtbWVkaWF0ZWsK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CC605C433F5 for ; Tue, 17 May 2022 10:36:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=D1gje8lIWWwyKEiL9bA3xfMYjUc8kpLXF0nOIQPQ+r8=; b=rQtZ3hvpbGe6bk rRoDbgyJQg1ci2wqIcIZ14bUqwbJlt1cBb5pwuC1/U/qWXL0J7Co0fjcgF/3v1DjrRRBgLXe5gx64 bYo53JXtGbN0tSNyOPQ+2RmHTRlcdYPGwVI0QLPk5Ik0TfMdBjqhYyzWJmxjmKxkyRVEaWbtywCvj 9NqVlt0pkpiwDEIaFG0A39uHnAkUmfHIQJ104J3WMkv2wfdKQR/+lREWQazoYbgnLO6hsAw5bV94e 4Qgf0PSzv7rSgyxvI1GGXjRe7Z79auPtiXcyQntsv9NCAiV/z4/RwI866tyzSS+snL5kik6Yz/Guk /vtacCafqepqcUZe+mZA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nquYV-00D8Xi-6K; Tue, 17 May 2022 10:35:55 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nquYR-00D8Vw-Ih; Tue, 17 May 2022 10:35:53 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: kholk11) with ESMTPSA id CE2101F44492 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1652783750; bh=wpmWddblxYyDkBmT+shBpq8yfbqgog90VUPSoVh9U78=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=QV0ki/Z8y09yodZ2xxdyb0epnntinN05WbfPtvPW7os5p9uqkYFgi10FEYcuA2AhF LR4xSTOcpw5+u7037yRzO622+rc+TqcXTxWRPGTGfFDYBqYVp7Eo2Ry62RMydmeVnM hD++8l2KKSLzi5F9sWqcc9w7N+lDX0DAvEye/kt0NPVWTtrCOifeJR2ME74hJt6FIV GJ2RQLsWuorKNkNWhfKLwTC++Ikb/W3emy6hBJHRZ9mY/YITDykiVUzjpvfmBC+4cb GqkIUWiV3qz4gFxVi+g7nT1kAMX9dSdXIVYngBVY3KCpx4afYMxtfKJGmB23DcpeTZ m20C0aYGtQQ0A== Message-ID: <7f4f12ef-4fda-2092-1129-d0be498c7b20@collabora.com> Date: Tue, 17 May 2022 12:35:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v3 3/5] soc: mediatek: pwrap: Move and check return value of platform_get_irq() Content-Language: en-US To: Matthias Brugger Cc: linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, nfraprado@collabora.com, rex-bc.chen@mediatek.com, zhiyong.tao@mediatek.com References: <20220516124659.69484-1-angelogioacchino.delregno@collabora.com> <20220516124659.69484-4-angelogioacchino.delregno@collabora.com> <03ac9b18-cb5d-5ff6-d220-f2f4062cea7e@collabora.com> From: AngeloGioacchino Del Regno In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220517_033551_788945_26CD0180 X-CRM114-Status: GOOD ( 23.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SWwgMTcvMDUvMjIgMTE6NDksIE1hdHRoaWFzIEJydWdnZXIgaGEgc2NyaXR0bzoKPiAKPiAKPiBP biAxNy8wNS8yMDIyIDExOjM0LCBBbmdlbG9HaW9hY2NoaW5vIERlbCBSZWdubyB3cm90ZToKPj4g SWwgMTcvMDUvMjIgMTE6MTgsIE1hdHRoaWFzIEJydWdnZXIgaGEgc2NyaXR0bzoKPj4+Cj4+Pgo+ Pj4gT24gMTYvMDUvMjAyMiAxNDo0NiwgQW5nZWxvR2lvYWNjaGlubyBEZWwgUmVnbm8gd3JvdGU6 Cj4+Pj4gTW92ZSB0aGUgY2FsbCB0byBwbGF0Zm9ybV9nZXRfaXJxKCkgZWFybGllciBpbiB0aGUg cHJvYmUgZnVuY3Rpb24KPj4+PiBhbmQgY2hlY2sgZm9yIGl0cyByZXR1cm4gdmFsdWU6IGlmIG5v IGludGVycnVwdCBpcyBzcGVjaWZpZWQsIGl0Cj4+Pj4gd291bGRuJ3QgbWFrZSBzZW5zZSB0byB0 cnkgdG8gY2FsbCBkZXZtX3JlcXVlc3RfaXJxKCkgc28sIGluIHRoYXQKPj4+PiBjYXNlLCB3ZSBj YW4gc2ltcGx5IHJldHVybiBlYXJseS4KPj4+Pgo+Pj4+IE1vdmluZyB0aGUgcGxhdGZvcm1fZ2V0 X2lycSgpIGNhbGwgYWxzbyBtYWtlcyBpdCBwb3NzaWJsZSB0byB1c2UKPj4+PiBvbmUgbGVzcyBn b3RvLCBhcyBjbG9ja3MgYXJlbid0IHJlcXVpcmVkIGF0IHRoYXQgc3RhZ2UuCj4+Pj4KPj4+PiBT aWduZWQtb2ZmLWJ5OiBBbmdlbG9HaW9hY2NoaW5vIERlbCBSZWdubyAKPj4+PiA8YW5nZWxvZ2lv YWNjaGluby5kZWxyZWdub0Bjb2xsYWJvcmEuY29tPgo+Pj4+IFJldmlld2VkLWJ5OiBOw61jb2xh cyBGLiBSLiBBLiBQcmFkbyA8bmZyYXByYWRvQGNvbGxhYm9yYS5jb20+Cj4+Pj4gVGVzdGVkLWJ5 OiBOw61jb2xhcyBGLiBSLiBBLiBQcmFkbyA8bmZyYXByYWRvQGNvbGxhYm9yYS5jb20+Cj4+Pj4g LS0tCj4+Pj4gwqAgZHJpdmVycy9zb2MvbWVkaWF0ZWsvbXRrLXBtaWMtd3JhcC5jIHwgNSArKysr LQo+Pj4+IMKgIDEgZmlsZSBjaGFuZ2VkLCA0IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkK Pj4+Pgo+Pj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3NvYy9tZWRpYXRlay9tdGstcG1pYy13cmFw LmMgCj4+Pj4gYi9kcml2ZXJzL3NvYy9tZWRpYXRlay9tdGstcG1pYy13cmFwLmMKPj4+PiBpbmRl eCA4NTI1MTQzNjZmMWYuLjMzMmNiY2FiYzI5OSAxMDA2NDQKPj4+PiAtLS0gYS9kcml2ZXJzL3Nv Yy9tZWRpYXRlay9tdGstcG1pYy13cmFwLmMKPj4+PiArKysgYi9kcml2ZXJzL3NvYy9tZWRpYXRl ay9tdGstcG1pYy13cmFwLmMKPj4+PiBAQCAtMjIwNCw2ICsyMjA0LDEwIEBAIHN0YXRpYyBpbnQg cHdyYXBfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPj4+PiDCoMKgwqDCoMKg IGlmICghd3JwKQo+Pj4+IMKgwqDCoMKgwqDCoMKgwqDCoCByZXR1cm4gLUVOT01FTTsKPj4+PiAr wqDCoMKgIGlycSA9IHBsYXRmb3JtX2dldF9pcnEocGRldiwgMCk7Cj4+Pj4gK8KgwqDCoCBpZiAo aXJxIDwgMCkKPj4+PiArwqDCoMKgwqDCoMKgwqAgcmV0dXJuIGlycTsKPj4+PiArCj4+Pj4gwqDC oMKgwqDCoCBwbGF0Zm9ybV9zZXRfZHJ2ZGF0YShwZGV2LCB3cnApOwo+Pj4+IMKgwqDCoMKgwqAg d3JwLT5tYXN0ZXIgPSBvZl9kZXZpY2VfZ2V0X21hdGNoX2RhdGEoJnBkZXYtPmRldik7Cj4+Pj4g QEAgLTIzMTYsNyArMjMyMCw2IEBAIHN0YXRpYyBpbnQgcHdyYXBfcHJvYmUoc3RydWN0IHBsYXRm b3JtX2RldmljZSAqcGRldikKPj4+PiDCoMKgwqDCoMKgIGlmIChIQVNfQ0FQKHdycC0+bWFzdGVy LT5jYXBzLCBQV1JBUF9DQVBfSU5UMV9FTikpCj4+Pj4gwqDCoMKgwqDCoMKgwqDCoMKgIHB3cmFw X3dyaXRlbCh3cnAsIHdycC0+bWFzdGVyLT5pbnQxX2VuX2FsbCwgUFdSQVBfSU5UMV9FTik7Cj4+ Pj4gLcKgwqDCoCBpcnEgPSBwbGF0Zm9ybV9nZXRfaXJxKHBkZXYsIDApOwo+Pj4KPj4+IEZvciBi ZXR0ZXIgcmVhZGFiaWxpdHkgb2YgdGhlIGNvZGUgSSdkIHByZWZlciB0byBrZWVwIHBsYXRmb3Jt X2dldF9pcnEgbmV4dCB0byAKPj4+IGRldm1fcmVxdWVzdF9pcnEuIEkgdW5kZXJzdGFuZCB0aGF0 IHlvdSBkaWQgdGhpcyBjaGFuZ2Ugc28gdGhhdCB5b3UgZG9uJ3QgaGF2ZSAKPj4+IHRvIGNvZGUK Pj4+IGlmIChpcnEgPCAwKSB7Cj4+PiDCoMKgwqDCoCByZXQgPSBpcnE7Cj4+PiDCoMKgwqDCoCBn b3RvIGVycl9vdXQyOwo+Pj4gfQo+Pj4KPj4+IE9yIGRvIEkgbWlzcyBzb21ldGhpbmc/Cj4+Pgo+ Pgo+PiBUaGF0J3MgZm9yIHRoZSBzYWtlIG9mIHJlZHVjaW5nIGdvdG9zIGluIHRoZSBjb2RlLi4u IGJ1dCB0aGVyZSdzIGEgYmlnZ2VyCj4+IHBpY3R1cmUgdGhhdCBJIGhhdmVuJ3QgZXhwbGFpbmVk IGluIHRoaXMgY29tbWl0IGFuZCB0aGF0IHdpbGwgY29tZSBsYXRlcgo+PiBiZWNhdXNlIEkgY3Vy cmVudGx5IGRvbid0IGhhdmUgdGhlIG5lY2Vzc2FyeSB0aW1lIHRvIHBlcmZvcm0gYSAiZGVjZW50 Igo+PiB0ZXN0aW5nLgo+Pgo+PiBBcyBJIHdhcyBleHBsYWluaW5nIC0gdGhlIGJpZ2dlciBwaWN0 dXJlcyBpbXBsaWVzIGFkZGluZyBhIG5ldyBmdW5jdGlvbiBmb3IKPj4gY2xvY2sgdGVhcmRvd24s IHRoYXQgd2Ugd2lsbCBhZGQgYXMgYSBkZXZtIGFjdGlvbjoKPj4KPj4gZGV2bV9hZGRfYWN0aW9u X29yX3Jlc2V0KCZwZGV2LT5kZXYsIHB3cmFwX2Nsa19kaXNhYmxlX3VucHJlcGFyZSwgd3JwKQo+ Pgo+PiAuLi5zbyB0aGF0IHdlIHdpbGwgYmUgYWJsZSB0byByZW1vdmUgKmFsbCogZ290b3MgZnJv bSB0aGUgcHJvYmUgZnVuY3Rpb24uCj4+Cj4+IFNvdW5kcyBnb29kPwo+Pgo+IAo+IFNvdW5kcyBn b29kLCBidXQgdGhhdCBtZWFucyB3ZSBjb3VsZCBnZXQgcmlkIG9mIHRoZSBnb3RvIGFzIHdlbGwu IEFueXdheSBJIHByZWZlciAKPiB0byBoYXZlIHBsYXRmb3JtX2dldF9pcnEgbmV4dCB0byBkZXZt X3JlcXVlc3RfaXJxLiBJZiB3ZSBjYW4gZ2V0IHJpZCBvZiB0aGUgZ290byBpbiAKPiB0aGUgZnV0 dXJlLCBncmVhdC4KCk9raSwgdGhlbiBJJ2xsIHNlbmQgYSB2NCBhbmQgYXZvaWQgdG8gbW92ZSB0 aGF0IG9uZSBlbHNld2hlcmUgLSB3aWxsIGtlZXAgdGhlIGdvdG8KYXMgd2VsbC4KCkxvb2tpbmcg YmFjayBhdCBpdCwgZWZmZWN0aXZlbHksIGl0IGRvZXNuJ3QgcmVhbGx5IG1ha2Ugc2Vuc2UgdG8g bW92ZSB0aGF0IGNhbGwhCgpDaGVlcnMsCkFuZ2VsbwoKCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0Cmxp bnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFk Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C579C433EF for ; Tue, 17 May 2022 10:36:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344428AbiEQKgp (ORCPT ); Tue, 17 May 2022 06:36:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52084 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344528AbiEQKgF (ORCPT ); Tue, 17 May 2022 06:36:05 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E2AE5F9E for ; Tue, 17 May 2022 03:35:51 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: kholk11) with ESMTPSA id CE2101F44492 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1652783750; bh=wpmWddblxYyDkBmT+shBpq8yfbqgog90VUPSoVh9U78=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=QV0ki/Z8y09yodZ2xxdyb0epnntinN05WbfPtvPW7os5p9uqkYFgi10FEYcuA2AhF LR4xSTOcpw5+u7037yRzO622+rc+TqcXTxWRPGTGfFDYBqYVp7Eo2Ry62RMydmeVnM hD++8l2KKSLzi5F9sWqcc9w7N+lDX0DAvEye/kt0NPVWTtrCOifeJR2ME74hJt6FIV GJ2RQLsWuorKNkNWhfKLwTC++Ikb/W3emy6hBJHRZ9mY/YITDykiVUzjpvfmBC+4cb GqkIUWiV3qz4gFxVi+g7nT1kAMX9dSdXIVYngBVY3KCpx4afYMxtfKJGmB23DcpeTZ m20C0aYGtQQ0A== Message-ID: <7f4f12ef-4fda-2092-1129-d0be498c7b20@collabora.com> Date: Tue, 17 May 2022 12:35:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v3 3/5] soc: mediatek: pwrap: Move and check return value of platform_get_irq() Content-Language: en-US To: Matthias Brugger Cc: linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, nfraprado@collabora.com, rex-bc.chen@mediatek.com, zhiyong.tao@mediatek.com References: <20220516124659.69484-1-angelogioacchino.delregno@collabora.com> <20220516124659.69484-4-angelogioacchino.delregno@collabora.com> <03ac9b18-cb5d-5ff6-d220-f2f4062cea7e@collabora.com> From: AngeloGioacchino Del Regno In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 17/05/22 11:49, Matthias Brugger ha scritto: > > > On 17/05/2022 11:34, AngeloGioacchino Del Regno wrote: >> Il 17/05/22 11:18, Matthias Brugger ha scritto: >>> >>> >>> On 16/05/2022 14:46, AngeloGioacchino Del Regno wrote: >>>> Move the call to platform_get_irq() earlier in the probe function >>>> and check for its return value: if no interrupt is specified, it >>>> wouldn't make sense to try to call devm_request_irq() so, in that >>>> case, we can simply return early. >>>> >>>> Moving the platform_get_irq() call also makes it possible to use >>>> one less goto, as clocks aren't required at that stage. >>>> >>>> Signed-off-by: AngeloGioacchino Del Regno >>>> >>>> Reviewed-by: Nícolas F. R. A. Prado >>>> Tested-by: Nícolas F. R. A. Prado >>>> --- >>>>   drivers/soc/mediatek/mtk-pmic-wrap.c | 5 ++++- >>>>   1 file changed, 4 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c >>>> b/drivers/soc/mediatek/mtk-pmic-wrap.c >>>> index 852514366f1f..332cbcabc299 100644 >>>> --- a/drivers/soc/mediatek/mtk-pmic-wrap.c >>>> +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c >>>> @@ -2204,6 +2204,10 @@ static int pwrap_probe(struct platform_device *pdev) >>>>       if (!wrp) >>>>           return -ENOMEM; >>>> +    irq = platform_get_irq(pdev, 0); >>>> +    if (irq < 0) >>>> +        return irq; >>>> + >>>>       platform_set_drvdata(pdev, wrp); >>>>       wrp->master = of_device_get_match_data(&pdev->dev); >>>> @@ -2316,7 +2320,6 @@ static int pwrap_probe(struct platform_device *pdev) >>>>       if (HAS_CAP(wrp->master->caps, PWRAP_CAP_INT1_EN)) >>>>           pwrap_writel(wrp, wrp->master->int1_en_all, PWRAP_INT1_EN); >>>> -    irq = platform_get_irq(pdev, 0); >>> >>> For better readability of the code I'd prefer to keep platform_get_irq next to >>> devm_request_irq. I understand that you did this change so that you don't have >>> to code >>> if (irq < 0) { >>>      ret = irq; >>>      goto err_out2; >>> } >>> >>> Or do I miss something? >>> >> >> That's for the sake of reducing gotos in the code... but there's a bigger >> picture that I haven't explained in this commit and that will come later >> because I currently don't have the necessary time to perform a "decent" >> testing. >> >> As I was explaining - the bigger pictures implies adding a new function for >> clock teardown, that we will add as a devm action: >> >> devm_add_action_or_reset(&pdev->dev, pwrap_clk_disable_unprepare, wrp) >> >> ...so that we will be able to remove *all* gotos from the probe function. >> >> Sounds good? >> > > Sounds good, but that means we could get rid of the goto as well. Anyway I prefer > to have platform_get_irq next to devm_request_irq. If we can get rid of the goto in > the future, great. Oki, then I'll send a v4 and avoid to move that one elsewhere - will keep the goto as well. Looking back at it, effectively, it doesn't really make sense to move that call! Cheers, Angelo