From: Florian Eckert <fe@dev.tdt.de>
To: Konstantin Aladyshev <aladyshev22@gmail.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-acpi@vger.kernel.org, linux-i2c@vger.kernel.org
Subject: Re: Adding I2C devices to the SMBus (PIIX4) via the ACPI SSDT overlay method
Date: Fri, 08 Nov 2024 10:27:08 +0100 [thread overview]
Message-ID: <7fc0f59b8264e965efc96c0aa0ba4c31@dev.tdt.de> (raw)
In-Reply-To: <Zy3P7ld7UUL8XCrR@smile.fi.intel.com>
Hello Konstantin,
On 2024-11-08 09:46, Andy Shevchenko wrote:
> +Cc: Florian (as this indeed rang a bell to me)
>
> https://lore.kernel.org/all/d84fb798722762862a7fb08f1e343b6a@dev.tdt.de/
The message was forwarded by Andy because I had a similar problem with
my APU3 [1]
from PC-engine [2], which is also using the PIIX4 for I2C (SMBUS).
>> Maybe I need to modify ACPI code somehow to create these
>> 'physical_nodesX' folders for the relevant i2c-7/8/9 buses?
I don't know if that helps, but with the following SSDT overlay I
managed
to get the driver to feel responsible for the mcp23017 via the I2C
(SMBUS) of
the APU3. The mcp23017 is used on my APU3 to add additional LEDs to
'/sys/class/leds'.
```
DefinitionBlock ("mcp.aml", "SSDT", 5, "TEST", "MCP", 2)
{
External (\_SB.PCI0.SBUS, DeviceObj)
Scope (\_SB.PCI0.SBUS)
{
Device (I2C0)
{
Name (_ADR, Zero)
Device (GPIO)
{
Name (_HID, "PRP0001")
Name (_DDN, "MCP23017 pinctrl")
Name (_CRS, ResourceTemplate ()
{
I2cSerialBus (
0x24,
ControllerInitiated,
100000,
AddressingMode7Bit,
"\\_SB.PCI0.SBUS.I2C0",
0x00
)
})
Name (_DSD, Package ()
{
ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
Package () {
Package () {
"compatible", "microchip,mcp23017" },
}
})
Device (LEDS)
{
Name (_HID, "PRP0001")
Name (_DDN, "GPIO LEDs device")
Name (_CRS, ResourceTemplate ()
{
GpioIo (
Exclusive,
PullNone,
0,
0,
IoRestrictionOutputOnly,
"\\_SB.PCI0.SBUS.I2C0.GPIO",
0)
{
0,
1,
2,
3,
4,
5,
6,
7,
}
})
Name (_DSD, Package () {
ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
Package () {
Package () {
"compatible", Package() { "gpio-leds" } },
},
ToUUID("dbb8e3e6-5886-4ba6-8795-1319f52a966b"),
Package () {
Package ()
{"led-0", "LED0"},
Package ()
{"led-1", "LED1"},
Package ()
{"led-2", "LED2"},
Package ()
{"led-3", "LED3"},
Package ()
{"led-4", "LED4"},
Package ()
{"led-5", "LED5"},
Package ()
{"led-6", "LED6"},
Package ()
{"led-7", "LED7"},
}
})
Name (LED0, Package () {
ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
Package () {
Package ()
{"label", "khan:green:led1"},
Package ()
{"default-state", "off"},
Package ()
{"linux,default-trigger", "default-off"},
Package ()
{"gpios", Package () {^LEDS, 0, 0, 1}},
Package ()
{"retain-state-suspended", 1},
}
})
Name (LED1, Package () {
ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
Package () {
Package ()
{"label", "khan:green:led2"},
Package ()
{"default-state", "off"},
Package
() {"linux,default-trigger", "default-off"},
Package ()
{"gpios", Package () {^LEDS, 0, 1, 1}},
Package ()
{"retain-state-suspended", 1},
}
})
Name (LED2, Package () {
ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
Package () {
Package ()
{"label", "khan:green:led3"},
Package ()
{"default-state", "off"},
Package ()
{"linux,default-trigger", "default-off"},
Package ()
{"gpios", Package () {^LEDS, 0, 2, 1}},
Package ()
{"retain-state-suspended", 1},
}
})
Name (LED3, Package () {
ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
Package () {
Package ()
{"label", "khan:green:led4"},
Package ()
{"default-state", "off"},
Package ()
{"linux,default-trigger", "default-off"},
Package ()
{"gpios", Package () {^LEDS, 0, 3, 1}},
Package ()
{"retain-state-suspended", 1},
}
})
Name (LED4, Package () {
ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
Package () {
Package ()
{"label", "khan:green:led5"},
Package ()
{"default-state", "off"},
Package ()
{"linux,default-trigger", "default-off"},
Package ()
{"gpios", Package () {^LEDS, 0, 4, 1}},
Package ()
{"retain-state-suspended", 1},
}
})
Name (LED5, Package () {
ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
Package () {
Package ()
{"label", "khan:green:led6"},
Package ()
{"default-state", "off"},
Package ()
{"linux,default-trigger", "default-off"},
Package ()
{"gpios", Package () {^LEDS, 0, 5, 1}},
Package ()
{"retain-state-suspended", 1},
}
})
Name (LED6, Package () {
ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
Package () {
Package ()
{"label", "khan:green:led7"},
Package ()
{"default-state", "off"},
Package ()
{"linux,default-trigger", "default-off"},
Package ()
{"gpios", Package () {^LEDS, 0, 6, 1}},
Package ()
{"retain-state-suspended", 1},
}
})
Name (LED7, Package () {
ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
Package () {
Package ()
{"label", "khan:red:led8"},
Package ()
{"default-state", "off"},
Package ()
{"linux,default-trigger", "default-off"},
Package ()
{"gpios", Package () {^LEDS, 0, 7, 1}},
Package ()
{"retain-state-suspended", 1},
}
})
}
}
}
}
}
```
Best regards
Florian
[1] https://pcengines.ch/apu3d4.htm
[2] https://pcengines.ch/
[3]
https://github.com/pcengines/coreboot/blob/8d3e714804b1b2bb5bc89e3ffd9cb3c34f8eb0c6/src/southbridge/amd/pi/hudson/acpi/fch.asl#L29
next prev parent reply other threads:[~2024-11-08 9:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-07 15:51 Adding I2C devices to the SMBus (PIIX4) via the ACPI SSDT overlay method Konstantin Aladyshev
2024-11-08 8:26 ` Andy Shevchenko
2024-11-08 8:29 ` Andy Shevchenko
2024-11-08 8:46 ` Andy Shevchenko
2024-11-08 9:27 ` Florian Eckert [this message]
2024-11-08 11:23 ` Andy Shevchenko
2024-11-08 11:48 ` Konstantin Aladyshev
2024-11-08 12:47 ` Andy Shevchenko
2024-11-11 12:09 ` Konstantin Aladyshev
2024-11-11 12:48 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7fc0f59b8264e965efc96c0aa0ba4c31@dev.tdt.de \
--to=fe@dev.tdt.de \
--cc=aladyshev22@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.