From: Jan Beulich <jbeulich@suse.com>
To: Dmytro Prokopchuk1 <dmytro_prokopchuk1@epam.com>
Cc: "Roger Pau Monné" <roger.pau@citrix.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [XEN PATCH v2 1/3] iommu: address violation of MISRA C Rule 5.5
Date: Thu, 10 Jul 2025 10:21:30 +0200 [thread overview]
Message-ID: <7fde4d6c-eadc-4c17-a88a-80714362bdca@suse.com> (raw)
In-Reply-To: <0a7a954cdf899845f51427fa6b44915f28b2cb90.1752096263.git.dmytro_prokopchuk1@epam.com>
On 09.07.2025 23:38, Dmytro Prokopchuk1 wrote:
> Address a violation of MISRA C:2012 Rule 5.5:
> "Identifiers shall be distinct from macro names".
>
> Reports for service MC3A2.R5.5:
> xen/drivers/passthrough/iommu.c: non-compliant macro 'iommu_quarantine'
> xen/include/xen/iommu.h: non-compliant variable 'iommu_quarantine'
>
> There is a clash between function name and macro.
> Add an 'extern' declaration for 'iommu_quarantine'
> under the same preprocessor condition (#ifdef CONFIG_HAS_PCI).
Perhaps s/Add an/Put the/ or some such? You don't add any declaration,
after all.
> This ensures that the declaration is consistent
> and only exposed when CONFIG_HAS_PCI is defined.
>
> Signed-off-by: Dmytro Prokopchuk <dmytro_prokopchuk1@epam.com>
With some suitable adjustment (happy to make while committing as long as
you agree):
Reviewed-by: Jan Beulich <jbeulich@suse.com>
Jan
next prev parent reply other threads:[~2025-07-10 8:21 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-09 21:38 [XEN PATCH v2 0/3] address violation of MISRA C Rule 5.5 Dmytro Prokopchuk1
2025-07-09 21:38 ` [XEN PATCH v2 1/3] iommu: " Dmytro Prokopchuk1
2025-07-10 8:21 ` Jan Beulich [this message]
2025-07-10 9:44 ` Dmytro Prokopchuk1
2025-07-10 9:47 ` Dmytro Prokopchuk1
2025-07-09 21:38 ` [XEN PATCH v2 2/3] device-tree: " Dmytro Prokopchuk1
2025-07-09 21:38 ` [XEN PATCH v2 3/3] eclair: add deviations " Dmytro Prokopchuk1
2025-07-11 2:17 ` Stefano Stabellini
2025-07-11 8:28 ` Nicola Vetrini
2025-07-12 1:13 ` Stefano Stabellini
2025-07-12 7:45 ` Nicola Vetrini
2025-07-14 7:55 ` Jan Beulich
2025-07-15 9:46 ` Dmytro Prokopchuk1
2025-07-15 10:01 ` Jan Beulich
2025-07-15 10:07 ` Dmytro Prokopchuk1
2025-07-15 10:39 ` Jan Beulich
2025-07-15 10:45 ` Dmytro Prokopchuk1
2025-07-15 10:50 ` Jan Beulich
2025-07-16 16:04 ` Dmytro Prokopchuk1
2025-07-16 16:20 ` Jan Beulich
2025-07-16 16:52 ` Nicola Vetrini
2025-07-16 18:03 ` Dmytro Prokopchuk1
2025-07-09 21:55 ` [XEN PATCH v2 0/3] address violation " Dmytro Prokopchuk1
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7fde4d6c-eadc-4c17-a88a-80714362bdca@suse.com \
--to=jbeulich@suse.com \
--cc=dmytro_prokopchuk1@epam.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.