From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f46.google.com ([209.85.220.46]:34370 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753610AbbFPPCi (ORCPT ); Tue, 16 Jun 2015 11:02:38 -0400 Received: by pacgb13 with SMTP id gb13so14497565pac.1 for ; Tue, 16 Jun 2015 08:02:37 -0700 (PDT) From: Kevin Hilman To: Boris Brezillon Cc: Thomas Petazzoni , Gregory CLEMENT , Jason Cooper , Sebastian Hesselbarth , Andrew Lunn , Mike Turquette , Stephen Boyd , linux-clk@vger.kernel.org, Tawfik Bayouk , Lior Amsalem , Nadav Haklai , Eran Ben-Avi , linux-arm-kernel@lists.infradead.org, Subject: Re: [PATCH] clk: mvebu: flag the crypto clk as CLK_IGNORE_UNUSED References: <1434453721-24070-1-git-send-email-boris.brezillon@free-electrons.com> Date: Tue, 16 Jun 2015 08:02:34 -0700 In-Reply-To: <1434453721-24070-1-git-send-email-boris.brezillon@free-electrons.com> (Boris Brezillon's message of "Tue, 16 Jun 2015 13:22:01 +0200") Message-ID: <7h381r1yt1.fsf@deeprootsystems.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-clk-owner@vger.kernel.org List-ID: Boris Brezillon writes: > Fixes: 29e623475c50267ee3aaa49ebb6cbe107bce8d2a ("clk: mvebu: add > missing CESA gate clk"). Which was: Reported-by: Kevin Hilman > The crypto SRAM, used by the armada 370 cpuidle code to workaround a bug > in the BootROM code, requires the crypto clk to be up and running. > Flag the the crypto clk as IGNORE_UNUSED until we add the proper > infrastructure to define the crypto SRAM in the DT and reference the crypto > clk in this SRAM node. > > Signed-off-by: Boris Brezillon > Cc: #4.1 > --- > drivers/clk/mvebu/armada-370.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/mvebu/armada-370.c b/drivers/clk/mvebu/armada-370.c > index c19fd77..7c2a58c 100644 > --- a/drivers/clk/mvebu/armada-370.c > +++ b/drivers/clk/mvebu/armada-370.c > @@ -163,7 +163,7 @@ static const struct clk_gating_soc_desc a370_gating_desc[] __initconst = { > { "pex1", "pex1_en", 9, 0 }, > { "sata0", NULL, 15, 0 }, > { "sdio", NULL, 17, 0 }, > - { "crypto", NULL, 23, 0 }, > + { "crypto", NULL, 23, CLK_IGNORE_UNUSED } Doesn't compile. Needs trailing ',' > { "tdm", NULL, 25, 0 }, > { "ddr", NULL, 28, CLK_IGNORE_UNUSED }, > { "sata1", NULL, 30, 0 }, With that fixed, I tested this on top of next-20150615 where mirabox was previously broken and I confirm it's now working. Tested-by: Kevin Hilman Kevin From mboxrd@z Thu Jan 1 00:00:00 1970 From: khilman@kernel.org (Kevin Hilman) Date: Tue, 16 Jun 2015 08:02:34 -0700 Subject: [PATCH] clk: mvebu: flag the crypto clk as CLK_IGNORE_UNUSED In-Reply-To: <1434453721-24070-1-git-send-email-boris.brezillon@free-electrons.com> (Boris Brezillon's message of "Tue, 16 Jun 2015 13:22:01 +0200") References: <1434453721-24070-1-git-send-email-boris.brezillon@free-electrons.com> Message-ID: <7h381r1yt1.fsf@deeprootsystems.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Boris Brezillon writes: > Fixes: 29e623475c50267ee3aaa49ebb6cbe107bce8d2a ("clk: mvebu: add > missing CESA gate clk"). Which was: Reported-by: Kevin Hilman > The crypto SRAM, used by the armada 370 cpuidle code to workaround a bug > in the BootROM code, requires the crypto clk to be up and running. > Flag the the crypto clk as IGNORE_UNUSED until we add the proper > infrastructure to define the crypto SRAM in the DT and reference the crypto > clk in this SRAM node. > > Signed-off-by: Boris Brezillon > Cc: #4.1 > --- > drivers/clk/mvebu/armada-370.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/mvebu/armada-370.c b/drivers/clk/mvebu/armada-370.c > index c19fd77..7c2a58c 100644 > --- a/drivers/clk/mvebu/armada-370.c > +++ b/drivers/clk/mvebu/armada-370.c > @@ -163,7 +163,7 @@ static const struct clk_gating_soc_desc a370_gating_desc[] __initconst = { > { "pex1", "pex1_en", 9, 0 }, > { "sata0", NULL, 15, 0 }, > { "sdio", NULL, 17, 0 }, > - { "crypto", NULL, 23, 0 }, > + { "crypto", NULL, 23, CLK_IGNORE_UNUSED } Doesn't compile. Needs trailing ',' > { "tdm", NULL, 25, 0 }, > { "ddr", NULL, 28, CLK_IGNORE_UNUSED }, > { "sata1", NULL, 30, 0 }, With that fixed, I tested this on top of next-20150615 where mirabox was previously broken and I confirm it's now working. Tested-by: Kevin Hilman Kevin