From: Kevin Hilman <khilman@kernel.org>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Ulf Hansson <ulf.hansson@linaro.org>,
Maciej Matraszek <m.matraszek@samsung.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PM / domains: Align column headers and data in pm_genpd_summary output
Date: Tue, 11 Aug 2015 08:29:48 -0700 [thread overview]
Message-ID: <7h4mk5sv0z.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1439297449-29344-1-git-send-email-geert+renesas@glider.be> (Geert Uytterhoeven's message of "Tue, 11 Aug 2015 14:50:49 +0200")
Geert Uytterhoeven <geert+renesas@glider.be> writes:
> "domain": header is indented by 4, data by 0 spaces => 0 spaces
> "/device": header is indented by 11, data by 4 spaces => 4 spaces
> "slaves": header is indented by 47, data by 49 spaces => 48 spaces
>
> Ruler:
> 1234567890123456789012345678901234567890123456789012345678901234567890
>
> Before:
>
> domain status slaves
> /device runtime status
> ----------------------------------------------------------------------
> a3sp on a2us
> /devices/platform/e60b0000.i2c suspended
>
> After:
>
> domain status slaves
> /device runtime status
> ----------------------------------------------------------------------
> a3sp on a2us
> /devices/platform/e60b0000.i2c suspended
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Kevin Hilman <khilman@linaro.org>
> ---
> drivers/base/power/domain.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
> index c9bc913a938c31e0..a0a99d55022f5387 100644
> --- a/drivers/base/power/domain.c
> +++ b/drivers/base/power/domain.c
> @@ -2082,7 +2082,7 @@ static int pm_genpd_summary_one(struct seq_file *s,
>
> if (WARN_ON(genpd->status >= ARRAY_SIZE(status_lookup)))
> goto exit;
> - seq_printf(s, "%-30s %-15s ", genpd->name, status_lookup[genpd->status]);
> + seq_printf(s, "%-30s %-15s ", genpd->name, status_lookup[genpd->status]);
>
> /*
> * Modifications on the list require holding locks on both
> @@ -2117,8 +2117,8 @@ static int pm_genpd_summary_show(struct seq_file *s, void *data)
> struct generic_pm_domain *genpd;
> int ret = 0;
>
> - seq_puts(s, " domain status slaves\n");
> - seq_puts(s, " /device runtime status\n");
> + seq_puts(s, "domain status slaves\n");
> + seq_puts(s, " /device runtime status\n");
> seq_puts(s, "----------------------------------------------------------------------\n");
>
> ret = mutex_lock_interruptible(&gpd_list_lock);
prev parent reply other threads:[~2015-08-11 15:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-11 12:50 [PATCH] PM / domains: Align column headers and data in pm_genpd_summary output Geert Uytterhoeven
2015-08-11 15:29 ` Kevin Hilman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7h4mk5sv0z.fsf@deeprootsystems.com \
--to=khilman@kernel.org \
--cc=geert+renesas@glider.be \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=m.matraszek@samsung.com \
--cc=rjw@rjwysocki.net \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.