From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E58412192F3 for ; Wed, 18 Jun 2025 20:00:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750276814; cv=none; b=XD1hhROHtsh0qZtKsWAShkCpTfAeYWz3AcwxsG6WubygHORCrVyPHieoHhE7NHsI6V27JFCu09NgUxE+iuAIvx3H32E6VOdWv4wqNTVu59rwJyoe68SFHHS74XtW+5fTmArVN1mW0Y5npYXy+NUZQiW9Z/A+TjFfNncRLhGHjTk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750276814; c=relaxed/simple; bh=Thq4Q06cdpVu9pDEN+/3JBZrpgyjUXOgoUe0gvNvhSk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=kLS+dFogbzYwvepLTJlXuoln3mxh32Y30CiCoNSj6GdvpGFOWZ5Tv8TixU9WRBG2ximrUAR3smeTtNXXoqiwKdOvT+wDixT7hkT1Dl/PZemAnDCVMBtEXvuNTWTec4TXaHtZ3r25GWirhXwhE9mvMTNJQiD2dYqMTc8uPgJp3HU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=f+HQw1a8; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="f+HQw1a8" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-3138b2f0249so6708968a91.2 for ; Wed, 18 Jun 2025 13:00:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1750276812; x=1750881612; darn=vger.kernel.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=KiOzVfjBcF1fRtJg0Y1H//g4cNADDmQDLTn0mBy9kzo=; b=f+HQw1a8sMcwX9xo2U1ygWT+QWYLU0F4HBcOvrIkAhCmztVGuDaq3zoVf/NAP0kpfw b//W5zthQDGjYjyaDRMyN+Vcnbe3zV5Nr6eA5NBgoD21zoiEIKj5XGz8UmEKhmkhSSjP 5UIZtEbw8qUOmBAgLNSxnqYCIRQKGVfkxQQ+5PAhVTqCJspZmoDvMZLberAIxHiWb9+8 E17c2hE79UE6tIXmsD2oGjxPt9ffdno7l/yYSpPPiVPQf6+bZWgsejQCwpSAiGcirihs 6odCbGg5ExPNl15Tr/DCA2ExS8YbnMOl0bMF1ygsFr+6j1t2ZuD4YEvoosB6mIduVVnD +Giw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750276812; x=1750881612; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KiOzVfjBcF1fRtJg0Y1H//g4cNADDmQDLTn0mBy9kzo=; b=v7GFvMSwMYv+jhCDfpnjdi46MrBOVFiogOqx6pNS3LmL4n0DuB5b0tD3036yvFrbV5 haxGLykuV0048CWVmk5i+34WSjgHfvIxyKD9vzzDohgWUZETeRXSorYwvGo50VhDH+US lBtLfLShlUhG0wLzSGPjZvwpz/onNGnnvbzZqDn7yvoV1rtObUYlDq3Y7d06r6QCYHPS 0Ku/z9QQfYNGIfxlSPRfbJ4LPl0f9tOAaPkm0l/G+wmwCixiWFPQSUlJDiHoyniO8YAk iYFQc2TYyu67OPnxEJ0oQTzQeWdMeQtnJ7WQvLiQqMLJg91ymgAzZRoE6iBVf6ODA8H2 kaqA== X-Forwarded-Encrypted: i=1; AJvYcCXxlfoJLwy2fb5LzhECFfNKmYyLUeBEuoqGTVTGL1MmD3DzwvT5CvnDTD9ifYuBWLme5uqIhEU2ig==@vger.kernel.org X-Gm-Message-State: AOJu0YyeP4MCiQinKgWjZMuYat3oxIJhcGEIlFJk5IjzBi/hadBdmRNK sIn2O4W+ri4fPRBGz8yvwsIhYuyC4TwgJrH3GCR1KjGUgFtw2F4XrMOjFVUdW1+9s9U= X-Gm-Gg: ASbGncvyL5Rz3lsXME5o+ToiZATciiJF0SMHeHIz55HROVRYKp5+QFSXCG+xIOpIWHy 5H3ovgybROALS358+iJvLWBeAnQYL7MVyXTsuxQ5E3MZ9BllrT/rd1AWXhrDJPfvOmgpm8Q7Iuo fS7CTWD4UNbrbmZ8KZTVspyrJtn8tWjHaOPJS+whD13fMq+Adh4F0rilEKozEbCjcz5UO4mHcZW ppIOt5Affm1BjFxYRTVDbNrbe3NmuTFeIFbZP+5P/HvSfIkeIMlHCnP1bbXN0+34hp5fV5oalAO MSmZxiEZ+IKrxBzIefVEbO4sRXpwEfVDNj9MVI0JnXv9pnYf4lIb45BTVVj1 X-Google-Smtp-Source: AGHT+IH3xjpyQ4ebVaMo9DbY1gh/tZqYj3qhoffl3icr75QW+zCNKAPlpcq7GyNn9O1WQp4oMM2scw== X-Received: by 2002:a17:90b:2dd2:b0:312:f88d:25f9 with SMTP id 98e67ed59e1d1-313f1c7dacfmr29693399a91.7.1750276811912; Wed, 18 Jun 2025 13:00:11 -0700 (PDT) Received: from localhost ([97.126.182.119]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3157a605f21sm1629583a91.0.2025.06.18.13.00.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Jun 2025 13:00:11 -0700 (PDT) From: Kevin Hilman To: Dan Carpenter Cc: Ulf Hansson , Rob Herring , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-pm@vger.kernel.org, arm-scmi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RFC v3 2/2] pmdomain: core: add support for subdomains using power-domain-map In-Reply-To: References: <20250613-pmdomain-hierarchy-onecell-v3-0-5c770676fce7@baylibre.com> <20250613-pmdomain-hierarchy-onecell-v3-2-5c770676fce7@baylibre.com> <7hsejzp4xg.fsf@baylibre.com> <7hcyb1os9y.fsf@baylibre.com> Date: Wed, 18 Jun 2025 13:00:10 -0700 Message-ID: <7h5xgsq0qd.fsf@baylibre.com> Precedence: bulk X-Mailing-List: arm-scmi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Hi Dan, Dan Carpenter writes: > On Wed, Jun 18, 2025 at 10:48:09AM -0700, Kevin Hilman wrote: >> diff --git a/drivers/pmdomain/core.c b/drivers/pmdomain/core.c >> index 88819659df83..3ede4baa4bee 100644 >> --- a/drivers/pmdomain/core.c >> +++ b/drivers/pmdomain/core.c >> @@ -3220,6 +3220,40 @@ int of_genpd_parse_idle_states(struct device_node *dn, >> } >> EXPORT_SYMBOL_GPL(of_genpd_parse_idle_states); >> >> +int of_genpd_add_subdomain_map(struct device_node *np, >> + struct generic_pm_domain *domain, >> + int index) >> +{ >> + struct of_phandle_args parent_args; >> + struct generic_pm_domain *parent_pd; >> + struct device *dev = &domain->dev; >> + int ret; >> + >> + if (!domain) >> + return -ENODEV; >> + >> + /* >> + * Check for power-domain-map, which implies the primary >> + * power-doamin is a subdomain of the parent found in the map. >> + */ >> + ret = of_parse_phandle_with_args_map(np, NULL, "power-domain", >> + index, &parent_args); >> + if (!ret && parent_args.np) { > > Sorry for the pedanticry but could we flip this around? Sure. This is early prototype code for discsussing the big-picture approach, but I appreciate the review. I'll clean that up when I get past the RFC phase. Thanks! Kevin