From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Date: Thu, 30 Apr 2015 15:44:49 +0000 Subject: Re: [RFT PATCH] drm/exynos: Enable DP clock to fix display on Exynos5250 and other Message-Id: <7h8ud9pqmm.fsf@deeprootsystems.com> List-Id: References: <1427471856-20918-1-git-send-email-k.kozlowski@samsung.com> <7h8udau9he.fsf@deeprootsystems.com> In-Reply-To: (Krzysztof Kozlowski's message of "Thu, 30 Apr 2015 08:56:50 +0900") MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Krzysztof Kozlowski Cc: linux-fbdev@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Joonyoung Shim , David Airlie , Jingoo Han , Seung-Woo Kim , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Inki Dae , Andrzej Hajda , Kyungmin Park , Kukjin Kim , stable@vger.kernel.org, Olof Johansson , Javier Martinez Canillas , linux-arm-kernel@lists.infradead.org, Marek Szyprowski Krzysztof Kozlowski writes: > 2015-04-30 2:31 GMT+09:00 Kevin Hilman : >> Krzysztof Kozlowski writes: >> >>> After adding display power domain for Exynos5250 in commit >>> 2d2c9a8d0a4f ("ARM: dts: add display power domain for exynos5250") the >>> display on Chromebook Snow and others stopped working after boot. >>> >>> The reason for this suggested Andrzej Hajda: the DP clock was disabled. >>> This clock is required by Display Port and is enabled by bootloader. >>> However when FIMD driver probing was deferred, the display power domain >>> was turned off. This effectively reset the value of DP clock enable >>> register. >>> >>> When exynos-dp is later probed, the clock is not enabled and display is >>> not properly configured: >>> >>> exynos-dp 145b0000.dp-controller: Timeout of video streamclk ok >>> exynos-dp 145b0000.dp-controller: unable to config video >>> >>> Signed-off-by: Krzysztof Kozlowski >>> Reported-by: Javier Martinez Canillas >>> Fixes: 2d2c9a8d0a4f ("ARM: dts: add display power domain for exynos5250") >>> Cc: >>> >>> --- >>> >>> This should fix issue reported by Javier [1][2]. >>> >>> Tested on Chromebook Snow (Exynos 5250). More testing would be great, >>> especially on other Exynos 5xxx products. >> >> I hoped to try this on my exynos5 boards, but it doesn't seem to apply >> to linux-next or to Linus' master branch. >> >> Are there some other dependencies here? > > It is already applied: > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id363c7cccf64128087002b0779986ad16aff6dc Er, yup. That would explain it. ;) Sorry for the noise, Kevin From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [RFT PATCH] drm/exynos: Enable DP clock to fix display on Exynos5250 and other Date: Thu, 30 Apr 2015 08:44:49 -0700 Message-ID: <7h8ud9pqmm.fsf@deeprootsystems.com> References: <1427471856-20918-1-git-send-email-k.kozlowski@samsung.com> <7h8udau9he.fsf@deeprootsystems.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from mail-pa0-f45.google.com ([209.85.220.45]:36408 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751250AbbD3Pow (ORCPT ); Thu, 30 Apr 2015 11:44:52 -0400 Received: by pabsx10 with SMTP id sx10so63291218pab.3 for ; Thu, 30 Apr 2015 08:44:52 -0700 (PDT) In-Reply-To: (Krzysztof Kozlowski's message of "Thu, 30 Apr 2015 08:56:50 +0900") Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Krzysztof Kozlowski Cc: linux-fbdev@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Joonyoung Shim , David Airlie , Jingoo Han , Seung-Woo Kim , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Inki Dae , Andrzej Hajda , Kyungmin Park , Kukjin Kim , stable@vger.kernel.org, Olof Johansson , Javier Martinez Canillas , linux-arm-kernel@lists.infradead.org, Marek Szyprowski Krzysztof Kozlowski writes: > 2015-04-30 2:31 GMT+09:00 Kevin Hilman : >> Krzysztof Kozlowski writes: >> >>> After adding display power domain for Exynos5250 in commit >>> 2d2c9a8d0a4f ("ARM: dts: add display power domain for exynos5250") the >>> display on Chromebook Snow and others stopped working after boot. >>> >>> The reason for this suggested Andrzej Hajda: the DP clock was disabled. >>> This clock is required by Display Port and is enabled by bootloader. >>> However when FIMD driver probing was deferred, the display power domain >>> was turned off. This effectively reset the value of DP clock enable >>> register. >>> >>> When exynos-dp is later probed, the clock is not enabled and display is >>> not properly configured: >>> >>> exynos-dp 145b0000.dp-controller: Timeout of video streamclk ok >>> exynos-dp 145b0000.dp-controller: unable to config video >>> >>> Signed-off-by: Krzysztof Kozlowski >>> Reported-by: Javier Martinez Canillas >>> Fixes: 2d2c9a8d0a4f ("ARM: dts: add display power domain for exynos5250") >>> Cc: >>> >>> --- >>> >>> This should fix issue reported by Javier [1][2]. >>> >>> Tested on Chromebook Snow (Exynos 5250). More testing would be great, >>> especially on other Exynos 5xxx products. >> >> I hoped to try this on my exynos5 boards, but it doesn't seem to apply >> to linux-next or to Linus' master branch. >> >> Are there some other dependencies here? > > It is already applied: > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=1c363c7cccf64128087002b0779986ad16aff6dc Er, yup. That would explain it. ;) Sorry for the noise, Kevin From mboxrd@z Thu Jan 1 00:00:00 1970 From: khilman@kernel.org (Kevin Hilman) Date: Thu, 30 Apr 2015 08:44:49 -0700 Subject: [RFT PATCH] drm/exynos: Enable DP clock to fix display on Exynos5250 and other In-Reply-To: (Krzysztof Kozlowski's message of "Thu, 30 Apr 2015 08:56:50 +0900") References: <1427471856-20918-1-git-send-email-k.kozlowski@samsung.com> <7h8udau9he.fsf@deeprootsystems.com> Message-ID: <7h8ud9pqmm.fsf@deeprootsystems.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Krzysztof Kozlowski writes: > 2015-04-30 2:31 GMT+09:00 Kevin Hilman : >> Krzysztof Kozlowski writes: >> >>> After adding display power domain for Exynos5250 in commit >>> 2d2c9a8d0a4f ("ARM: dts: add display power domain for exynos5250") the >>> display on Chromebook Snow and others stopped working after boot. >>> >>> The reason for this suggested Andrzej Hajda: the DP clock was disabled. >>> This clock is required by Display Port and is enabled by bootloader. >>> However when FIMD driver probing was deferred, the display power domain >>> was turned off. This effectively reset the value of DP clock enable >>> register. >>> >>> When exynos-dp is later probed, the clock is not enabled and display is >>> not properly configured: >>> >>> exynos-dp 145b0000.dp-controller: Timeout of video streamclk ok >>> exynos-dp 145b0000.dp-controller: unable to config video >>> >>> Signed-off-by: Krzysztof Kozlowski >>> Reported-by: Javier Martinez Canillas >>> Fixes: 2d2c9a8d0a4f ("ARM: dts: add display power domain for exynos5250") >>> Cc: >>> >>> --- >>> >>> This should fix issue reported by Javier [1][2]. >>> >>> Tested on Chromebook Snow (Exynos 5250). More testing would be great, >>> especially on other Exynos 5xxx products. >> >> I hoped to try this on my exynos5 boards, but it doesn't seem to apply >> to linux-next or to Linus' master branch. >> >> Are there some other dependencies here? > > It is already applied: > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=1c363c7cccf64128087002b0779986ad16aff6dc Er, yup. That would explain it. ;) Sorry for the noise, Kevin