From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH v3 1/8] msm: scm: Move scm-boot files to drivers/soc and include/soc Date: Wed, 27 Aug 2014 13:24:44 -0700 Message-ID: <7h8um9brzn.fsf@paris.lan> References: <1408400614-45419-1-git-send-email-lina.iyer@linaro.org> <1408400614-45419-2-git-send-email-lina.iyer@linaro.org> <7h38chg8bj.fsf@paris.lan> <20140827185732.GD74960@ilina-mac.local> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from mail-pa0-f53.google.com ([209.85.220.53]:41264 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964938AbaH0UYv (ORCPT ); Wed, 27 Aug 2014 16:24:51 -0400 Received: by mail-pa0-f53.google.com with SMTP id rd3so1178876pab.26 for ; Wed, 27 Aug 2014 13:24:47 -0700 (PDT) In-Reply-To: <20140827185732.GD74960@ilina-mac.local> (Lina Iyer's message of "Wed, 27 Aug 2014 12:57:32 -0600") Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Lina Iyer Cc: daniel.lezcano@linaro.org, sboyd@codeaurora.org, davidb@codeaurora.org, galak@codeaurora.org, linux-arm-msm@vger.kernel.org, lorenzo.pieralisi@arm.com, msivasub@codeauorora.org Lina Iyer writes: > On Wed, Aug 27, 2014 at 10:18:24AM -0700, Kevin Hilman wrote: >>Lina Iyer writes: >> >>> Signed-off-by: Lina Iyer >> >>Why the move? It looks like scm-boot.c still calls into the main >>scm_call() stuff that still lives under arch/arm/mach-qcom, and not in >>arm64, so I'm not seeing the motiviation for the change (and the >>changelog didn't help explain either :) >> >>Kevin > > I dint intend on moving the scm-boot for 64 bit purposes, but that > would be a good argument :) My motivation was to move the scm-boot.h, but > figured might as well clean up the mach-qcom in the process, per > guidance. Thanks for clarifying. I suspect that should be a separate cleanup series with its own descriptive changelog, because to me it only looks like a partial cleanup since only some of the stuff was moved out, and it's not abvious what it will be sharing that code. Kevin