From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 329F0C4332F for ; Fri, 18 Nov 2022 19:57:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=V9pF5mpVc3B6b5fPqNSwwVAKIqb3BcTax6YAV4Xry14=; b=q6pS08WtY7EwIOYMUtX9GIR3F8 TQ+mNxTK3NxsqZ/70EJSp+ldSMc45nobbiOqjnP3bEiWo2FlVz3G4jiWkSadBOBjrK0yE5ou9+XMM BzsrdYuRAbKTIpO5l8hy0GA8DVmfiM971dM09vrMCI8yNx5TT8LG1KLlVDEnsbq5INdiexk8N9Bys 4C5F8FqEnetupnL2mIyGO/A7bFgOY30Suo7XTdlx2lGnhsxkzBaY7ZAbuArMhpdyi441E8c9KBw09 50dWrqX2AoWIZQN+W0gwoMwhCeCx7AihWb6rTHO9LbDhwD2DT2OrCxuoJlw9VZtKwHpnPQjO8fsKz MidvM2Fg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ow7U9-007maH-18; Fri, 18 Nov 2022 19:57:13 +0000 Received: from mail-pj1-x102b.google.com ([2607:f8b0:4864:20::102b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ow7Pe-007k1h-43 for linux-mediatek@lists.infradead.org; Fri, 18 Nov 2022 19:52:37 +0000 Received: by mail-pj1-x102b.google.com with SMTP id h14so5387329pjv.4 for ; Fri, 18 Nov 2022 11:52:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=V9pF5mpVc3B6b5fPqNSwwVAKIqb3BcTax6YAV4Xry14=; b=qNg0CIGaljUFzhEfI4vH3ilp1WNLxwEYLuLTg2/nDaXyF8RtJ5J3fgSt4pPrMuPHR/ 3fX9ZMJkyKJ1L7i9ZYga96hfG9qF/5dKmouAS75cDgAltrEShqqjpKRVJBjeWrGs84s8 zb2FOwrJSVJdoIW3D6bJ254XqCIvEAc84niDnr+CWTj59FHI1er80f1dLbL+G2DnlM01 dWAtjzn1xEu0sLWlhAdPV677CD6o87LRCx83oGwqmm0HmYSjMRKkbki5Q/xWGpUob1r2 tm7wTT5W2DjIlJv37BC3hQ22uIsDDggSkg9opQG56JJeDw+vQFmGP6MRbPfDpWt9X/ZL 23WA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=V9pF5mpVc3B6b5fPqNSwwVAKIqb3BcTax6YAV4Xry14=; b=KoxjCvzozeU/Nj3netD3fJCLtp6AdhP0aZyajK9QmiRhyJ9FVOATU6f9mI6kZ/ooQ3 2OAvcloIWEOJB4JphD99vpzU/bwi610Clpc/8SDYym1HtVD79PjGiMKMJlTG4FiT8TQk PF/DbfJEPWi7uGvLLHvq/UCDPdkhjmMPNaWCt3GINoXyS4lqR4eOaeCwikNKAnLROdea PBjzJPQviHGqidWxI+dDO1NPjoZ8oKzS0gCx1uARIeOqosagCK5EC4KkpJCm7zRNsqi6 kGEUlS+Awyn/r3AHSYbXp0bNmXNL+1OtI1Q63OX/jMXS2Qsh2cmGdAZPzt4sgdvj5yA1 fXiQ== X-Gm-Message-State: ANoB5pkGR5nCht8MLHHdTJkS6XbTp4NYI9BxZvVVrCphIshvN3gj9UAj NINrAxCnGPYYgg/bV+ZjgOBETQ== X-Google-Smtp-Source: AA0mqf7FWoYKybRn5fseRjhUf3xjBQFYjHdmdctR3NDS0M1rjX+qWJeY5s1nwX21Y9ulybgSC9iwJw== X-Received: by 2002:a17:902:ebc1:b0:176:a6c5:20c9 with SMTP id p1-20020a170902ebc100b00176a6c520c9mr1028458plg.57.1668801151469; Fri, 18 Nov 2022 11:52:31 -0800 (PST) Received: from localhost ([75.172.139.56]) by smtp.gmail.com with ESMTPSA id w10-20020a63160a000000b00473c36ea150sm3106891pgl.92.2022.11.18.11.52.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Nov 2022 11:52:30 -0800 (PST) From: Kevin Hilman To: Krzysztof Kozlowski , Bernhard =?utf-8?Q?Rosenkr=C3=A4nzer?= , linux-mediatek@lists.infradead.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com, angelogiocchino.delregno@collabora.com Subject: Re: [PATCH v3 4/7] dt-bindings: pinctrl: add bindings for Mediatek MT8365 SoC In-Reply-To: <06e916b7-f8f2-6de5-f86e-7b020c052451@linaro.org> References: <20221117210356.3178578-1-bero@baylibre.com> <20221117210356.3178578-5-bero@baylibre.com> <06e916b7-f8f2-6de5-f86e-7b020c052451@linaro.org> Date: Fri, 18 Nov 2022 11:52:30 -0800 Message-ID: <7ha64o9h1d.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221118_115234_400399_4767E5CB X-CRM114-Status: GOOD ( 15.05 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi Krzysztof, Krzysztof Kozlowski writes: > On 17/11/2022 22:03, Bernhard Rosenkr=C3=A4nzer wrote: >> Add devicetree bindings for Mediatek MT8365 pinctrl driver. >>=20 >> Signed-off-by: Bernhard Rosenkr=C3=A4nzer > > Thank you for your patch. There is something to discuss/improve. > >> + >> + pins-are-numbered: >> + $ref: /schemas/types.yaml#/definitions/flag >> + description: | >> + Specify the subnodes are using numbered pinmux to specify pins. > > Why would you name pins differently per board? And why this different > naming of the same pins is a property of hardware? > > This looks like something to drop. Yeah, having this as a flag kind of implies that this could be present for some boards but not others. But in practice, the driver requires it to be present or just fails[1]. What's the right way to describe that? We're just trying to add a binding that reflects the existing driver. We also noticed that there's another documented binding with this same flag[2] where similiarily, the driver simply requires it to be present[2]. So is the way this flag is documented in the stm32 binding OK for the mediatek one also? If not, what would you suggest? Thanks for the review, Kevin [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree= /drivers/pinctrl/mediatek/pinctrl-mtk-common.c#n1053 [2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree= /Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml#n37 [3] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree= /drivers/pinctrl/stm32/pinctrl-stm32.c#n1499 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 50589C4332F for ; Fri, 18 Nov 2022 19:57:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1I2wmjRtRywnse9+QVFjfYJQM6ZeqFmA3ueaRaoOCyU=; b=PFykYq7jJ9uBUx 9v7gdYp9RAxQNoMNc5wdDKMpxmf/nBiPYVyDh3SJGmF42FjpKUuMCVwJn2fg+IPef/AAsu+NmOLeE zWy9NtaEIvONQLg6wA3JGakP+CBnOPsrHQLnr5HaRT40fSJq0xEY0P1YPXQTzNDbwZiryNR5UThxq 0Mu4uJWAYdFMsZY9WBtKpHp+fpe0Sw/G5ODDoN+5f4i2NhDNsqcioPzHxgXmQWuDIZcigit/7DAiu QP61hj/0A7Dto5AMTs7gGSMv4K7oV69hlyXdCZ07NnJ7jLN4eXodmRHNFOcpH5G7v2qmRrHIVDEPz t42HinPAMH4e0vIVgGxw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ow7TG-007m2K-Rm; Fri, 18 Nov 2022 19:56:19 +0000 Received: from mail-pj1-x1031.google.com ([2607:f8b0:4864:20::1031]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ow7Pe-007k1i-4P for linux-arm-kernel@lists.infradead.org; Fri, 18 Nov 2022 19:52:37 +0000 Received: by mail-pj1-x1031.google.com with SMTP id w4-20020a17090ac98400b002186f5d7a4cso5694231pjt.0 for ; Fri, 18 Nov 2022 11:52:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=V9pF5mpVc3B6b5fPqNSwwVAKIqb3BcTax6YAV4Xry14=; b=qNg0CIGaljUFzhEfI4vH3ilp1WNLxwEYLuLTg2/nDaXyF8RtJ5J3fgSt4pPrMuPHR/ 3fX9ZMJkyKJ1L7i9ZYga96hfG9qF/5dKmouAS75cDgAltrEShqqjpKRVJBjeWrGs84s8 zb2FOwrJSVJdoIW3D6bJ254XqCIvEAc84niDnr+CWTj59FHI1er80f1dLbL+G2DnlM01 dWAtjzn1xEu0sLWlhAdPV677CD6o87LRCx83oGwqmm0HmYSjMRKkbki5Q/xWGpUob1r2 tm7wTT5W2DjIlJv37BC3hQ22uIsDDggSkg9opQG56JJeDw+vQFmGP6MRbPfDpWt9X/ZL 23WA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=V9pF5mpVc3B6b5fPqNSwwVAKIqb3BcTax6YAV4Xry14=; b=KGmHjN3mYtq/kvb9n+dUjSHw9ytzA7hPsixw4E8y/VGMOdYI6BC7RRAIAzPlF1dfHF rKmJBXCc5IFFGtlRHhjv/wWhdNgyOpxMKcnLQnIhEM1dgSxEMCE/ckz6Ddh+mU9eW1sF DGlNwTnUCYVay86sP8oYytcCwD9z8t4QfBRbn1yIe4+m1kyLeDr+M0baCyPltmGNkotS Bwvbv3tjeBxF9DOWoBC6/xHYcX7IrCa5dav5Z8Emrs6gQkS34XA454BaKur65pNYr4rx 1Zc0C0pEQjCsRAS7+Dpd8uMxvIx2pOb08DAWjYpbLVWEH802z/hxNLedXyGRz/8DmGmB cOjg== X-Gm-Message-State: ANoB5pmFxt6e8KTqnFHzvj0esMhHDUfLhwaGVu/WW5iIFwzC+d0udYKY c/8H4ehHY/MZH/oFp5R2smCcCg== X-Google-Smtp-Source: AA0mqf7FWoYKybRn5fseRjhUf3xjBQFYjHdmdctR3NDS0M1rjX+qWJeY5s1nwX21Y9ulybgSC9iwJw== X-Received: by 2002:a17:902:ebc1:b0:176:a6c5:20c9 with SMTP id p1-20020a170902ebc100b00176a6c520c9mr1028458plg.57.1668801151469; Fri, 18 Nov 2022 11:52:31 -0800 (PST) Received: from localhost ([75.172.139.56]) by smtp.gmail.com with ESMTPSA id w10-20020a63160a000000b00473c36ea150sm3106891pgl.92.2022.11.18.11.52.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Nov 2022 11:52:30 -0800 (PST) From: Kevin Hilman To: Krzysztof Kozlowski , Bernhard =?utf-8?Q?Rosenkr=C3=A4nzer?= , linux-mediatek@lists.infradead.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com, angelogiocchino.delregno@collabora.com Subject: Re: [PATCH v3 4/7] dt-bindings: pinctrl: add bindings for Mediatek MT8365 SoC In-Reply-To: <06e916b7-f8f2-6de5-f86e-7b020c052451@linaro.org> References: <20221117210356.3178578-1-bero@baylibre.com> <20221117210356.3178578-5-bero@baylibre.com> <06e916b7-f8f2-6de5-f86e-7b020c052451@linaro.org> Date: Fri, 18 Nov 2022 11:52:30 -0800 Message-ID: <7ha64o9h1d.fsf@baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221118_115234_396051_47315027 X-CRM114-Status: GOOD ( 16.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgS3J6eXN6dG9mLAoKS3J6eXN6dG9mIEtvemxvd3NraSA8a3J6eXN6dG9mLmtvemxvd3NraUBs aW5hcm8ub3JnPiB3cml0ZXM6Cgo+IE9uIDE3LzExLzIwMjIgMjI6MDMsIEJlcm5oYXJkIFJvc2Vu a3LDpG56ZXIgd3JvdGU6Cj4+IEFkZCBkZXZpY2V0cmVlIGJpbmRpbmdzIGZvciBNZWRpYXRlayBN VDgzNjUgcGluY3RybCBkcml2ZXIuCj4+IAo+PiBTaWduZWQtb2ZmLWJ5OiBCZXJuaGFyZCBSb3Nl bmtyw6RuemVyIDxiZXJvQGJheWxpYnJlLmNvbT4KPgo+IFRoYW5rIHlvdSBmb3IgeW91ciBwYXRj aC4gVGhlcmUgaXMgc29tZXRoaW5nIHRvIGRpc2N1c3MvaW1wcm92ZS4KPgo+PiArCj4+ICsgIHBp bnMtYXJlLW51bWJlcmVkOgo+PiArICAgICRyZWY6IC9zY2hlbWFzL3R5cGVzLnlhbWwjL2RlZmlu aXRpb25zL2ZsYWcKPj4gKyAgICBkZXNjcmlwdGlvbjogfAo+PiArICAgICAgU3BlY2lmeSB0aGUg c3Vibm9kZXMgYXJlIHVzaW5nIG51bWJlcmVkIHBpbm11eCB0byBzcGVjaWZ5IHBpbnMuCj4KPiBX aHkgd291bGQgeW91IG5hbWUgcGlucyBkaWZmZXJlbnRseSBwZXIgYm9hcmQ/IEFuZCB3aHkgdGhp cyBkaWZmZXJlbnQKPiBuYW1pbmcgb2YgdGhlIHNhbWUgcGlucyBpcyBhIHByb3BlcnR5IG9mIGhh cmR3YXJlPwo+Cj4gVGhpcyBsb29rcyBsaWtlIHNvbWV0aGluZyB0byBkcm9wLgoKWWVhaCwgaGF2 aW5nIHRoaXMgYXMgYSBmbGFnIGtpbmQgb2YgaW1wbGllcyB0aGF0IHRoaXMgY291bGQgYmUgcHJl c2VudApmb3Igc29tZSBib2FyZHMgYnV0IG5vdCBvdGhlcnMuICBCdXQgaW4gcHJhY3RpY2UsIHRo ZSBkcml2ZXIgcmVxdWlyZXMgaXQKdG8gYmUgcHJlc2VudCBvciBqdXN0IGZhaWxzWzFdLiAgV2hh dCdzIHRoZSByaWdodCB3YXkgdG8gZGVzY3JpYmUgdGhhdD8KV2UncmUganVzdCB0cnlpbmcgdG8g YWRkIGEgYmluZGluZyB0aGF0IHJlZmxlY3RzIHRoZSBleGlzdGluZyBkcml2ZXIuCgpXZSBhbHNv IG5vdGljZWQgdGhhdCB0aGVyZSdzIGFub3RoZXIgZG9jdW1lbnRlZCBiaW5kaW5nIHdpdGggdGhp cwpzYW1lIGZsYWdbMl0gd2hlcmUgc2ltaWxpYXJpbHksIHRoZSBkcml2ZXIgc2ltcGx5IHJlcXVp cmVzIGl0IHRvIGJlCnByZXNlbnRbMl0uCgpTbyBpcyB0aGUgd2F5IHRoaXMgZmxhZyBpcyBkb2N1 bWVudGVkIGluIHRoZSBzdG0zMiBiaW5kaW5nIE9LIGZvciB0aGUKbWVkaWF0ZWsgb25lIGFsc28/ ICBJZiBub3QsIHdoYXQgd291bGQgeW91IHN1Z2dlc3Q/CgpUaGFua3MgZm9yIHRoZSByZXZpZXcs CgpLZXZpbgoKWzFdIGh0dHBzOi8vZ2l0Lmtlcm5lbC5vcmcvcHViL3NjbS9saW51eC9rZXJuZWwv Z2l0L3RvcnZhbGRzL2xpbnV4LmdpdC90cmVlL2RyaXZlcnMvcGluY3RybC9tZWRpYXRlay9waW5j dHJsLW10ay1jb21tb24uYyNuMTA1MwpbMl0gaHR0cHM6Ly9naXQua2VybmVsLm9yZy9wdWIvc2Nt L2xpbnV4L2tlcm5lbC9naXQvdG9ydmFsZHMvbGludXguZ2l0L3RyZWUvRG9jdW1lbnRhdGlvbi9k ZXZpY2V0cmVlL2JpbmRpbmdzL3BpbmN0cmwvc3Qsc3RtMzItcGluY3RybC55YW1sI24zNwpbM10g aHR0cHM6Ly9naXQua2VybmVsLm9yZy9wdWIvc2NtL2xpbnV4L2tlcm5lbC9naXQvdG9ydmFsZHMv bGludXguZ2l0L3RyZWUvZHJpdmVycy9waW5jdHJsL3N0bTMyL3BpbmN0cmwtc3RtMzIuYyNuMTQ5 OQoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4 LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFk Lm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFy bS1rZXJuZWwK