From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 822EBC433FE for ; Thu, 29 Sep 2022 23:31:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229530AbiI2Xb2 (ORCPT ); Thu, 29 Sep 2022 19:31:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38762 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229498AbiI2Xb1 (ORCPT ); Thu, 29 Sep 2022 19:31:27 -0400 Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F900148A3B for ; Thu, 29 Sep 2022 16:31:25 -0700 (PDT) Received: by mail-pl1-x634.google.com with SMTP id y20so2544570plb.2 for ; Thu, 29 Sep 2022 16:31:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date; bh=cm9FnswtIkP/gY/RUuimKLHOr9IqMWAMCWJdeBuqp+c=; b=IQFje1I7eSHPqIDPeqc9C0cqQn3GH3jHDzDbiJ3x8N3r6xQUWpcDDiPhNJ1uEETcbj cejxhv4UF0uLiyFfjVey9wb+m9pO3oD3q6KDpZV7fo96rIRhBDVXCrIzTzmgR/hvcCnr JIpoNeWAOtd1Ev/kIfQcOOwVYr5mDyqsirD8D3d7DQwnFW6w1AX0mSzPwVk3KS1Rf2dJ 2o0Fp3/Yo/EFohV8TY+TeneytUkUwTzIwe3WU9X5lJ18wt3XmdfT1Tc77GFPOy39Na2x kp27Sx9CL7a55e8xsrQJgEmZUhr0ZMZ19RYEo8xkB0C6Zsoz5tUkO0WdCKmHB4W1TIS3 fQJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date; bh=cm9FnswtIkP/gY/RUuimKLHOr9IqMWAMCWJdeBuqp+c=; b=GmO3T7qMVqjTrc1b9Bv89p9yPJPv0CxbV+wWS5OaTP+bkwltlPSIjcc5WzLqp0jR+u REp6IFXOdbcL4It9NLhmWUCg3GjrUG8yAfISK4pksBhS1KW7nDZBgVw7/UF2gbabhAY8 TFTgRZK6QtaVbcluFyHFBfhQuiMF6LIxpXAUnA2vUkOugnOEnvbkA2jPxeqk+k9WvLiZ Xdone7mN/apt1PSps2xQm73gVSUgNGQzbhfYad3bEksSr1fPEHy3GUkLb5Nj/Otf2YUM JLHFtqk0JcCyK6AnpEhPE5Wg5iMvux+8JAI3TxOU6JBCe9pCg+rcBc3s2tOinyHQPMzB B8TQ== X-Gm-Message-State: ACrzQf3liurS/AkYMBCyTyHpoYdPtdbjJGbr3guU/rZF6/cTp3rAmrzN ym+mnbEdKw2ERPP9QndsUhtubIaePbJfyw== X-Google-Smtp-Source: AMsMyM7sfZ0jK2tNFimwhQToHSMR4vkBmj69vOVvgH2kqO9hTshI7l/wUpl3iTurV3igRKOQZ8v9qg== X-Received: by 2002:a17:90b:1d87:b0:200:b6e1:7e9f with SMTP id pf7-20020a17090b1d8700b00200b6e17e9fmr6331972pjb.235.1664494284983; Thu, 29 Sep 2022 16:31:24 -0700 (PDT) Received: from localhost ([75.172.140.17]) by smtp.gmail.com with ESMTPSA id q4-20020a17090311c400b001750361f430sm440956plh.155.2022.09.29.16.31.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Sep 2022 16:31:24 -0700 (PDT) From: Kevin Hilman To: Vinod Koul Cc: Peter Ujfalusi , dmaengine@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Nicolas Frayer Subject: Re: [PATCH v2 2/3] dma/ti: convert k3-udma to module In-Reply-To: References: <20220927230804.4085579-1-khilman@baylibre.com> <20220927230804.4085579-3-khilman@baylibre.com> Date: Thu, 29 Sep 2022 16:31:23 -0700 Message-ID: <7hbkqxwyes.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org Hi Vinod, Vinod Koul writes: > On 27-09-22, 16:08, Kevin Hilman wrote: >> Currently k3-udma driver is built as separate platform drivers with a >> shared probe and identical code path, just differnet platform data. >> >> To enable to build as module, convert the separate platform driver >> into a single module_platform_driver with the data selection done via >> compatible string and of_match. The separate of_match tables are also >> combined into a single table to avoid the multiple calls to >> of_match_node() >> >> Since all modern TI platforms using this are DT enabled, the removal >> of separate platform_drivers shoul should nave no functional change. > > drop extra shoul > > Please change subsystem tag to dmaengine: ti: xxxx for this and next > patch OK. >> >> Signed-off-by: Kevin Hilman >> Acked-by: Peter Ujfalusi > > this has trailing whitespaces, maybe copy paste error Yup. Thanks for the review. Will respin. Kevin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 747FBC433FE for ; Thu, 29 Sep 2022 23:36:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JuYssQ6F7oFk+9+nDickHoaZTFaFGKg4Ao21rQ1/Deo=; b=K2lN2G/PkLniez 94jIqQJGVsnmo8Zd68FOkBwPJtvkP/V14fVFg+YVsmChFIwMWla9m/m2yGuMF014PHbg+HFmzwxwg CP6s5NRt0ESbDYkBCjfZ0gF7CbJbEYHkUgVEujNnOWRtffe2MNqOUdW0C9OtGBcHADp0SgjWrWMRl 2Z1EVzCOe74nFVU38OjvwAe15XiX99Dzli0vSHJRquYtWdNHsTniUjLpaG9iZ8ZEQ6l02dTpwV553 uPrlMPS6kLFMd1xtplWFoZhL7KtnmvC4Z1O+ojz+IJa0KJxynAKfxO1h1GOYkdaLB01S5b0QsgD8R ifwuakZBlKLFhkcKPtQQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oe33H-005zvk-P4; Thu, 29 Sep 2022 23:34:48 +0000 Received: from mail-pj1-x1031.google.com ([2607:f8b0:4864:20::1031]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oe304-005yAT-4A for linux-arm-kernel@lists.infradead.org; Thu, 29 Sep 2022 23:31:31 +0000 Received: by mail-pj1-x1031.google.com with SMTP id c6-20020a17090a4d0600b0020958fcd9acso1472150pjg.4 for ; Thu, 29 Sep 2022 16:31:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date; bh=cm9FnswtIkP/gY/RUuimKLHOr9IqMWAMCWJdeBuqp+c=; b=IQFje1I7eSHPqIDPeqc9C0cqQn3GH3jHDzDbiJ3x8N3r6xQUWpcDDiPhNJ1uEETcbj cejxhv4UF0uLiyFfjVey9wb+m9pO3oD3q6KDpZV7fo96rIRhBDVXCrIzTzmgR/hvcCnr JIpoNeWAOtd1Ev/kIfQcOOwVYr5mDyqsirD8D3d7DQwnFW6w1AX0mSzPwVk3KS1Rf2dJ 2o0Fp3/Yo/EFohV8TY+TeneytUkUwTzIwe3WU9X5lJ18wt3XmdfT1Tc77GFPOy39Na2x kp27Sx9CL7a55e8xsrQJgEmZUhr0ZMZ19RYEo8xkB0C6Zsoz5tUkO0WdCKmHB4W1TIS3 fQJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date; bh=cm9FnswtIkP/gY/RUuimKLHOr9IqMWAMCWJdeBuqp+c=; b=VULhbZn3MyOmiwj9Wpy9f3b3B5zAuff+ulngukD4toFcy0MPvjFs6Ek+vpAzdX6bW+ 6LdUzFuhi0X8n5BCyHxmAnbhtDpU0TBC3uIaDunAuNaHhBYuY0wXDcBCIhdfJMI87Bd3 t0WR/AYEqf+ZWygaYYS1ljQv8yWkqgdUKCW6Djo24IsdOF0lszXpBUu3XpgfVj6rtpLo psBqP2UxmL7nsmpbLVI9xBMTsqZpF0b0sB/t6ZZ37tlv4mkak45aJGLnu+aJwe6t9h3D DJZjmExlc39RUcF2Eb9kv0HLFiNP/f3K/Pq4IeSCTogq0yaPVUmk/Jz+svxC2+JIkpCS fgPw== X-Gm-Message-State: ACrzQf05G+0hHjUtlXWp83zttgUdjbgwxe0F2rUOkuQiGMtKh8snDfq+ tk0g1sdIsFD20ZFJBxUWIjpluw== X-Google-Smtp-Source: AMsMyM7sfZ0jK2tNFimwhQToHSMR4vkBmj69vOVvgH2kqO9hTshI7l/wUpl3iTurV3igRKOQZ8v9qg== X-Received: by 2002:a17:90b:1d87:b0:200:b6e1:7e9f with SMTP id pf7-20020a17090b1d8700b00200b6e17e9fmr6331972pjb.235.1664494284983; Thu, 29 Sep 2022 16:31:24 -0700 (PDT) Received: from localhost ([75.172.140.17]) by smtp.gmail.com with ESMTPSA id q4-20020a17090311c400b001750361f430sm440956plh.155.2022.09.29.16.31.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Sep 2022 16:31:24 -0700 (PDT) From: Kevin Hilman To: Vinod Koul Cc: Peter Ujfalusi , dmaengine@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Nicolas Frayer Subject: Re: [PATCH v2 2/3] dma/ti: convert k3-udma to module In-Reply-To: References: <20220927230804.4085579-1-khilman@baylibre.com> <20220927230804.4085579-3-khilman@baylibre.com> Date: Thu, 29 Sep 2022 16:31:23 -0700 Message-ID: <7hbkqxwyes.fsf@baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220929_163128_389885_9118BC92 X-CRM114-Status: GOOD ( 11.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Vinod, Vinod Koul writes: > On 27-09-22, 16:08, Kevin Hilman wrote: >> Currently k3-udma driver is built as separate platform drivers with a >> shared probe and identical code path, just differnet platform data. >> >> To enable to build as module, convert the separate platform driver >> into a single module_platform_driver with the data selection done via >> compatible string and of_match. The separate of_match tables are also >> combined into a single table to avoid the multiple calls to >> of_match_node() >> >> Since all modern TI platforms using this are DT enabled, the removal >> of separate platform_drivers shoul should nave no functional change. > > drop extra shoul > > Please change subsystem tag to dmaengine: ti: xxxx for this and next > patch OK. >> >> Signed-off-by: Kevin Hilman >> Acked-by: Peter Ujfalusi > > this has trailing whitespaces, maybe copy paste error Yup. Thanks for the review. Will respin. Kevin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel