From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH] ARM: multi_v7_defconfig: fix failure setting CPU voltage by enabling dependent I2C controller Date: Wed, 19 Nov 2014 09:40:07 -0800 Message-ID: <7hbno3w0lk.fsf@deeprootsystems.com> References: <1416337853-1558-1-git-send-email-tyler.baker@linaro.org> <546C4BA1.6090701@samsung.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from mail-pa0-f52.google.com ([209.85.220.52]:61057 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753829AbaKSRkL (ORCPT ); Wed, 19 Nov 2014 12:40:11 -0500 Received: by mail-pa0-f52.google.com with SMTP id eu11so662176pac.39 for ; Wed, 19 Nov 2014 09:40:10 -0800 (PST) In-Reply-To: <546C4BA1.6090701@samsung.com> (Kukjin Kim's message of "Wed, 19 Nov 2014 16:49:53 +0900") Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Kukjin Kim Cc: Tyler Baker , linux-arm-kernel@lists.infradead.org, arm@kernel.org, linux-samsung-soc@vger.kernel.org, Arnd Bergmann , 'Olof Johansson' Kukjin Kim writes: > On 11/19/14 04:10, Tyler Baker wrote: > > Hi, > > + Arnd, Olof and Kevin > >> This patch fixes a long standing issue introduced during the 3.16 merge window. >> Shortly after the merge, exynos5250-based arndale boards began to produce the >> following errors: >> >> kern.err kernel: exynos-cpufreq exynos-cpufreq: failed to set cpu voltage >> kern.err kernel: cpufreq: __target_index: Failed to change cpu frequency: -22 >> >> Further analysis revealed that the S5M8767 voltage regulator used on the >> exynos5250-based arndale board utilizes the S3C2410 I2C controller. If the >> S3C2410 I2C controller driver is not enabled, the S5M8767 voltage regulator >> fails to probe. Therefore a dependency exists between these two drivers. >> In the exynos_defconfig both CONFIG_REGULATOR_S5M8767 and CONFIG_I2C_S3C2410 >> options are enabled, and no errors are produced. However, in the >> multi_v7_defconfig only the CONFIG_REGULATOR_S5M8767 option is enabled and the >> errors are present. So let's enable the CONFIG_I2C_S3C2410 option in the >> multi_v7_defconfig to allow the S5M8767 voltage regulator to probe. >> >> Signed-off-by: Tyler Baker > > Acked-by: Kukjin Kim Applied to arm-soc/fixes, which is merged into arm-soc/for-next. Thanks, Kevin From mboxrd@z Thu Jan 1 00:00:00 1970 From: khilman@kernel.org (Kevin Hilman) Date: Wed, 19 Nov 2014 09:40:07 -0800 Subject: [PATCH] ARM: multi_v7_defconfig: fix failure setting CPU voltage by enabling dependent I2C controller In-Reply-To: <546C4BA1.6090701@samsung.com> (Kukjin Kim's message of "Wed, 19 Nov 2014 16:49:53 +0900") References: <1416337853-1558-1-git-send-email-tyler.baker@linaro.org> <546C4BA1.6090701@samsung.com> Message-ID: <7hbno3w0lk.fsf@deeprootsystems.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Kukjin Kim writes: > On 11/19/14 04:10, Tyler Baker wrote: > > Hi, > > + Arnd, Olof and Kevin > >> This patch fixes a long standing issue introduced during the 3.16 merge window. >> Shortly after the merge, exynos5250-based arndale boards began to produce the >> following errors: >> >> kern.err kernel: exynos-cpufreq exynos-cpufreq: failed to set cpu voltage >> kern.err kernel: cpufreq: __target_index: Failed to change cpu frequency: -22 >> >> Further analysis revealed that the S5M8767 voltage regulator used on the >> exynos5250-based arndale board utilizes the S3C2410 I2C controller. If the >> S3C2410 I2C controller driver is not enabled, the S5M8767 voltage regulator >> fails to probe. Therefore a dependency exists between these two drivers. >> In the exynos_defconfig both CONFIG_REGULATOR_S5M8767 and CONFIG_I2C_S3C2410 >> options are enabled, and no errors are produced. However, in the >> multi_v7_defconfig only the CONFIG_REGULATOR_S5M8767 option is enabled and the >> errors are present. So let's enable the CONFIG_I2C_S3C2410 option in the >> multi_v7_defconfig to allow the S5M8767 voltage regulator to probe. >> >> Signed-off-by: Tyler Baker > > Acked-by: Kukjin Kim Applied to arm-soc/fixes, which is merged into arm-soc/for-next. Thanks, Kevin