From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH v2] soc: qcom: do not disable the iface clock in probe Date: Wed, 24 Sep 2014 08:22:58 -0700 Message-ID: <7hbnq5m4a5.fsf@deeprootsystems.com> References: <1411500054-13600-1-git-send-email-srinivas.kandagatla@linaro.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from mail.kernel.org ([198.145.19.201]:44644 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751958AbaIXPXC (ORCPT ); Wed, 24 Sep 2014 11:23:02 -0400 In-Reply-To: <1411500054-13600-1-git-send-email-srinivas.kandagatla@linaro.org> (Srinivas Kandagatla's message of "Tue, 23 Sep 2014 20:20:54 +0100") Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Srinivas Kandagatla Cc: arm@kernel.org, agross@codeaurora.org, galak@codeaurora.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Srinivas Kandagatla writes: > since commit 31964ffebbb9 ("tty: serial: msm: Remove direct access to GSBI")' > serial hangs if earlyprintk are enabled. > > This hang is noticed only when the GSBI driver is probed and all the > earlyprintks before gsbi probe are seen on the console. > The reason why it hangs is because GSBI driver disables hclk in its > probe function without realizing that the serial IP might be in use by > a bootconsole. As gsbi driver disables the clock in probe the > bootconsole locks up. > Turning off hclk's could be dangerous if there are system components > like earlyprintk using the hclk. This seems rather fragile. Isn't the right fix for these other components to use the clk api to ensure the clock does not get enabled? Kevin From mboxrd@z Thu Jan 1 00:00:00 1970 From: khilman@kernel.org (Kevin Hilman) Date: Wed, 24 Sep 2014 08:22:58 -0700 Subject: [PATCH v2] soc: qcom: do not disable the iface clock in probe In-Reply-To: <1411500054-13600-1-git-send-email-srinivas.kandagatla@linaro.org> (Srinivas Kandagatla's message of "Tue, 23 Sep 2014 20:20:54 +0100") References: <1411500054-13600-1-git-send-email-srinivas.kandagatla@linaro.org> Message-ID: <7hbnq5m4a5.fsf@deeprootsystems.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Srinivas Kandagatla writes: > since commit 31964ffebbb9 ("tty: serial: msm: Remove direct access to GSBI")' > serial hangs if earlyprintk are enabled. > > This hang is noticed only when the GSBI driver is probed and all the > earlyprintks before gsbi probe are seen on the console. > The reason why it hangs is because GSBI driver disables hclk in its > probe function without realizing that the serial IP might be in use by > a bootconsole. As gsbi driver disables the clock in probe the > bootconsole locks up. > Turning off hclk's could be dangerous if there are system components > like earlyprintk using the hclk. This seems rather fragile. Isn't the right fix for these other components to use the clk api to ensure the clock does not get enabled? Kevin