From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B155B14830A for ; Thu, 8 Aug 2024 22:40:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723156832; cv=none; b=jeTzdBy354ckjtwPs1YzM11GWm8MTiMh8FYcPJ1TQFl5jBdLbGHwqBKfVCwUZCiKVz7npErS9aOXokG5ui9x2uSA3rnvpv2IAo3ATjbbDTutqkMWZl1Xx9wWBPxhOIywOWB9IeXq2Jq4oQg8IvFYx3Y+qqvRUeWc/tSqEJCc7uk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723156832; c=relaxed/simple; bh=7/Yd8Now2RzaC2ZgU+e9VQMlAhXQP/Qjwowv4hiEQSU=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=uj5/qjiIHJYLOf668f+/RWf4c4TgVCf2NuO9zGpPiAURDfty0UlGa2Y7JYxagC62pZrpPTMGwVGSqGdxMWibxTuN2hCyyEgC75xFrzv0QL1lRbNSfdSmlx1IVY2mqE9ZET64JDJcDwnq0VYIeo4a7MJyLlTUrWRv8OJvIi28YKo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=bUxj3v5W; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="bUxj3v5W" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-1fc4fcbb131so11590415ad.3 for ; Thu, 08 Aug 2024 15:40:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1723156829; x=1723761629; darn=lists.linux.dev; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=vnFFKslAyQCvTlzcAGgFXS35aWJRluBhjxEK1S5MBPE=; b=bUxj3v5W4DctVJXzCeIwfVtcGZcWEEXIVgv9/QoTyRRWP1RmvMBgE+OU+LgPzcCbXE H/fHGwBP+2h0Y9U2WVfiIdtOIP4lDKXMXGYzmxz1ett9EGtFaG89KQMvB4rGV4bXuXAx kNnYuv4MbwRDeAXXpf1rle9bQBHKWo3m4btl2VVlccUqQcvOi/oQEYa3OFh/qFgLP07g GIZO+u0lvhVOxjo7gKCznSHeuDTQWHZdLouQbBCz9T3FdUQkKHjQvxA2iY/8CuOeAnPK dcSs05x1bCXLD/shuP5WGiHj8MtDTux919q5R2RPpcuTJhKYI1oT1VsrEO08AEFHxSCK BKNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723156829; x=1723761629; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vnFFKslAyQCvTlzcAGgFXS35aWJRluBhjxEK1S5MBPE=; b=LGEoEL31Xj26k5cF3cUwUv85L73DHzIkpgMToz8Z/vO2EkKfWHSZmCjWibOVHZPkow rDUAjpFmfMtzGq7KZmM2SHHIRag7LJJW+Tlv78bkWbt8UfIXKV9Su0xKlVXth03OoGx+ 2hzUIdPJF3WEy8Z7l9CI2QulCG5DAQku7+sjUfJUM7zyqXgAaOpOaBwff9wNhEID4hTM xvAuQKn0GIrMyLTPUGVYwkXzn7Q5CSa19wjjTQ6cHZffNAZIwxap0ztxvpSQ1ewCcGJl bYj9OFpYPTF0Wvpc4oScOaHD7rk0YUqmdwoPZj87RgHw8VrpeCoCcEdJMNLIkHwl2VEK 5cLA== X-Forwarded-Encrypted: i=1; AJvYcCUMqD3DD12UCtfnq9pl/sycviUuRQObjsdIcKSHcKPEfp2nUwzyK/16tPPAfy9T9s83rrqKYXvuuaOuCO66UZvyQV1Y X-Gm-Message-State: AOJu0YxZQbFzVVNlzI51lImuK8VsaXq8IepbDF6IWytQKkRqrE+I9PXt zd90P+D8r3JZbjejxUjFRxhiO8HMUWwV5DWbJLN6Nqcw0rDFO0WXromsQKLT9L0= X-Google-Smtp-Source: AGHT+IFuozGVpD2S8JcbyZGe128XhqnFMQbDl0tXLzyrxRy3snyF4waOTyuxeRGS6PqrGLYA3KLmIg== X-Received: by 2002:a17:903:228c:b0:1ff:4d4f:d819 with SMTP id d9443c01a7336-200952633e7mr47633515ad.34.1723156829035; Thu, 08 Aug 2024 15:40:29 -0700 (PDT) Received: from localhost ([71.212.170.185]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-200668fc398sm85768725ad.207.2024.08.08.15.40.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Aug 2024 15:40:28 -0700 (PDT) From: Kevin Hilman To: "Rob Herring (Arm)" , soc@kernel.org, Krzysztof Kozlowski , Conor Dooley , Joel Stanley , Andrew Jeffery , Dinh Nguyen , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Vladimir Zapolskiy , Mark Jackson , Tony Lindgren , Michal Simek Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org, imx@lists.linux.dev, linux-omap@vger.kernel.org Subject: Re: [PATCH] ARM: dts: Fix undocumented LM75 compatible nodes In-Reply-To: <20240808164941.1407327-1-robh@kernel.org> References: <20240808164941.1407327-1-robh@kernel.org> Date: Thu, 08 Aug 2024 15:40:27 -0700 Message-ID: <7hcymir63o.fsf@baylibre.com> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain "Rob Herring (Arm)" writes: > "lm75" without any vendor is undocumented. It works with the Linux > kernel since the I2C subsystem will do matches of the compatible string > without a vendor prefix to the i2c_device_id and/or driver name. > > Mostly replace "lm75" with "national,lm75" as that's the original part > vendor and the compatible which matches what "lm75" matched with. In a > couple of cases the node name or compatible gives a clue to the actual > part and vendor and a more specific compatible can be used. In these > cases, it does change the variant the kernel picks. > > "nct75" is an OnSemi part which is compatible with TI TMP75C based on > a comparison of the OnSemi NCT75 datasheet and configuration the Linux > driver uses. Adding an OnSemi compatible would be an ABI change. > > "nxp,lm75" is most likely an NXP part. NXP makes a LM75A and LM75B. > Both are 11-bit resolution and 100ms sample time, so "national,lm75b" is > the closest match. > > While we're here, fix the node names to use the generic name > "temperature-sensor". > > Signed-off-by: Rob Herring (Arm) > --- > SoC maintainers, Please take this directly. [...] > arch/arm/boot/dts/ti/omap/am335x-nano.dts | 2 +- For this one... Reviewed-by: Kevin Hilman From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Date: Thu, 08 Aug 2024 15:40:27 -0700 Subject: [PATCH] ARM: dts: Fix undocumented LM75 compatible nodes In-Reply-To: <20240808164941.1407327-1-robh@kernel.org> References: <20240808164941.1407327-1-robh@kernel.org> Message-ID: <7hcymir63o.fsf@baylibre.com> List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit "Rob Herring (Arm)" writes: > "lm75" without any vendor is undocumented. It works with the Linux > kernel since the I2C subsystem will do matches of the compatible string > without a vendor prefix to the i2c_device_id and/or driver name. > > Mostly replace "lm75" with "national,lm75" as that's the original part > vendor and the compatible which matches what "lm75" matched with. In a > couple of cases the node name or compatible gives a clue to the actual > part and vendor and a more specific compatible can be used. In these > cases, it does change the variant the kernel picks. > > "nct75" is an OnSemi part which is compatible with TI TMP75C based on > a comparison of the OnSemi NCT75 datasheet and configuration the Linux > driver uses. Adding an OnSemi compatible would be an ABI change. > > "nxp,lm75" is most likely an NXP part. NXP makes a LM75A and LM75B. > Both are 11-bit resolution and 100ms sample time, so "national,lm75b" is > the closest match. > > While we're here, fix the node names to use the generic name > "temperature-sensor". > > Signed-off-by: Rob Herring (Arm) > --- > SoC maintainers, Please take this directly. [...] > arch/arm/boot/dts/ti/omap/am335x-nano.dts | 2 +- For this one... Reviewed-by: Kevin Hilman From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 271AEC3DA4A for ; Fri, 9 Aug 2024 00:45:22 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=1DoEXWjZ; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Wg4vN5w6cz2yhT for ; Fri, 9 Aug 2024 10:45:20 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=1DoEXWjZ; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=baylibre.com (client-ip=2607:f8b0:4864:20::62c; helo=mail-pl1-x62c.google.com; envelope-from=khilman@baylibre.com; receiver=lists.ozlabs.org) Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Wg27P59SDz2xxw for ; Fri, 9 Aug 2024 08:40:31 +1000 (AEST) Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-1fdd6d81812so15347455ad.1 for ; Thu, 08 Aug 2024 15:40:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1723156829; x=1723761629; darn=lists.ozlabs.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=vnFFKslAyQCvTlzcAGgFXS35aWJRluBhjxEK1S5MBPE=; b=1DoEXWjZWJDHyWZTQa8Cf2sVFIGX+bua6seeuXnfW8xU8Nr3SQIxBUOFVJcPaChOm2 VcR87rLo/fZJD1DpqktC7g44YTmahaiL6EvBkfyoznhWXJCPYpdqB1xqYDIz1OT+HyaH W+B8HMHiHRc8DLECY6d7QAWobzBQS7e2WHfo0OEv8d9MHV0hmWm6ssWzFGedPsdMcXH4 Uf/6Fqmvh5ABq+vAPEV0DiIUl81V7tmxsTjJLieEO9Q2nUt/E5kOBPX+bRKhd8aGWqKd ofcEBnXrDkCcxM/+KkYIH9lX2zydKAwmSzaKGkc/42V2D9er4pXO5x1uAY2G9PSAWHiN 1S/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723156829; x=1723761629; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vnFFKslAyQCvTlzcAGgFXS35aWJRluBhjxEK1S5MBPE=; b=FZhzfsUrE6D1NFuRgs0Xk+DqY65hDNlPikvbnVPy8PkvRHoWTUb/z3dDewG0MWqbpx JGkSmSBNhQxIyYh8MV0gUKIbnnIlfzrKVXDh4nFo3S2HKOPjFUfQ5LytWedgXqZZSDul rePX9yGrRZWw6FmcNBozPxHgffzpd/xIkv/CQPY4R+iA39lGtcm4c65VE5OMw5rtdIFd 9CcYs3ONjbznXt18ShLwyqSP0fqvr9lVpN2yxUIJMZYiNsjw8QMtFhB4svDrojuQ7Fkq +fLo5/C98x4RW5Jp78vXbCibpwlPkmrVqehBwwiLHQpAlHKqhasWB9UjbxzDEHljG0/V y4VQ== X-Forwarded-Encrypted: i=1; AJvYcCXRc4tZdzxBoPLo29JJxoIns6x8wVL7kXj/ndMD+FbwOCX6cO9pCoFm72/TTXiHIReGz1HPJHWztUJ8k4nWSBiiW6vM1TwMSC0= X-Gm-Message-State: AOJu0YxjL1ioV7lRcHDfF6/Rbdg8Zqk/7zXDy0F73YxWPsrV+y3NIXgU BLtNOMq2qB/VqzZA5SsMJaN+beAFgOD70FqQDdGohtJph2cUTMLv9NbkeJIczZ8= X-Google-Smtp-Source: AGHT+IFuozGVpD2S8JcbyZGe128XhqnFMQbDl0tXLzyrxRy3snyF4waOTyuxeRGS6PqrGLYA3KLmIg== X-Received: by 2002:a17:903:228c:b0:1ff:4d4f:d819 with SMTP id d9443c01a7336-200952633e7mr47633515ad.34.1723156829035; Thu, 08 Aug 2024 15:40:29 -0700 (PDT) Received: from localhost ([71.212.170.185]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-200668fc398sm85768725ad.207.2024.08.08.15.40.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Aug 2024 15:40:28 -0700 (PDT) From: Kevin Hilman To: "Rob Herring (Arm)" , soc@kernel.org, Krzysztof Kozlowski , Conor Dooley , Joel Stanley , Andrew Jeffery , Dinh Nguyen , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Vladimir Zapolskiy , Mark Jackson , Tony Lindgren , Michal Simek Subject: Re: [PATCH] ARM: dts: Fix undocumented LM75 compatible nodes In-Reply-To: <20240808164941.1407327-1-robh@kernel.org> References: <20240808164941.1407327-1-robh@kernel.org> Date: Thu, 08 Aug 2024 15:40:27 -0700 Message-ID: <7hcymir63o.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain X-Mailman-Approved-At: Fri, 09 Aug 2024 10:42:55 +1000 X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-aspeed@lists.ozlabs.org, imx@lists.linux.dev, openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" "Rob Herring (Arm)" writes: > "lm75" without any vendor is undocumented. It works with the Linux > kernel since the I2C subsystem will do matches of the compatible string > without a vendor prefix to the i2c_device_id and/or driver name. > > Mostly replace "lm75" with "national,lm75" as that's the original part > vendor and the compatible which matches what "lm75" matched with. In a > couple of cases the node name or compatible gives a clue to the actual > part and vendor and a more specific compatible can be used. In these > cases, it does change the variant the kernel picks. > > "nct75" is an OnSemi part which is compatible with TI TMP75C based on > a comparison of the OnSemi NCT75 datasheet and configuration the Linux > driver uses. Adding an OnSemi compatible would be an ABI change. > > "nxp,lm75" is most likely an NXP part. NXP makes a LM75A and LM75B. > Both are 11-bit resolution and 100ms sample time, so "national,lm75b" is > the closest match. > > While we're here, fix the node names to use the generic name > "temperature-sensor". > > Signed-off-by: Rob Herring (Arm) > --- > SoC maintainers, Please take this directly. [...] > arch/arm/boot/dts/ti/omap/am335x-nano.dts | 2 +- For this one... Reviewed-by: Kevin Hilman