All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 2/2] PM: domains: Move genpd and its governor to the pmdomain subsystem
@ 2023-12-13 11:33 ` Ulf Hansson
  0 siblings, 0 replies; 7+ messages in thread
From: Ulf Hansson @ 2023-12-13 11:33 UTC (permalink / raw)
  To: Rafael J . Wysocki, linux-pm
  Cc: Kevin Hilman, Ulf Hansson, linux-arm-kernel, linux-kernel

It seems reasonable to collect the core parts for the generic PM domain,
along with its corresponding provider drivers. Therefore let's move the
files from drivers/base/power/ to drivers/pmdomain/ and while at it, let's
also rename the files accordingly.

Moreover, let's also update MAINTAINERS to reflect the update.

Cc: Kevin Hilman <khilman@kernel.org>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
---
 MAINTAINERS                                            | 10 +---------
 drivers/base/power/Makefile                            |  1 -
 drivers/pmdomain/Makefile                              |  1 +
 drivers/{base/power/domain.c => pmdomain/core.c}       |  0
 .../power/domain_governor.c => pmdomain/governor.c}    |  0
 5 files changed, 2 insertions(+), 10 deletions(-)
 rename drivers/{base/power/domain.c => pmdomain/core.c} (100%)
 rename drivers/{base/power/domain_governor.c => pmdomain/governor.c} (100%)

diff --git a/MAINTAINERS b/MAINTAINERS
index ea790149af79..ab4b0aed34f9 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -8878,21 +8878,13 @@ F:	Documentation/devicetree/bindings/i2c/i2c-demux-pinctrl.yaml
 F:	drivers/i2c/muxes/i2c-demux-pinctrl.c
 
 GENERIC PM DOMAINS
-M:	"Rafael J. Wysocki" <rafael@kernel.org>
-M:	Kevin Hilman <khilman@kernel.org>
 M:	Ulf Hansson <ulf.hansson@linaro.org>
 L:	linux-pm@vger.kernel.org
 S:	Supported
 F:	Documentation/devicetree/bindings/power/power?domain*
-F:	drivers/base/power/domain*.c
-F:	include/linux/pm_domain.h
-
-GENERIC PM DOMAIN PROVIDERS
-M:	Ulf Hansson <ulf.hansson@linaro.org>
-L:	linux-pm@vger.kernel.org
-S:	Supported
 T:	git git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/linux-pm.git
 F:	drivers/pmdomain/
+F:	include/linux/pm_domain.h
 
 GENERIC RADIX TREE
 M:	Kent Overstreet <kent.overstreet@linux.dev>
diff --git a/drivers/base/power/Makefile b/drivers/base/power/Makefile
index 8fdd0073eeeb..01f11629d241 100644
--- a/drivers/base/power/Makefile
+++ b/drivers/base/power/Makefile
@@ -2,7 +2,6 @@
 obj-$(CONFIG_PM)	+= sysfs.o generic_ops.o common.o qos.o runtime.o wakeirq.o
 obj-$(CONFIG_PM_SLEEP)	+= main.o wakeup.o wakeup_stats.o
 obj-$(CONFIG_PM_TRACE_RTC)	+= trace.o
-obj-$(CONFIG_PM_GENERIC_DOMAINS)	+=  domain.o domain_governor.o
 obj-$(CONFIG_HAVE_CLK)	+= clock_ops.o
 obj-$(CONFIG_PM_QOS_KUNIT_TEST) += qos-test.o
 
diff --git a/drivers/pmdomain/Makefile b/drivers/pmdomain/Makefile
index f0326b27b30b..a68ece2f4c68 100644
--- a/drivers/pmdomain/Makefile
+++ b/drivers/pmdomain/Makefile
@@ -16,3 +16,4 @@ obj-y					+= sunxi/
 obj-y					+= tegra/
 obj-y					+= ti/
 obj-y					+= xilinx/
+obj-y					+= core.o governor.o
diff --git a/drivers/base/power/domain.c b/drivers/pmdomain/core.c
similarity index 100%
rename from drivers/base/power/domain.c
rename to drivers/pmdomain/core.c
diff --git a/drivers/base/power/domain_governor.c b/drivers/pmdomain/governor.c
similarity index 100%
rename from drivers/base/power/domain_governor.c
rename to drivers/pmdomain/governor.c
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] PM: domains: Move genpd and its governor to the pmdomain subsystem
@ 2023-12-20 18:21 kernel test robot
  0 siblings, 0 replies; 7+ messages in thread
From: kernel test robot @ 2023-12-20 18:21 UTC (permalink / raw)
  To: oe-kbuild; +Cc: lkp, Dan Carpenter

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20231213113305.29098-1-ulf.hansson@linaro.org>
References: <20231213113305.29098-1-ulf.hansson@linaro.org>
TO: Ulf Hansson <ulf.hansson@linaro.org>

Hi Ulf,

kernel test robot noticed the following build warnings:

[auto build test WARNING on rafael-pm/linux-next]
[also build test WARNING on rafael-pm/acpi-bus linus/master v6.7-rc6]
[cannot apply to rafael-pm/devprop next-20231220]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Ulf-Hansson/PM-domains-Move-genpd-and-its-governor-to-the-pmdomain-subsystem/20231213-193436
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
patch link:    https://lore.kernel.org/r/20231213113305.29098-1-ulf.hansson%40linaro.org
patch subject: [PATCH 2/2] PM: domains: Move genpd and its governor to the pmdomain subsystem
:::::: branch date: 7 days ago
:::::: commit date: 7 days ago
config: powerpc64-randconfig-r071-20231220 (https://download.01.org/0day-ci/archive/20231221/202312210228.bcE94X2N-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project.git f28c006a5895fc0e329fe15fead81e37457cb1d1)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202312210228.bcE94X2N-lkp@intel.com/

smatch warnings:
drivers/pmdomain/core.c:427 genpd_dev_pm_set_performance_state() error: 'genpd' dereferencing possible ERR_PTR()
drivers/pmdomain/core.c:822 genpd_dev_pm_start() error: 'genpd' dereferencing possible ERR_PTR()

vim +/genpd +427 drivers/pmdomain/core.c

5937c3ce21228d drivers/base/power/domain.c Ulf Hansson 2021-06-03  420  
401e09201a0118 drivers/base/power/domain.c Ulf Hansson 2023-09-25  421  static int genpd_dev_pm_set_performance_state(struct device *dev,
401e09201a0118 drivers/base/power/domain.c Ulf Hansson 2023-09-25  422  					      unsigned int state)
401e09201a0118 drivers/base/power/domain.c Ulf Hansson 2023-09-25  423  {
401e09201a0118 drivers/base/power/domain.c Ulf Hansson 2023-09-25  424  	struct generic_pm_domain *genpd = dev_to_genpd(dev);
401e09201a0118 drivers/base/power/domain.c Ulf Hansson 2023-09-25  425  	int ret = 0;
401e09201a0118 drivers/base/power/domain.c Ulf Hansson 2023-09-25  426  
401e09201a0118 drivers/base/power/domain.c Ulf Hansson 2023-09-25 @427  	genpd_lock(genpd);
401e09201a0118 drivers/base/power/domain.c Ulf Hansson 2023-09-25  428  	if (pm_runtime_suspended(dev)) {
401e09201a0118 drivers/base/power/domain.c Ulf Hansson 2023-09-25  429  		dev_gpd_data(dev)->rpm_pstate = state;
401e09201a0118 drivers/base/power/domain.c Ulf Hansson 2023-09-25  430  	} else {
401e09201a0118 drivers/base/power/domain.c Ulf Hansson 2023-09-25  431  		ret = genpd_set_performance_state(dev, state);
401e09201a0118 drivers/base/power/domain.c Ulf Hansson 2023-09-25  432  		if (!ret)
401e09201a0118 drivers/base/power/domain.c Ulf Hansson 2023-09-25  433  			dev_gpd_data(dev)->rpm_pstate = 0;
401e09201a0118 drivers/base/power/domain.c Ulf Hansson 2023-09-25  434  	}
401e09201a0118 drivers/base/power/domain.c Ulf Hansson 2023-09-25  435  	genpd_unlock(genpd);
401e09201a0118 drivers/base/power/domain.c Ulf Hansson 2023-09-25  436  
401e09201a0118 drivers/base/power/domain.c Ulf Hansson 2023-09-25  437  	return ret;
401e09201a0118 drivers/base/power/domain.c Ulf Hansson 2023-09-25  438  }
401e09201a0118 drivers/base/power/domain.c Ulf Hansson 2023-09-25  439  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2024-01-03 23:31 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-13 11:33 [PATCH 2/2] PM: domains: Move genpd and its governor to the pmdomain subsystem Ulf Hansson
2023-12-13 11:33 ` Ulf Hansson
2023-12-13 11:42 ` Rafael J. Wysocki
2023-12-13 11:42   ` Rafael J. Wysocki
2024-01-03 23:30 ` Kevin Hilman
2024-01-03 23:30   ` Kevin Hilman
  -- strict thread matches above, loose matches on Subject: below --
2023-12-20 18:21 kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.