From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2E20CC433F5 for ; Fri, 8 Apr 2022 21:08:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RR9FaDPqkpeKGuLaEOXh8qZrZXR4cDD1UdEUmaCQWaQ=; b=kE9lwlsrOvJozh KViqXh0DKTTHarUZ+x9guQrEEZr/7bAcATT4SjEpnIQe8mQv7tzI7apssEbrbW/nrczVOY0qvyqiA Nk4hiMQq5bpT7G4NNTJH+nVqIIaHTXrZpPTN6JZKDJUx9kbZNCgFjbWSJ6CkaC3nqpIboP7k5GMmT D9Zzb/IaotHPHUca/gBU/PJdSfO7C7pPLQ7KVXmgcPEIkr6V/MahyS3Qys6C0HM0ivWanawqYMe3S mDwJhbcBdqVyYzicDzsEh0EU5F/QPj9EfYLuNNsgGf8aiqQMMHJP7lSmnDK1ZreWZDf5hwjymA1Wo +VzioUKjTDmaZb7+cZBg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ncvqU-001G6o-Ic; Fri, 08 Apr 2022 21:08:42 +0000 Received: from mail-pg1-x534.google.com ([2607:f8b0:4864:20::534]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ncvqQ-001G5v-LB for linux-mediatek@lists.infradead.org; Fri, 08 Apr 2022 21:08:40 +0000 Received: by mail-pg1-x534.google.com with SMTP id s21so4263184pgv.13 for ; Fri, 08 Apr 2022 14:08:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=HoLWT/EythxVH1YT+vEjLN2TXDPwfF5xPPqMajsg97o=; b=6DqRW4gK+PKLqJfJdAd0TGTO95Ya7KDB3mBZJjKMlL0nxZLtgxfpl+75BDL9PpUtD/ D8sxCCmecY9A1jNHsGn59jfaYAYVcw0MXiJZsMdhW9Hgaj2eegEWYZqhsHZZ8RViFFh8 g/mUJ5pRz/mDzFZbqiAMFiy2sA1QwSdm7uJ+N0EWGsnS9ZjEVfmjTnqFmuhMnW10Edv7 uODRBJwh1af7cUiTZDMOJnhCYENwjfab4lz7/KYYJOcswfmpJxqrQ5/bp0tB9mIV7ZMt Kceie9MXCbkN4vkioRj3xK49n2u3J7v+iyzNlDM+Hsx6W8Dz7u6YcGhollnP1Te9u94x iUtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=HoLWT/EythxVH1YT+vEjLN2TXDPwfF5xPPqMajsg97o=; b=UiONVccpPDZD+44GcxExIRV3wORVgq+AXBb2HsGszRsvTvD6GBXd42qKS8oQmsyD9l 9QmjgXkXUJJJP1AcIES5mTo0Nds2O9OmxECMKrowgNXjggpx1udv6AzRJtMYXexk7ZLE j7ttjSspBAnyyrSp5JeY/6wZFULa+koJW0x2OzkRcQ08PxGM2ypAEyxM+7uNgGRbnWuR lGDIFcdzRmrwY+psRftab5RVoq3710f42n6QsDZdNaoYtO/LAiO/4I6bu8DIL64VPTAR 4EurmdcrJIIZzzpU8xNw0ImM+9lvt5x+dVZmyrs6+Cu/mqOyV8U8fwpQggHPIW7R2A6Q VG+A== X-Gm-Message-State: AOAM531MZcM/6DoYdP0SD4ySMcPFOHV1ndUBmZcHz31ysX/dUB5UFwEo J3oQJ/avlJ4z7xoJe2q49ThlmQ== X-Google-Smtp-Source: ABdhPJyvhkTmr6m8xOSTjNCBilnTlNxx+TZTy+ro007JGG5u+GpijdOFdlxjLZjwIoz7WZTYTZhnOg== X-Received: by 2002:a63:c015:0:b0:385:fe06:eb86 with SMTP id h21-20020a63c015000000b00385fe06eb86mr16908387pgg.132.1649452117075; Fri, 08 Apr 2022 14:08:37 -0700 (PDT) Received: from localhost (c-71-197-186-152.hsd1.wa.comcast.net. [71.197.186.152]) by smtp.gmail.com with ESMTPSA id s10-20020a63924a000000b00399571b2f99sm12120792pgn.57.2022.04.08.14.08.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Apr 2022 14:08:36 -0700 (PDT) From: Kevin Hilman To: Rex-BC Chen , rafael@kernel.org, viresh.kumar@linaro.org, robh+dt@kernel.org, krzk+dt@kernel.org Cc: matthias.bgg@gmail.com, jia-wei.chang@mediatek.com, roger.lu@mediatek.com, hsinyi@google.com, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com Subject: Re: [PATCH V2 11/15] cpufreq: mediatek: Update logic of voltage_tracking() In-Reply-To: <20220408045908.21671-12-rex-bc.chen@mediatek.com> References: <20220408045908.21671-1-rex-bc.chen@mediatek.com> <20220408045908.21671-12-rex-bc.chen@mediatek.com> Date: Fri, 08 Apr 2022 14:08:36 -0700 Message-ID: <7hczhr5lm3.fsf@baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220408_140838_727971_6758C117 X-CRM114-Status: UNSURE ( 7.31 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Rex-BC Chen writes: > From: Jia-Wei Chang > > - Remove VOLT_TOL because CCI may share the same sram and vproc > regulators with CPU. Therefore, set the max voltage in > regulator_set_voltage() to the proc{sram}_max_volt. This could you a bit more detailed explanation. Why does VOLT_TOL get in the way when regulators are shared between CPU & CCI? > - Move comparison of new and old voltages to > mtk_cpufreq_voltage_tracking(). Why? And how is this related to the above change? Seems to me that it belongs in a separate patch. Kevin _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3C50C433EF for ; Fri, 8 Apr 2022 21:08:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231229AbiDHVKo (ORCPT ); Fri, 8 Apr 2022 17:10:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48688 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238510AbiDHVKn (ORCPT ); Fri, 8 Apr 2022 17:10:43 -0400 Received: from mail-pg1-x52b.google.com (mail-pg1-x52b.google.com [IPv6:2607:f8b0:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 992E63A5F5 for ; Fri, 8 Apr 2022 14:08:37 -0700 (PDT) Received: by mail-pg1-x52b.google.com with SMTP id r66so8800843pgr.3 for ; Fri, 08 Apr 2022 14:08:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=HoLWT/EythxVH1YT+vEjLN2TXDPwfF5xPPqMajsg97o=; b=6DqRW4gK+PKLqJfJdAd0TGTO95Ya7KDB3mBZJjKMlL0nxZLtgxfpl+75BDL9PpUtD/ D8sxCCmecY9A1jNHsGn59jfaYAYVcw0MXiJZsMdhW9Hgaj2eegEWYZqhsHZZ8RViFFh8 g/mUJ5pRz/mDzFZbqiAMFiy2sA1QwSdm7uJ+N0EWGsnS9ZjEVfmjTnqFmuhMnW10Edv7 uODRBJwh1af7cUiTZDMOJnhCYENwjfab4lz7/KYYJOcswfmpJxqrQ5/bp0tB9mIV7ZMt Kceie9MXCbkN4vkioRj3xK49n2u3J7v+iyzNlDM+Hsx6W8Dz7u6YcGhollnP1Te9u94x iUtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=HoLWT/EythxVH1YT+vEjLN2TXDPwfF5xPPqMajsg97o=; b=50tz6Rf51gGG4oSMLH1C5hV/vF/ps1Ka2Tr8oU07yWUNopO7+x55lZN/jkZyORKbO3 B0b80cUZ7oCjQIgAQ9HZupg9q3Xum8S8Qwk8K+JyyvGfuPUCfF2QQrt5ZtRuqBiV5PuX bLooPaYlXRrtiYLXborwxL8LVl7uNKbCHeO94kWhG0kZSd4369Tpb1qkUPMWTWTWjJWv pR+2Phgv7AxRBEAGKDFYjZ7hmLZJcuz7sevrXk/xXhJzE68sV8tDs/kQiFmi9okLV8hk LBbqvk+iLxo6W7xknZcL00xV6hvoKU3fYgZEDMZULYSiMNDAlElYjTEZBLofb1jEeCP7 nYWg== X-Gm-Message-State: AOAM533NwPa82oL2A+sx0BXRrpzMsQmzsCUhRpZazDMxtViUajV9eLPD xreSFyLiJ/dSu56Lh3k2V8KxdQ== X-Google-Smtp-Source: ABdhPJyvhkTmr6m8xOSTjNCBilnTlNxx+TZTy+ro007JGG5u+GpijdOFdlxjLZjwIoz7WZTYTZhnOg== X-Received: by 2002:a63:c015:0:b0:385:fe06:eb86 with SMTP id h21-20020a63c015000000b00385fe06eb86mr16908387pgg.132.1649452117075; Fri, 08 Apr 2022 14:08:37 -0700 (PDT) Received: from localhost (c-71-197-186-152.hsd1.wa.comcast.net. [71.197.186.152]) by smtp.gmail.com with ESMTPSA id s10-20020a63924a000000b00399571b2f99sm12120792pgn.57.2022.04.08.14.08.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Apr 2022 14:08:36 -0700 (PDT) From: Kevin Hilman To: Rex-BC Chen , rafael@kernel.org, viresh.kumar@linaro.org, robh+dt@kernel.org, krzk+dt@kernel.org Cc: matthias.bgg@gmail.com, jia-wei.chang@mediatek.com, roger.lu@mediatek.com, hsinyi@google.com, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com Subject: Re: [PATCH V2 11/15] cpufreq: mediatek: Update logic of voltage_tracking() In-Reply-To: <20220408045908.21671-12-rex-bc.chen@mediatek.com> References: <20220408045908.21671-1-rex-bc.chen@mediatek.com> <20220408045908.21671-12-rex-bc.chen@mediatek.com> Date: Fri, 08 Apr 2022 14:08:36 -0700 Message-ID: <7hczhr5lm3.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Rex-BC Chen writes: > From: Jia-Wei Chang > > - Remove VOLT_TOL because CCI may share the same sram and vproc > regulators with CPU. Therefore, set the max voltage in > regulator_set_voltage() to the proc{sram}_max_volt. This could you a bit more detailed explanation. Why does VOLT_TOL get in the way when regulators are shared between CPU & CCI? > - Move comparison of new and old voltages to > mtk_cpufreq_voltage_tracking(). Why? And how is this related to the above change? Seems to me that it belongs in a separate patch. Kevin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2BAEDC433F5 for ; Fri, 8 Apr 2022 21:09:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7nj/h0ddaBaDPEKVT9g/b+3ac0XaTp24bU9OIF5Jpow=; b=WZ2FkLaVQ896yE Nj1LslpInRHWKgw7KWa6hl1iyxMnh4bx+CUxlB9ZJKvcFbpbpDP3rxd/xP7sHAZN1uqxOF4p8Euf6 hnX/eZG6LmTzDvr+E8UzK9xpqh3BuO4oOtDP9urc5ZCVGTg4nknNQcg92o46N7nhP+vJpZ3M5Oxnv eiywegbCt0sw8c2yF1JoSJkvR52cW4dDsaH5nCmwB9HTzJ6xmlQEenD9u7QSzaZLcCWzmcsgBGndL NjPyO/d/j614c5wEXadctzLgAC+iMO0OrveKcu4uCujN97YMw58YfZPW0qc7bn6JWDfQLyxK7tmX7 z9XNs+JO9YrzlHPlQyag==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ncvqV-001G7D-Q6; Fri, 08 Apr 2022 21:08:43 +0000 Received: from mail-pf1-x42f.google.com ([2607:f8b0:4864:20::42f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ncvqS-001G5w-5A for linux-arm-kernel@lists.infradead.org; Fri, 08 Apr 2022 21:08:41 +0000 Received: by mail-pf1-x42f.google.com with SMTP id w7so9419685pfu.11 for ; Fri, 08 Apr 2022 14:08:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=HoLWT/EythxVH1YT+vEjLN2TXDPwfF5xPPqMajsg97o=; b=6DqRW4gK+PKLqJfJdAd0TGTO95Ya7KDB3mBZJjKMlL0nxZLtgxfpl+75BDL9PpUtD/ D8sxCCmecY9A1jNHsGn59jfaYAYVcw0MXiJZsMdhW9Hgaj2eegEWYZqhsHZZ8RViFFh8 g/mUJ5pRz/mDzFZbqiAMFiy2sA1QwSdm7uJ+N0EWGsnS9ZjEVfmjTnqFmuhMnW10Edv7 uODRBJwh1af7cUiTZDMOJnhCYENwjfab4lz7/KYYJOcswfmpJxqrQ5/bp0tB9mIV7ZMt Kceie9MXCbkN4vkioRj3xK49n2u3J7v+iyzNlDM+Hsx6W8Dz7u6YcGhollnP1Te9u94x iUtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=HoLWT/EythxVH1YT+vEjLN2TXDPwfF5xPPqMajsg97o=; b=c+aPVZjkoqeTmxowx0IflJTbSuWjpeQd1A0cETjCdP5N2oFYVYl6c8dHjT0PW1YvPM x+Is/e9LXcmS/eGbNRVK+2ZC468MYReH80w4j7ed6QGcYV31i7xBA3BQXUxUQg6j2Bx0 CW3qKV9I0pS3kaW6NsEF52ulZEfY9gTy2iRL53lRNpiUo1NPoZLjJegadsLVwX1utM7Q LTGjnrq68BVzJE0Yk5CpumQBxO12645TEj9SIEFXCa6DhQMELc+JmbJ1Z2d/o77/mJpM EsnSCW2/e/pHechHy5R8LYK2LD3U0LN8SBp7rSmfynjfNfsU5mP2iTI5yQcEZy8W09vP xLOA== X-Gm-Message-State: AOAM530Sac7C6NOFgj7YXoxq+YQPiHb0vWzTwtZCEmeVWz/KLJlIrN/7 fTsoFAuKQkEV64JqI00UcPPQuw== X-Google-Smtp-Source: ABdhPJyvhkTmr6m8xOSTjNCBilnTlNxx+TZTy+ro007JGG5u+GpijdOFdlxjLZjwIoz7WZTYTZhnOg== X-Received: by 2002:a63:c015:0:b0:385:fe06:eb86 with SMTP id h21-20020a63c015000000b00385fe06eb86mr16908387pgg.132.1649452117075; Fri, 08 Apr 2022 14:08:37 -0700 (PDT) Received: from localhost (c-71-197-186-152.hsd1.wa.comcast.net. [71.197.186.152]) by smtp.gmail.com with ESMTPSA id s10-20020a63924a000000b00399571b2f99sm12120792pgn.57.2022.04.08.14.08.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Apr 2022 14:08:36 -0700 (PDT) From: Kevin Hilman To: Rex-BC Chen , rafael@kernel.org, viresh.kumar@linaro.org, robh+dt@kernel.org, krzk+dt@kernel.org Cc: matthias.bgg@gmail.com, jia-wei.chang@mediatek.com, roger.lu@mediatek.com, hsinyi@google.com, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com Subject: Re: [PATCH V2 11/15] cpufreq: mediatek: Update logic of voltage_tracking() In-Reply-To: <20220408045908.21671-12-rex-bc.chen@mediatek.com> References: <20220408045908.21671-1-rex-bc.chen@mediatek.com> <20220408045908.21671-12-rex-bc.chen@mediatek.com> Date: Fri, 08 Apr 2022 14:08:36 -0700 Message-ID: <7hczhr5lm3.fsf@baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220408_140840_220302_5C25B181 X-CRM114-Status: UNSURE ( 8.55 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Rex-BC Chen writes: > From: Jia-Wei Chang > > - Remove VOLT_TOL because CCI may share the same sram and vproc > regulators with CPU. Therefore, set the max voltage in > regulator_set_voltage() to the proc{sram}_max_volt. This could you a bit more detailed explanation. Why does VOLT_TOL get in the way when regulators are shared between CPU & CCI? > - Move comparison of new and old voltages to > mtk_cpufreq_voltage_tracking(). Why? And how is this related to the above change? Seems to me that it belongs in a separate patch. Kevin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel