All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@baylibre.com>
To: "Markus Schneider-Pargmann" <msp@baylibre.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Jiri Slaby" <jirislaby@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Markus Schneider-Pargmann" <msp@baylibre.com>,
	"Tony Lindgren" <tony@atomide.com>,
	"Vignesh Raghavendra" <vigneshr@ti.com>,
	"Ronald Wahl" <ronald.wahl@raritan.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Thomas Richard" <thomas.richard@bootlin.com>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Udit Kumar" <u-kumar1@ti.com>,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>
Cc: Vibhore Vardhan <vibhore@ti.com>, Dhruva Gole <d-gole@ti.com>,
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v2 0/5] serial: 8250: omap: Add am62 wakeup support
Date: Wed, 07 Aug 2024 11:55:33 -0700	[thread overview]
Message-ID: <7hed70kvru.fsf@baylibre.com> (raw)
In-Reply-To: <20240807141227.1093006-1-msp@baylibre.com>

Markus Schneider-Pargmann <msp@baylibre.com> writes:

> v2
> --
>
> In Version 2 I removed the Partial-IO specific patches as these can't be
> tested due to power issues in Partial-IO on am62-lp-sk and similar
> boards.
>
> I added a patch to add DT 'wakeup-source' support.
>
> Series
> ------
>
> To support wakeup from several low power modes on am62, don't always
> enable device wakeup. Instead only set it to wakeup capable. A
> devicetree property 'wakeup-source' can be used to enable wakeup. The
> user is also able to control if wakeup is enabled through sysfs.

For my low-power constraints series[1], it's also important to not have
the UART wakeups unconditionally enabled, so I like the defaults
proposed in this series.  Thanks!

I tested on k3-am62a7-sk along with my constraints changes and all is well.

Reviewed-by: Kevin Hilman <khilman@baylibre.com>
Tested-by: Kevin Hilman <khilman@baylibre.com>

Kevin

[1] https://lore.kernel.org/all/20240805-lpm-v6-10-constraints-pmdomain-v1-0-d186b68ded4c@baylibre.com/

      parent reply	other threads:[~2024-08-07 18:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-07 14:12 [PATCH v2 0/5] serial: 8250: omap: Add am62 wakeup support Markus Schneider-Pargmann
2024-08-07 14:12 ` [PATCH v2 1/5] dt-bindings: serial: 8250_omap: Add wakeup-source property Markus Schneider-Pargmann
2024-08-07 16:31   ` Conor Dooley
2024-08-07 14:12 ` [PATCH v2 2/5] serial: 8250: omap: Remove unused wakeups_enabled Markus Schneider-Pargmann
2024-08-07 14:12 ` [PATCH v2 3/5] serial: 8250: omap: Cleanup on error in request_irq Markus Schneider-Pargmann
2024-08-07 14:12 ` [PATCH v2 4/5] serial: 8250: omap: Set wakeup capable, do not enable Markus Schneider-Pargmann
2024-08-07 14:12 ` [PATCH v2 5/5] serial: 8250: omap: Parse DT wakeup-source proerty Markus Schneider-Pargmann
2024-08-07 18:55 ` Kevin Hilman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7hed70kvru.fsf@baylibre.com \
    --to=khilman@baylibre.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=conor+dt@kernel.org \
    --cc=d-gole@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=msp@baylibre.com \
    --cc=robh@kernel.org \
    --cc=ronald.wahl@raritan.com \
    --cc=tglx@linutronix.de \
    --cc=thomas.richard@bootlin.com \
    --cc=tony@atomide.com \
    --cc=u-kumar1@ti.com \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=vibhore@ti.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.