From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41768C43217 for ; Mon, 7 Nov 2022 21:18:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233068AbiKGVS2 (ORCPT ); Mon, 7 Nov 2022 16:18:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41168 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233555AbiKGVSE (ORCPT ); Mon, 7 Nov 2022 16:18:04 -0500 Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5687731DD0 for ; Mon, 7 Nov 2022 13:14:53 -0800 (PST) Received: by mail-pf1-x434.google.com with SMTP id k22so11845248pfd.3 for ; Mon, 07 Nov 2022 13:14:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=5sT7hyCzk9AIqzLbGef+IZ6oJ71RYXWRSZsmUSzO4Yg=; b=P39f7quD853DqM9BBAZi7j1TweO0zXhBFPBLff8eSw0GyPIz2vlyw2NVWhiVuCc9on ZwVgJzNNqjm3e5FZtd6E7iux1mqK/TfXu9YuFK8up7u7ux+VO6b7VNSQk7Mxs3rH6eJN Z7Cd+eLOaD6B3EbEqKVnzXjDCYTHNRcGg43OpYLgICerBRLns7ZVbqpDb5gute1wLruH aJHq2V7yN1f0vRjwa8TwiapmnSZxbOB6B8/GOHUq+PQL/5p6MgBTnMuWz+FCYu+JieUH VbiIsg7WjXHu8Wws2UzTZvODI36Ihj6SCAykvT91K+3xGAQfxqn/5jCOFNzwwPHzMu4L goTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5sT7hyCzk9AIqzLbGef+IZ6oJ71RYXWRSZsmUSzO4Yg=; b=jTheCexsPKRltbu+aM57okmdJ5OejtYhQ7wUM2eoDJMph4c+d+Vni/OiSkZiZ/3ded 2ZsUhK13FWIHQKD3I56re60bUhWtqgB7ET8+z4XXB0N7LZksia9uojc+uEVYfkiiMnb2 Ou9rOzA3YMaePn4Ahnuc7tSA0GpG3IU2XxyNrJ2t5PZy/a1f6haRApnvF+2+QyOZLAHd D4HBtHLYvUS1QVCsJI3iIyZ9PrK5T3vXbGDuN5ow1+M9aPsOulyEuKQmyy9qQvYCUnmI 5blFV2hrEnI6mQNZLx0SMsbpkgPyWllRL/If/Uz3imjxPj4/ZOqSAM31sQNeSHUpSR3+ btFQ== X-Gm-Message-State: ACrzQf2DDQmg114N0dWrsZBy8EB8IWgk6HVWJd/xalMBRSOlcIiWdK7e 7W21NeAjlQ870t9jLc1FsCT5vw== X-Google-Smtp-Source: AMsMyM4fNroJ8un5Wi3EJ604VEP8sq2WlbsGxu3Ax4KtJVEcz4IY0/3AIrVFwaBzallESNsw1/AyxQ== X-Received: by 2002:a63:5811:0:b0:46f:a710:1b77 with SMTP id m17-20020a635811000000b0046fa7101b77mr39853531pgb.392.1667855692494; Mon, 07 Nov 2022 13:14:52 -0800 (PST) Received: from localhost ([75.172.139.56]) by smtp.gmail.com with ESMTPSA id a10-20020a63cd4a000000b0043941566481sm4624005pgj.39.2022.11.07.13.14.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Nov 2022 13:14:52 -0800 (PST) From: Kevin Hilman To: Nishanth Menon , jerome Neanne Cc: Lee Jones , lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org, kristo@kernel.org, dmitry.torokhov@gmail.com, krzysztof.kozlowski+dt@linaro.org, catalin.marinas@arm.com, will@kernel.org, tony@atomide.com, vigneshr@ti.com, bjorn.andersson@linaro.org, shawnguo@kernel.org, geert+renesas@glider.be, dmitry.baryshkov@linaro.org, marcel.ziswiler@toradex.com, vkoul@kernel.org, biju.das.jz@bp.renesas.com, arnd@arndb.de, jeff@labundy.com, afd@ti.com, narmstrong@baylibre.com, msp@baylibre.com, j-keerthy@ti.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCH v6 4/6] mfd: tps65219: Add driver for TI TPS65219 PMIC In-Reply-To: <20221105000104.rtj3r6ufqwqmepon@keenly> References: <20221011140549.16761-1-jneanne@baylibre.com> <20221011140549.16761-5-jneanne@baylibre.com> <1383fd22-c720-811e-a2bb-be2151675089@baylibre.com> <20221105000104.rtj3r6ufqwqmepon@keenly> Date: Mon, 07 Nov 2022 13:14:51 -0800 Message-ID: <7heduewjp0.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Nishanth Menon writes: > On 13:58-20221104, jerome Neanne wrote: >>=20 > [...] > >>=20 >> >=20 >> > Can you try an compile with W=3D1 please. >> This raise one warning on mfd: >> drivers/mfd/tps65219.c:28:12: warning: =E2=80=98tps65219_soft_shutdown= =E2=80=99 defined but >> not used [-Wunused-function] >> 28 | static int tps65219_soft_shutdown(struct tps65219 *tps) >> | ^~~~~~~~~~~~~~~~~~~~~~ >> soft_shutdown has been validated and is used in TI baseline even if not >> hooked in upstream version further to this review: >> https://lore.kernel.org/lkml/20220825150224.826258-5-msp@baylibre.com/ >>=20 >> It was a TI requirement to implement it... >> Let me know if you want me to remove this function or if we can keep it = like >> this. > > There are platforms without psci, correct? I think the comment was to > drop the force override with system-power-controller property, > > if (!pm_power_off) { > tps65219_i2c_client =3D client; > pm_power_off =3D &tps65219_pm_power_off; > } > > Could still be valid for such platforms, no? I do see that the > capability that the PMIC has - which is software shutdown is a valid > feature that we support in many different PMIC drivers. Is'nt the job of > the driver to introduce the functionality in a manner that is > appropriate to the OS framework? Yeah, I think Nishanth is right here. We should probably keep the `if (!pm_power_off)` part so the PMIC will be used if PSCI is not, but it also allows an easy way to test/use the PMIC shutdown functionality downstream if needed. Kevin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 911AEC4332F for ; Mon, 7 Nov 2022 21:16:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=77r7YORlcC+Yy3ZQ0ZsOXtq2ssn8g5csRUiw+Aok7ok=; b=TB4AwLYq3NyukV rVQNXkFjkNSv0nu8JeX6WeYjf3WV6K11RXLORlwFVxh/US07aR59d9+H++Zl9ijDqW9iWJqlvANAz 594qmESdJwsS0oIjBMMLQd0Abquld12nynvJOAIk6HCZea4Pygh+Iuq5vSQrEErM4feWxuyPN59Wm hmbatbuGj/2ZMHJTw0LYEphDBUUGg7QxvbNoRPOXWaTkuskL8mPBy7ddNQ4sArm5L57z7mM0QJdRq 0l6fA/vxywz07IV2pUIRFEyxFfKpwqo/Ljv6MbN1epgXDxj8UyTVSiZ/jdhQaXNFaU8O+J/Zb4kdO C71DJkb2fOsSDkyMG0jA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1os9SN-000bjY-92; Mon, 07 Nov 2022 21:14:59 +0000 Received: from mail-pf1-x432.google.com ([2607:f8b0:4864:20::432]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1os9SK-000bhl-LN for linux-arm-kernel@lists.infradead.org; Mon, 07 Nov 2022 21:14:58 +0000 Received: by mail-pf1-x432.google.com with SMTP id k15so11853210pfg.2 for ; Mon, 07 Nov 2022 13:14:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=5sT7hyCzk9AIqzLbGef+IZ6oJ71RYXWRSZsmUSzO4Yg=; b=P39f7quD853DqM9BBAZi7j1TweO0zXhBFPBLff8eSw0GyPIz2vlyw2NVWhiVuCc9on ZwVgJzNNqjm3e5FZtd6E7iux1mqK/TfXu9YuFK8up7u7ux+VO6b7VNSQk7Mxs3rH6eJN Z7Cd+eLOaD6B3EbEqKVnzXjDCYTHNRcGg43OpYLgICerBRLns7ZVbqpDb5gute1wLruH aJHq2V7yN1f0vRjwa8TwiapmnSZxbOB6B8/GOHUq+PQL/5p6MgBTnMuWz+FCYu+JieUH VbiIsg7WjXHu8Wws2UzTZvODI36Ihj6SCAykvT91K+3xGAQfxqn/5jCOFNzwwPHzMu4L goTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5sT7hyCzk9AIqzLbGef+IZ6oJ71RYXWRSZsmUSzO4Yg=; b=WZ2NWh3NThWM5H8/VvGL2nBEbUYmSQ6ojm8mes1q11VxjhiHbjXB4pdBYMbN1R4hox RlRl/bcWl90EXb/6lcc7fp1OA3bIAFLVaozigvBrhWGEmXXcb2YXNobr2NB8ufTsBzw7 0KKMg5KEi5tKmBgbgsB7ydake5FU9wbvauoVF0l87DmcARcIx9nepN5vEgduraLRMtpP fLDNvIxsiDsgIzSBORdv2bgXTFTwd/9zMSpJtIUHTzzhRemkaB6RiKTXRBiGuackmTA1 tZWzRXP2hNZ49u6bDfpuqPIhs99GO21WhGQZFBh2f2WKMv9A04npYlOacjb+aNhH6aV3 Q4/Q== X-Gm-Message-State: ACrzQf25icHFhsHbT5EDcvfsf6dXIC9HleZPKYlO+9RtVcu3iMgi5p0Q Ohlf+PRnFvWW4SVf0Rf6jFh9qg== X-Google-Smtp-Source: AMsMyM4fNroJ8un5Wi3EJ604VEP8sq2WlbsGxu3Ax4KtJVEcz4IY0/3AIrVFwaBzallESNsw1/AyxQ== X-Received: by 2002:a63:5811:0:b0:46f:a710:1b77 with SMTP id m17-20020a635811000000b0046fa7101b77mr39853531pgb.392.1667855692494; Mon, 07 Nov 2022 13:14:52 -0800 (PST) Received: from localhost ([75.172.139.56]) by smtp.gmail.com with ESMTPSA id a10-20020a63cd4a000000b0043941566481sm4624005pgj.39.2022.11.07.13.14.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Nov 2022 13:14:52 -0800 (PST) From: Kevin Hilman To: Nishanth Menon , jerome Neanne Cc: Lee Jones , lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org, kristo@kernel.org, dmitry.torokhov@gmail.com, krzysztof.kozlowski+dt@linaro.org, catalin.marinas@arm.com, will@kernel.org, tony@atomide.com, vigneshr@ti.com, bjorn.andersson@linaro.org, shawnguo@kernel.org, geert+renesas@glider.be, dmitry.baryshkov@linaro.org, marcel.ziswiler@toradex.com, vkoul@kernel.org, biju.das.jz@bp.renesas.com, arnd@arndb.de, jeff@labundy.com, afd@ti.com, narmstrong@baylibre.com, msp@baylibre.com, j-keerthy@ti.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCH v6 4/6] mfd: tps65219: Add driver for TI TPS65219 PMIC In-Reply-To: <20221105000104.rtj3r6ufqwqmepon@keenly> References: <20221011140549.16761-1-jneanne@baylibre.com> <20221011140549.16761-5-jneanne@baylibre.com> <1383fd22-c720-811e-a2bb-be2151675089@baylibre.com> <20221105000104.rtj3r6ufqwqmepon@keenly> Date: Mon, 07 Nov 2022 13:14:51 -0800 Message-ID: <7heduewjp0.fsf@baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221107_131456_720194_4DEB1F0B X-CRM114-Status: GOOD ( 19.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org TmlzaGFudGggTWVub24gPG5tQHRpLmNvbT4gd3JpdGVzOgoKPiBPbiAxMzo1OC0yMDIyMTEwNCwg amVyb21lIE5lYW5uZSB3cm90ZToKPj4gCj4gWy4uLl0KPgo+PiAKPj4gPiAKPj4gPiBDYW4geW91 IHRyeSBhbiBjb21waWxlIHdpdGggVz0xIHBsZWFzZS4KPj4gVGhpcyByYWlzZSBvbmUgd2Fybmlu ZyBvbiBtZmQ6Cj4+IGRyaXZlcnMvbWZkL3RwczY1MjE5LmM6Mjg6MTI6IHdhcm5pbmc6IOKAmHRw czY1MjE5X3NvZnRfc2h1dGRvd27igJkgZGVmaW5lZCBidXQKPj4gbm90IHVzZWQgWy1XdW51c2Vk LWZ1bmN0aW9uXQo+PiAgICAyOCB8IHN0YXRpYyBpbnQgdHBzNjUyMTlfc29mdF9zaHV0ZG93bihz dHJ1Y3QgdHBzNjUyMTkgKnRwcykKPj4gICAgICAgfCAgICAgICAgICAgIF5+fn5+fn5+fn5+fn5+ fn5+fn5+fn4KPj4gc29mdF9zaHV0ZG93biBoYXMgYmVlbiB2YWxpZGF0ZWQgYW5kIGlzIHVzZWQg aW4gVEkgYmFzZWxpbmUgZXZlbiBpZiBub3QKPj4gaG9va2VkIGluIHVwc3RyZWFtIHZlcnNpb24g ZnVydGhlciB0byB0aGlzIHJldmlldzoKPj4gaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcvbGttbC8y MDIyMDgyNTE1MDIyNC44MjYyNTgtNS1tc3BAYmF5bGlicmUuY29tLwo+PiAKPj4gSXQgd2FzIGEg VEkgcmVxdWlyZW1lbnQgdG8gaW1wbGVtZW50IGl0Li4uCj4+IExldCBtZSBrbm93IGlmIHlvdSB3 YW50IG1lIHRvIHJlbW92ZSB0aGlzIGZ1bmN0aW9uIG9yIGlmIHdlIGNhbiBrZWVwIGl0IGxpa2UK Pj4gdGhpcy4KPgo+IFRoZXJlIGFyZSBwbGF0Zm9ybXMgd2l0aG91dCBwc2NpLCBjb3JyZWN0PyBJ IHRoaW5rIHRoZSBjb21tZW50IHdhcyB0bwo+IGRyb3AgdGhlIGZvcmNlIG92ZXJyaWRlIHdpdGgg c3lzdGVtLXBvd2VyLWNvbnRyb2xsZXIgcHJvcGVydHksCj4KPiBpZiAoIXBtX3Bvd2VyX29mZikg ewo+IAl0cHM2NTIxOV9pMmNfY2xpZW50ID0gY2xpZW50Owo+IAlwbV9wb3dlcl9vZmYgPSAmdHBz NjUyMTlfcG1fcG93ZXJfb2ZmOwo+IH0KPgo+IENvdWxkIHN0aWxsIGJlIHZhbGlkIGZvciBzdWNo IHBsYXRmb3Jtcywgbm8/IEkgZG8gc2VlIHRoYXQgdGhlCj4gY2FwYWJpbGl0eSB0aGF0IHRoZSBQ TUlDIGhhcyAtIHdoaWNoIGlzIHNvZnR3YXJlIHNodXRkb3duIGlzIGEgdmFsaWQKPiBmZWF0dXJl IHRoYXQgd2Ugc3VwcG9ydCBpbiBtYW55IGRpZmZlcmVudCBQTUlDIGRyaXZlcnMuIElzJ250IHRo ZSBqb2Igb2YKPiB0aGUgZHJpdmVyIHRvIGludHJvZHVjZSB0aGUgZnVuY3Rpb25hbGl0eSBpbiBh IG1hbm5lciB0aGF0IGlzCj4gYXBwcm9wcmlhdGUgdG8gdGhlIE9TIGZyYW1ld29yaz8KClllYWgs IEkgdGhpbmsgTmlzaGFudGggaXMgcmlnaHQgaGVyZS4KCldlIHNob3VsZCBwcm9iYWJseSBrZWVw IHRoZSBgaWYgKCFwbV9wb3dlcl9vZmYpYCBwYXJ0IHNvIHRoZSBQTUlDIHdpbGwKYmUgdXNlZCBp ZiBQU0NJIGlzIG5vdCwgYnV0IGl0IGFsc28gYWxsb3dzIGFuIGVhc3kgd2F5IHRvIHRlc3QvdXNl IHRoZSBQTUlDCnNodXRkb3duIGZ1bmN0aW9uYWxpdHkgZG93bnN0cmVhbSBpZiBuZWVkZWQuCgpL ZXZpbgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGlu dXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRl YWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgt YXJtLWtlcm5lbAo=