From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E30CC43219 for ; Thu, 10 Nov 2022 20:16:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231429AbiKJUQc (ORCPT ); Thu, 10 Nov 2022 15:16:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231462AbiKJUQb (ORCPT ); Thu, 10 Nov 2022 15:16:31 -0500 Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D918149B65 for ; Thu, 10 Nov 2022 12:16:28 -0800 (PST) Received: by mail-pj1-x1032.google.com with SMTP id b1-20020a17090a7ac100b00213fde52d49so2822630pjl.3 for ; Thu, 10 Nov 2022 12:16:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=6TElCG4eFIdf6STksjddJrggUNxP/AlOjbuXBcSw0mM=; b=sfzP9GkS2N8sV3ZFlaibrEoEWCHxFt3EUEMFqZbOnqQ8cnYcdfZ9ooaPucSaV9CcYt cEzu6kJyyn1csUNE8WY7Uqbk7bCr+BpjdH9bG5A9bgf9E8jI+3GSs5zyLT4whRZiMUIz JSnePOQn60uFry3wLpyfIcBN5dF7HodqQcTWKLTkpFZlSxHzHCZTjXI9qQEX+xQEVw8l N0BFXZdCdCT1a9N9u/UvWInBVNt54VW1JCtSmuqZ754zU5wksCz5D5Xr8krsAlIQny/d QuG8R5DaZuP2ZdfFJl5LAw+PuqbNGAOPN4B4SJofHM7UFzQDAsGSuJQcYcShSzcrEecG Jdng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6TElCG4eFIdf6STksjddJrggUNxP/AlOjbuXBcSw0mM=; b=UNmg5+0TPxMs5BoOcdeG+Nj/M5qgP0qA7RcjAXYBYJ7qMRCn49rEhGDP+QAdswKU5u iYD5+WxoxmgBRYecpDlKOqA01Jh3Bn49/6xj8WFBFJQCozDxrft4GDQ6jqic0MAb0Pq2 SjbKXt3urOueKgSNUrjrL6x3Jk9X4301EQgezGGOq4MBLgEFwDcmd1m+qm1eu9uD7te+ MtiCKzS6Zpy/LZ6hsbvf+oRjjZYBtq3LyzVSHtEm8MCowdveobtxLR3GR2JLtigl2D5s sWv0Z5llSvgEgVbVBLyWJxQpUKMMFJssChs/NmiTxvQgHx1c/AC3pneNWeIpvrMl3fjh kMVA== X-Gm-Message-State: ACrzQf0tgqSBxSftMxp7a4dAW90uDC2ThCSmoCAaeD02FXYXw1HUKFnR 2p/WK8my8v5dGHJs03t7rRR4fg== X-Google-Smtp-Source: AMsMyM668jd6+A/ewh9nZvDze5l7U6DAYz/tHcvu9BcXLhffErJqbrIv11eqIx4lwO+6RsL5KqCg1A== X-Received: by 2002:a17:90a:68cd:b0:212:ca89:41c9 with SMTP id q13-20020a17090a68cd00b00212ca8941c9mr1913900pjj.244.1668111388236; Thu, 10 Nov 2022 12:16:28 -0800 (PST) Received: from localhost ([75.172.139.56]) by smtp.gmail.com with ESMTPSA id z1-20020aa79901000000b005360da6b26bsm50380pff.159.2022.11.10.12.16.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Nov 2022 12:16:27 -0800 (PST) From: Kevin Hilman To: Andrew Davis , jerome Neanne , Nishanth Menon Cc: Lee Jones , lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org, kristo@kernel.org, dmitry.torokhov@gmail.com, krzysztof.kozlowski+dt@linaro.org, catalin.marinas@arm.com, will@kernel.org, tony@atomide.com, vigneshr@ti.com, bjorn.andersson@linaro.org, shawnguo@kernel.org, geert+renesas@glider.be, dmitry.baryshkov@linaro.org, marcel.ziswiler@toradex.com, vkoul@kernel.org, biju.das.jz@bp.renesas.com, arnd@arndb.de, jeff@labundy.com, narmstrong@baylibre.com, msp@baylibre.com, j-keerthy@ti.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCH v6 4/6] mfd: tps65219: Add driver for TI TPS65219 PMIC In-Reply-To: <1231f3e6-61a7-ca3c-2fbb-679b583e0df1@ti.com> References: <20221011140549.16761-1-jneanne@baylibre.com> <20221011140549.16761-5-jneanne@baylibre.com> <1383fd22-c720-811e-a2bb-be2151675089@baylibre.com> <20221105000104.rtj3r6ufqwqmepon@keenly> <7heduewjp0.fsf@baylibre.com> <5418ac3b-04d7-5e77-7612-c8f168e24621@ti.com> <1267bf43-618c-7347-be3a-2792c656d9b6@baylibre.com> <7hk042agn4.fsf@baylibre.com> <1231f3e6-61a7-ca3c-2fbb-679b583e0df1@ti.com> Date: Thu, 10 Nov 2022 12:16:27 -0800 Message-ID: <7hfseqa7l0.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Andrew Davis writes: > On 11/10/22 11:00 AM, Kevin Hilman wrote: >> jerome Neanne writes: >>=20 >>> On 09/11/2022 22:59, Andrew Davis wrote: >>>> On 11/7/22 3:14 PM, Kevin Hilman wrote: >>>>> Nishanth Menon writes: >>>>> >>>>>> On 13:58-20221104, jerome Neanne wrote: >>>>>>> >>>>>> [...] >>>>>> >>>>>>> >>>>>>>> >>>>>>>> Can you try an compile with W=3D1 please. >>>>>>> This raise one warning on mfd: >>>>>>> drivers/mfd/tps65219.c:28:12: warning: =E2=80=98tps65219_soft_shutd= own=E2=80=99 >>>>>>> defined but >>>>>>> not used [-Wunused-function] >>>>>>> =C2=A0=C2=A0=C2=A0 28 | static int tps65219_soft_shutdown(struct t= ps65219 *tps) >>>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ^~~~~~~~~~~~~~~~~~~~~~ >>>>>>> soft_shutdown has been validated and is used in TI baseline even if= not >>>>>>> hooked in upstream version further to this review: >>>>>>> https://lore.kernel.org/lkml/20220825150224.826258-5-msp@baylibre.c= om/ >>>>>>> >>>>>>> It was a TI requirement to implement it... >>>>>>> Let me know if you want me to remove this function or if we can keep >>>>>>> it like >>>>>>> this. >>>>>> >>>>>> There are platforms without psci, correct? I think the comment was to >>>>>> drop the force override with system-power-controller property, >>>>>> >>>>>> if (!pm_power_off) { >>>>>> =C2=A0=C2=A0=C2=A0=C2=A0tps65219_i2c_client =3D client; >>>>>> =C2=A0=C2=A0=C2=A0=C2=A0pm_power_off =3D &tps65219_pm_power_off; >>>>>> } >>>>>> >>>>>> Could still be valid for such platforms, no? I do see that the >>>>>> capability that the PMIC has - which is software shutdown is a valid >>>>>> feature that we support in many different PMIC drivers. Is'nt the jo= b of >>>>>> the driver to introduce the functionality in a manner that is >>>>>> appropriate to the OS framework? >>>>> >>>>> Yeah, I think Nishanth is right here. >>>>> >>>>> We should probably keep the `if (!pm_power_off)` part so the PMIC will >>>>> be used if PSCI is not, but it also allows an easy way to test/use the >>>>> PMIC >>>>> shutdown functionality downstream if needed. >>>>> >>>> >>>> Then should be using the sys-off handler API[0] so it doesn't block PS= CI >>>> which is also switching over[1]. >>>> >>>> Andrew >>>> >>>> [0] https://lwn.net/Articles/894511/ >>>> [1] https://www.spinics.net/lists/arm-kernel/msg1024127.html >>> Can we go for upstream with v7 without tps65219_soft_shutdown. Then if >>> everyone agrees with Andrew proposal, I'll submit a separate patch which >>> adds implementation of tps65219_soft_shutdown support through sys-off >>> handler. >>> >>> So that we are not blocking upstream in case further >>> discussions/alignment are required. >>=20 >> Seems OK to me. Nishanth? Andrew? >>=20 >> But I think you'll need to at least submit a v8 without the unused >> code/dead code that Lee pointed out. >>=20 > > If you need the v8 anyway, then add support through sys-off in > that spin, should only be a couple lines of change. Oops, my mistake. I see v7 already has the dead code removed. I got confused because this thread is on v6. IMO, I think v7 should be merged v7 (mfd part is already ack'd by Lee) and then Jerome will follow up with the support for sys-off as an additional series. Kevin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A4465C4332F for ; Thu, 10 Nov 2022 20:17:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EaEYsuXW/SCsYtB+1on3mn+A2S18cBMtkYvQ9ni6H8U=; b=gCxm/UPenNOCU+ Vj2uIIzAvTCGeyyvM9Jmis/l7pxsKL9uW7/cqUP+4f9n0PKc53twgEVSo6Hi0P/YE1hWcgxPcQ8/8 9E/kzs9BbL3w8xkeopDMfRwAYRiduYoeu7RGZBxgQMN9vKwZAXIdP+ADXkkb0NV6qyEHod38+AnBf sKm7QlxKAZkvJdT1vuG6GOxs/lNjhpfOxdzD5wyoK3hS53BaWN3hSwEU10VdR43xPP/LNrKKa2PVo 8ltasZk/JP7/PSSopzs2jR8i+soBxYjEEsq8xk6mRHRqpKvDxd3N+e+Fptlt/er773srV/T8ikEt6 ZafNbt03ywL8xa/5fsoA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1otDyW-009FTg-1w; Thu, 10 Nov 2022 20:16:36 +0000 Received: from mail-pj1-x1031.google.com ([2607:f8b0:4864:20::1031]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1otDyP-009FQQ-Ov for linux-arm-kernel@lists.infradead.org; Thu, 10 Nov 2022 20:16:32 +0000 Received: by mail-pj1-x1031.google.com with SMTP id q1-20020a17090a750100b002139ec1e999so2842913pjk.1 for ; Thu, 10 Nov 2022 12:16:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=6TElCG4eFIdf6STksjddJrggUNxP/AlOjbuXBcSw0mM=; b=sfzP9GkS2N8sV3ZFlaibrEoEWCHxFt3EUEMFqZbOnqQ8cnYcdfZ9ooaPucSaV9CcYt cEzu6kJyyn1csUNE8WY7Uqbk7bCr+BpjdH9bG5A9bgf9E8jI+3GSs5zyLT4whRZiMUIz JSnePOQn60uFry3wLpyfIcBN5dF7HodqQcTWKLTkpFZlSxHzHCZTjXI9qQEX+xQEVw8l N0BFXZdCdCT1a9N9u/UvWInBVNt54VW1JCtSmuqZ754zU5wksCz5D5Xr8krsAlIQny/d QuG8R5DaZuP2ZdfFJl5LAw+PuqbNGAOPN4B4SJofHM7UFzQDAsGSuJQcYcShSzcrEecG Jdng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6TElCG4eFIdf6STksjddJrggUNxP/AlOjbuXBcSw0mM=; b=E9Cxlud1JJBtX7nLD2NBUUlgIeRHCpqYwiCdSk1z4jTCGAey10h8HJ+YJff6pLF8qH fjBe53ROviZoilTbwniD9RjYXdxPAGvJDHmYOyr8YQxafpCNYX8C/EmOMXFgDsut1Qpe gGQ8QPu1JUQY6KGMapJWrFc2UIsKGxMQcrIjCVAaCCQ1IEUqRV+255wtUfQO7UeQ5HTK nPt98zY0GhjE7/ESQ124CilS/A6EZQ33Ba+Zc86HSrNegDHQE5ngmeslyXfmAq4fkS/1 SrA6ZFPXigF7HMKoXVgbSnC5nhA1jkiSWlJHThFsHefxCZ69c/B8cJETkAMHL4XLnTCU SEsA== X-Gm-Message-State: ACrzQf1QqrNCPmsrkDhmLHHe8pSpzFAUDYdEP9SoSMQj2IwWJhaeOqg9 Z9na06m8mci1Lq2wgVAvfcTkMA== X-Google-Smtp-Source: AMsMyM668jd6+A/ewh9nZvDze5l7U6DAYz/tHcvu9BcXLhffErJqbrIv11eqIx4lwO+6RsL5KqCg1A== X-Received: by 2002:a17:90a:68cd:b0:212:ca89:41c9 with SMTP id q13-20020a17090a68cd00b00212ca8941c9mr1913900pjj.244.1668111388236; Thu, 10 Nov 2022 12:16:28 -0800 (PST) Received: from localhost ([75.172.139.56]) by smtp.gmail.com with ESMTPSA id z1-20020aa79901000000b005360da6b26bsm50380pff.159.2022.11.10.12.16.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Nov 2022 12:16:27 -0800 (PST) From: Kevin Hilman To: Andrew Davis , jerome Neanne , Nishanth Menon Cc: Lee Jones , lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org, kristo@kernel.org, dmitry.torokhov@gmail.com, krzysztof.kozlowski+dt@linaro.org, catalin.marinas@arm.com, will@kernel.org, tony@atomide.com, vigneshr@ti.com, bjorn.andersson@linaro.org, shawnguo@kernel.org, geert+renesas@glider.be, dmitry.baryshkov@linaro.org, marcel.ziswiler@toradex.com, vkoul@kernel.org, biju.das.jz@bp.renesas.com, arnd@arndb.de, jeff@labundy.com, narmstrong@baylibre.com, msp@baylibre.com, j-keerthy@ti.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCH v6 4/6] mfd: tps65219: Add driver for TI TPS65219 PMIC In-Reply-To: <1231f3e6-61a7-ca3c-2fbb-679b583e0df1@ti.com> References: <20221011140549.16761-1-jneanne@baylibre.com> <20221011140549.16761-5-jneanne@baylibre.com> <1383fd22-c720-811e-a2bb-be2151675089@baylibre.com> <20221105000104.rtj3r6ufqwqmepon@keenly> <7heduewjp0.fsf@baylibre.com> <5418ac3b-04d7-5e77-7612-c8f168e24621@ti.com> <1267bf43-618c-7347-be3a-2792c656d9b6@baylibre.com> <7hk042agn4.fsf@baylibre.com> <1231f3e6-61a7-ca3c-2fbb-679b583e0df1@ti.com> Date: Thu, 10 Nov 2022 12:16:27 -0800 Message-ID: <7hfseqa7l0.fsf@baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221110_121630_079929_17D61169 X-CRM114-Status: GOOD ( 19.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org QW5kcmV3IERhdmlzIDxhZmRAdGkuY29tPiB3cml0ZXM6Cgo+IE9uIDExLzEwLzIyIDExOjAwIEFN LCBLZXZpbiBIaWxtYW4gd3JvdGU6Cj4+IGplcm9tZSBOZWFubmUgPGpuZWFubmVAYmF5bGlicmUu Y29tPiB3cml0ZXM6Cj4+IAo+Pj4gT24gMDkvMTEvMjAyMiAyMjo1OSwgQW5kcmV3IERhdmlzIHdy b3RlOgo+Pj4+IE9uIDExLzcvMjIgMzoxNCBQTSwgS2V2aW4gSGlsbWFuIHdyb3RlOgo+Pj4+PiBO aXNoYW50aCBNZW5vbiA8bm1AdGkuY29tPiB3cml0ZXM6Cj4+Pj4+Cj4+Pj4+PiBPbiAxMzo1OC0y MDIyMTEwNCwgamVyb21lIE5lYW5uZSB3cm90ZToKPj4+Pj4+Pgo+Pj4+Pj4gWy4uLl0KPj4+Pj4+ Cj4+Pj4+Pj4KPj4+Pj4+Pj4KPj4+Pj4+Pj4gQ2FuIHlvdSB0cnkgYW4gY29tcGlsZSB3aXRoIFc9 MSBwbGVhc2UuCj4+Pj4+Pj4gVGhpcyByYWlzZSBvbmUgd2FybmluZyBvbiBtZmQ6Cj4+Pj4+Pj4g ZHJpdmVycy9tZmQvdHBzNjUyMTkuYzoyODoxMjogd2FybmluZzog4oCYdHBzNjUyMTlfc29mdF9z aHV0ZG93buKAmQo+Pj4+Pj4+IGRlZmluZWQgYnV0Cj4+Pj4+Pj4gbm90IHVzZWQgWy1XdW51c2Vk LWZ1bmN0aW9uXQo+Pj4+Pj4+ICDCoMKgwqAgMjggfCBzdGF0aWMgaW50IHRwczY1MjE5X3NvZnRf c2h1dGRvd24oc3RydWN0IHRwczY1MjE5ICp0cHMpCj4+Pj4+Pj4gIMKgwqDCoMKgwqDCoCB8wqDC oMKgwqDCoMKgwqDCoMKgwqDCoCBefn5+fn5+fn5+fn5+fn5+fn5+fn5+Cj4+Pj4+Pj4gc29mdF9z aHV0ZG93biBoYXMgYmVlbiB2YWxpZGF0ZWQgYW5kIGlzIHVzZWQgaW4gVEkgYmFzZWxpbmUgZXZl biBpZiBub3QKPj4+Pj4+PiBob29rZWQgaW4gdXBzdHJlYW0gdmVyc2lvbiBmdXJ0aGVyIHRvIHRo aXMgcmV2aWV3Ogo+Pj4+Pj4+IGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL2xrbWwvMjAyMjA4MjUx NTAyMjQuODI2MjU4LTUtbXNwQGJheWxpYnJlLmNvbS8KPj4+Pj4+Pgo+Pj4+Pj4+IEl0IHdhcyBh IFRJIHJlcXVpcmVtZW50IHRvIGltcGxlbWVudCBpdC4uLgo+Pj4+Pj4+IExldCBtZSBrbm93IGlm IHlvdSB3YW50IG1lIHRvIHJlbW92ZSB0aGlzIGZ1bmN0aW9uIG9yIGlmIHdlIGNhbiBrZWVwCj4+ Pj4+Pj4gaXQgbGlrZQo+Pj4+Pj4+IHRoaXMuCj4+Pj4+Pgo+Pj4+Pj4gVGhlcmUgYXJlIHBsYXRm b3JtcyB3aXRob3V0IHBzY2ksIGNvcnJlY3Q/IEkgdGhpbmsgdGhlIGNvbW1lbnQgd2FzIHRvCj4+ Pj4+PiBkcm9wIHRoZSBmb3JjZSBvdmVycmlkZSB3aXRoIHN5c3RlbS1wb3dlci1jb250cm9sbGVy IHByb3BlcnR5LAo+Pj4+Pj4KPj4+Pj4+IGlmICghcG1fcG93ZXJfb2ZmKSB7Cj4+Pj4+PiAgwqDC oMKgwqB0cHM2NTIxOV9pMmNfY2xpZW50ID0gY2xpZW50Owo+Pj4+Pj4gIMKgwqDCoMKgcG1fcG93 ZXJfb2ZmID0gJnRwczY1MjE5X3BtX3Bvd2VyX29mZjsKPj4+Pj4+IH0KPj4+Pj4+Cj4+Pj4+PiBD b3VsZCBzdGlsbCBiZSB2YWxpZCBmb3Igc3VjaCBwbGF0Zm9ybXMsIG5vPyBJIGRvIHNlZSB0aGF0 IHRoZQo+Pj4+Pj4gY2FwYWJpbGl0eSB0aGF0IHRoZSBQTUlDIGhhcyAtIHdoaWNoIGlzIHNvZnR3 YXJlIHNodXRkb3duIGlzIGEgdmFsaWQKPj4+Pj4+IGZlYXR1cmUgdGhhdCB3ZSBzdXBwb3J0IGlu IG1hbnkgZGlmZmVyZW50IFBNSUMgZHJpdmVycy4gSXMnbnQgdGhlIGpvYiBvZgo+Pj4+Pj4gdGhl IGRyaXZlciB0byBpbnRyb2R1Y2UgdGhlIGZ1bmN0aW9uYWxpdHkgaW4gYSBtYW5uZXIgdGhhdCBp cwo+Pj4+Pj4gYXBwcm9wcmlhdGUgdG8gdGhlIE9TIGZyYW1ld29yaz8KPj4+Pj4KPj4+Pj4gWWVh aCwgSSB0aGluayBOaXNoYW50aCBpcyByaWdodCBoZXJlLgo+Pj4+Pgo+Pj4+PiBXZSBzaG91bGQg cHJvYmFibHkga2VlcCB0aGUgYGlmICghcG1fcG93ZXJfb2ZmKWAgcGFydCBzbyB0aGUgUE1JQyB3 aWxsCj4+Pj4+IGJlIHVzZWQgaWYgUFNDSSBpcyBub3QsIGJ1dCBpdCBhbHNvIGFsbG93cyBhbiBl YXN5IHdheSB0byB0ZXN0L3VzZSB0aGUKPj4+Pj4gUE1JQwo+Pj4+PiBzaHV0ZG93biBmdW5jdGlv bmFsaXR5IGRvd25zdHJlYW0gaWYgbmVlZGVkLgo+Pj4+Pgo+Pj4+Cj4+Pj4gVGhlbiBzaG91bGQg YmUgdXNpbmcgdGhlIHN5cy1vZmYgaGFuZGxlciBBUElbMF0gc28gaXQgZG9lc24ndCBibG9jayBQ U0NJCj4+Pj4gd2hpY2ggaXMgYWxzbyBzd2l0Y2hpbmcgb3ZlclsxXS4KPj4+Pgo+Pj4+IEFuZHJl dwo+Pj4+Cj4+Pj4gWzBdIGh0dHBzOi8vbHduLm5ldC9BcnRpY2xlcy84OTQ1MTEvCj4+Pj4gWzFd IGh0dHBzOi8vd3d3LnNwaW5pY3MubmV0L2xpc3RzL2FybS1rZXJuZWwvbXNnMTAyNDEyNy5odG1s Cj4+PiBDYW4gd2UgZ28gZm9yIHVwc3RyZWFtIHdpdGggdjcgd2l0aG91dCB0cHM2NTIxOV9zb2Z0 X3NodXRkb3duLiBUaGVuIGlmCj4+PiBldmVyeW9uZSBhZ3JlZXMgd2l0aCBBbmRyZXcgcHJvcG9z YWwsIEknbGwgc3VibWl0IGEgc2VwYXJhdGUgcGF0Y2ggd2hpY2gKPj4+IGFkZHMgaW1wbGVtZW50 YXRpb24gb2YgdHBzNjUyMTlfc29mdF9zaHV0ZG93biBzdXBwb3J0IHRocm91Z2ggc3lzLW9mZgo+ Pj4gaGFuZGxlci4KPj4+Cj4+PiBTbyB0aGF0IHdlIGFyZSBub3QgYmxvY2tpbmcgdXBzdHJlYW0g aW4gY2FzZSBmdXJ0aGVyCj4+PiBkaXNjdXNzaW9ucy9hbGlnbm1lbnQgYXJlIHJlcXVpcmVkLgo+ PiAKPj4gU2VlbXMgT0sgdG8gbWUuICBOaXNoYW50aD8gIEFuZHJldz8KPj4gCj4+IEJ1dCBJIHRo aW5rIHlvdSdsbCBuZWVkIHRvIGF0IGxlYXN0IHN1Ym1pdCBhIHY4IHdpdGhvdXQgdGhlIHVudXNl ZAo+PiBjb2RlL2RlYWQgY29kZSB0aGF0IExlZSBwb2ludGVkIG91dC4KPj4gCj4KPiBJZiB5b3Ug bmVlZCB0aGUgdjggYW55d2F5LCB0aGVuIGFkZCBzdXBwb3J0IHRocm91Z2ggc3lzLW9mZiBpbgo+ IHRoYXQgc3Bpbiwgc2hvdWxkIG9ubHkgYmUgYSBjb3VwbGUgbGluZXMgb2YgY2hhbmdlLgoKT29w cywgbXkgbWlzdGFrZS4gIEkgc2VlIHY3IGFscmVhZHkgaGFzIHRoZSBkZWFkIGNvZGUgcmVtb3Zl ZC4gIEkgZ290CmNvbmZ1c2VkIGJlY2F1c2UgdGhpcyB0aHJlYWQgaXMgb24gdjYuCgpJTU8sIEkg dGhpbmsgdjcgc2hvdWxkIGJlIG1lcmdlZCB2NyAobWZkIHBhcnQgaXMgYWxyZWFkeSBhY2snZCBi eSBMZWUpCmFuZCB0aGVuIEplcm9tZSB3aWxsIGZvbGxvdyB1cCB3aXRoIHRoZSBzdXBwb3J0IGZv ciBzeXMtb2ZmIGFzIGFuCmFkZGl0aW9uYWwgc2VyaWVzLgoKS2V2aW4KCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGlu ZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMu aW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK