From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A46FC07E9D for ; Mon, 26 Sep 2022 18:50:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230463AbiIZSux (ORCPT ); Mon, 26 Sep 2022 14:50:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55192 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230408AbiIZSuw (ORCPT ); Mon, 26 Sep 2022 14:50:52 -0400 Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2614E7549A for ; Mon, 26 Sep 2022 11:50:50 -0700 (PDT) Received: by mail-pj1-x102b.google.com with SMTP id s90-20020a17090a2f6300b00203a685a1aaso7852712pjd.1 for ; Mon, 26 Sep 2022 11:50:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date; bh=lRlQkEGyVotDOVgVJrH2x+4l2jryHK0GCkRlRhyLnhU=; b=wNQjmt87soT1/9iOavumcWhdxLJRmPMW/Ex1HSaDbDYmyFFKqLTbfk3MxMIVF3/h+2 6r+N+caO4DyzpBpMl0zcVzBLaCM+NmRuuqmipB3zKX5h088QcM6jqUHIcSqjA0vaTR2h yPW5ooz9pjoc++gBhvJLObhUxv08wgY7qtiUMkr19WxtHQeXrCFiYHx3851B/1P5AdoQ kHoVB1XRCiiSj/Y6vwFavbjyY192VXrpUynzhzx48CitCJ/9OpuhPZMQjEfipvXDYujP KeJ2ALh31b/acF7AG6nuE3h7z/8ecfUtN5UM0oVrY2Nb6BsyHeO5rKaiijcKmrgaCyeC hwUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=lRlQkEGyVotDOVgVJrH2x+4l2jryHK0GCkRlRhyLnhU=; b=wW36t7fj4OBK8HonGkVqiN1yXVWb7JqbtSnOCHdbNYYw+gzo/lJ9J+lVJHSSaWiZlk nQODulvINUC/6JfJE3PYVacekkwk7IVCjFiYLe4SiWNH6nmW/PetBdjGqQhywr5fPMjQ jkz28zwzoEQrPqyhyItr+r8Jkzt9NhFDZPBL+ZEI79FnQcubaDgsNDIJVdSJpw21EYEk bkaTivjvEo56P6e0YbtYl6qtAUfKUQo0amyyk+1nPtYrJ/WimIAZIP9uTp8xHJ+idxLc 2NeaY005572Y9GW7wyL9lNg6Owwf57G1g8Ktft5NH8EtlstTp3qt1sLdvkDc/mZh9zkv OzhA== X-Gm-Message-State: ACrzQf0n9MqOPzc9MZnC3UzOPFnVTp1A4aQ392L88WmQOR2B4RRt5gxA x60fi43nRDXbAY/DUva/Zr5RXQ== X-Google-Smtp-Source: AMsMyM6J++Jq/n6Tnfq8CzvGKz64B+KbXGB62f9OfjkL7sI9zcmjBW7e/aO/O6KZ5Zz+zGyVI86+Kw== X-Received: by 2002:a17:902:da8f:b0:178:399b:89bb with SMTP id j15-20020a170902da8f00b00178399b89bbmr23612803plx.57.1664218249640; Mon, 26 Sep 2022 11:50:49 -0700 (PDT) Received: from localhost ([76.146.1.42]) by smtp.gmail.com with ESMTPSA id y4-20020a655a04000000b00439d071c110sm11083443pgs.43.2022.09.26.11.50.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Sep 2022 11:50:48 -0700 (PDT) From: Kevin Hilman To: =?utf-8?Q?P=C3=A9ter?= Ujfalusi , dmaengine@vger.kernel.org Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Nicolas Frayer Subject: Re: [PATCH 3/3] dma/ti: convert PSIL to be buildable as module In-Reply-To: <4c9f0284-f8d0-75e5-8bc9-944b040f9edb@gmail.com> References: <20220926181848.2917639-1-khilman@baylibre.com> <20220926181848.2917639-4-khilman@baylibre.com> <4c9f0284-f8d0-75e5-8bc9-944b040f9edb@gmail.com> Date: Mon, 26 Sep 2022 11:50:46 -0700 Message-ID: <7hfsgeezqx.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org P=C3=A9ter Ujfalusi writes: > Hi Kevin, > > On 9/26/22 21:18, Kevin Hilman wrote: >> map symbols need EXPORT_SYMBOL and files need MODULE_LICENSE. >>=20 >> Signed-off-by: Kevin Hilman >> --- >> drivers/dma/ti/Kconfig | 3 ++- >> drivers/dma/ti/k3-psil-am62.c | 4 ++++ >> drivers/dma/ti/k3-psil-am64.c | 4 ++++ >> drivers/dma/ti/k3-psil-am654.c | 4 ++++ >> drivers/dma/ti/k3-psil-j7200.c | 4 ++++ >> drivers/dma/ti/k3-psil-j721e.c | 4 ++++ >> drivers/dma/ti/k3-psil-j721s2.c | 4 ++++ >> drivers/dma/ti/k3-psil.c | 2 ++ >> 8 files changed, 28 insertions(+), 1 deletion(-) >>=20 >> diff --git a/drivers/dma/ti/Kconfig b/drivers/dma/ti/Kconfig >> index f196be3b222f..2adc2cca10e9 100644 >> --- a/drivers/dma/ti/Kconfig >> +++ b/drivers/dma/ti/Kconfig >> @@ -56,7 +56,8 @@ config TI_K3_UDMA_GLUE_LAYER >> If unsure, say N. >>=20=20 >> config TI_K3_PSIL >> - bool >> + tristate >> + default TI_K3_UDMA >>=20=20 >> config TI_DMA_CROSSBAR >> bool >> diff --git a/drivers/dma/ti/k3-psil-am62.c b/drivers/dma/ti/k3-psil-am62= .c >> index 2b6fd6e37c61..7c4ca85f68b1 100644 >> --- a/drivers/dma/ti/k3-psil-am62.c >> +++ b/drivers/dma/ti/k3-psil-am62.c >> @@ -4,6 +4,7 @@ >> */ >>=20=20 >> #include >> +#include >>=20=20 >> #include "k3-psil-priv.h" >>=20=20 >> @@ -184,3 +185,6 @@ struct psil_ep_map am62_ep_map =3D { >> .dst =3D am62_dst_ep_map, >> .dst_count =3D ARRAY_SIZE(am62_dst_ep_map), >> }; >> +EXPORT_SYMBOL_GPL(am62_ep_map); > > Wouldn't it be better to build one module (k3-psil.ko) and link all the > platform libs into that? > They are unconditionally built in all cases anyways and makes the lsmod > under control. > And no need to export these maps at all is a plus. I guess that's one option, but seems to be to be the wrong direction for a modular kernel. To me, it seems like the next step would be to make it so only the SoC specific module is loaded instead of always loading them all. Kevin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 67E0EC32771 for ; Mon, 26 Sep 2022 18:52:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DaEFoCjt/8dHOugcEcreyBsaQmcBxrCBs3As6e6bEs0=; b=qw027ncR4a3lWa DjiID5EJ6z7TjYL0x3zlGFTO/5CGAcRy6v7YUPTdTWbUXT/ukXASYgwIzPeFXFzaSPASvUUOigLad ttW9CyvWtvvw17Rj4C9CrPGL099HT6TvK2QaryZ4IItOwoPga5xEVfapDlqZSTSPyWyH/2v7sOKjf 5Yf+fuiMZDA948l9PYa5aLfMISW+lSLhdnXygXwfj9eWL6DMEv051p3wnZ+HZYmVR5vif7IQdv+xW D4uARIbfw18Q57EXghwRojZ4lWEBnOUk42aWyS1fqIK8ufz5fnwOHgz7GDmf2Y3xIvYEDSf8Bwlkn AQeTMt5e0rmqzsQv+/mA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1octCO-006Reb-8h; Mon, 26 Sep 2022 18:51:24 +0000 Received: from mail-pl1-x635.google.com ([2607:f8b0:4864:20::635]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1octBr-006RIN-RS for linux-arm-kernel@lists.infradead.org; Mon, 26 Sep 2022 18:50:54 +0000 Received: by mail-pl1-x635.google.com with SMTP id x1so7062079plv.5 for ; Mon, 26 Sep 2022 11:50:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date; bh=lRlQkEGyVotDOVgVJrH2x+4l2jryHK0GCkRlRhyLnhU=; b=wNQjmt87soT1/9iOavumcWhdxLJRmPMW/Ex1HSaDbDYmyFFKqLTbfk3MxMIVF3/h+2 6r+N+caO4DyzpBpMl0zcVzBLaCM+NmRuuqmipB3zKX5h088QcM6jqUHIcSqjA0vaTR2h yPW5ooz9pjoc++gBhvJLObhUxv08wgY7qtiUMkr19WxtHQeXrCFiYHx3851B/1P5AdoQ kHoVB1XRCiiSj/Y6vwFavbjyY192VXrpUynzhzx48CitCJ/9OpuhPZMQjEfipvXDYujP KeJ2ALh31b/acF7AG6nuE3h7z/8ecfUtN5UM0oVrY2Nb6BsyHeO5rKaiijcKmrgaCyeC hwUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=lRlQkEGyVotDOVgVJrH2x+4l2jryHK0GCkRlRhyLnhU=; b=imxk35FDfax3zCJWX2rlHeEtEyez6xt+DJ/DrrGZHHfzoard1Zcne/6MK2NQrU2KCh HxCmLcFYAxTHA0ahP74O6yD5y6qjQdGvWQ2B3Z68QCi3vz7UVJqScKXfzeOgO3RF2Up3 f9vGLxO+ZgxgaAZTxrj4KrNbQvMb086ZWhYbSAwiyNKcpWno/7niMLl3NZIPuRFRMRA5 4A08/uuiNRfI+36L+FIQT8NG9yZgcP4aoDXycyl1/MhBkCz/w8IDJerk7txjdTjRqwr2 zDZb/9FD8YM1M1gqGo9TlEd+ZZub4Vbsnd+tC8kD7OHV0uc41ENCi5AJYoLDXb76AhpQ H8jw== X-Gm-Message-State: ACrzQf2wzO0iEVLadI14XJg/l80LAONqizxXyRcdsL8Gzzi0NmHuYZh0 Jpd5PXLYNVEP2Y9z8BVt5XU6R7W3KhEWBLB9wHg= X-Google-Smtp-Source: AMsMyM6J++Jq/n6Tnfq8CzvGKz64B+KbXGB62f9OfjkL7sI9zcmjBW7e/aO/O6KZ5Zz+zGyVI86+Kw== X-Received: by 2002:a17:902:da8f:b0:178:399b:89bb with SMTP id j15-20020a170902da8f00b00178399b89bbmr23612803plx.57.1664218249640; Mon, 26 Sep 2022 11:50:49 -0700 (PDT) Received: from localhost ([76.146.1.42]) by smtp.gmail.com with ESMTPSA id y4-20020a655a04000000b00439d071c110sm11083443pgs.43.2022.09.26.11.50.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Sep 2022 11:50:48 -0700 (PDT) From: Kevin Hilman To: =?utf-8?Q?P=C3=A9ter?= Ujfalusi , dmaengine@vger.kernel.org Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Nicolas Frayer Subject: Re: [PATCH 3/3] dma/ti: convert PSIL to be buildable as module In-Reply-To: <4c9f0284-f8d0-75e5-8bc9-944b040f9edb@gmail.com> References: <20220926181848.2917639-1-khilman@baylibre.com> <20220926181848.2917639-4-khilman@baylibre.com> <4c9f0284-f8d0-75e5-8bc9-944b040f9edb@gmail.com> Date: Mon, 26 Sep 2022 11:50:46 -0700 Message-ID: <7hfsgeezqx.fsf@baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220926_115051_928244_94C8DB24 X-CRM114-Status: GOOD ( 18.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org UMOpdGVyIFVqZmFsdXNpIDxwZXRlci51amZhbHVzaUBnbWFpbC5jb20+IHdyaXRlczoKCj4gSGkg S2V2aW4sCj4KPiBPbiA5LzI2LzIyIDIxOjE4LCBLZXZpbiBIaWxtYW4gd3JvdGU6Cj4+IG1hcCBz eW1ib2xzIG5lZWQgRVhQT1JUX1NZTUJPTCBhbmQgZmlsZXMgbmVlZCBNT0RVTEVfTElDRU5TRS4K Pj4gCj4+IFNpZ25lZC1vZmYtYnk6IEtldmluIEhpbG1hbiA8a2hpbG1hbkBiYXlsaWJyZS5jb20+ Cj4+IC0tLQo+PiAgZHJpdmVycy9kbWEvdGkvS2NvbmZpZyAgICAgICAgICB8IDMgKystCj4+ICBk cml2ZXJzL2RtYS90aS9rMy1wc2lsLWFtNjIuYyAgIHwgNCArKysrCj4+ICBkcml2ZXJzL2RtYS90 aS9rMy1wc2lsLWFtNjQuYyAgIHwgNCArKysrCj4+ICBkcml2ZXJzL2RtYS90aS9rMy1wc2lsLWFt NjU0LmMgIHwgNCArKysrCj4+ICBkcml2ZXJzL2RtYS90aS9rMy1wc2lsLWo3MjAwLmMgIHwgNCAr KysrCj4+ICBkcml2ZXJzL2RtYS90aS9rMy1wc2lsLWo3MjFlLmMgIHwgNCArKysrCj4+ICBkcml2 ZXJzL2RtYS90aS9rMy1wc2lsLWo3MjFzMi5jIHwgNCArKysrCj4+ICBkcml2ZXJzL2RtYS90aS9r My1wc2lsLmMgICAgICAgIHwgMiArKwo+PiAgOCBmaWxlcyBjaGFuZ2VkLCAyOCBpbnNlcnRpb25z KCspLCAxIGRlbGV0aW9uKC0pCj4+IAo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9kbWEvdGkvS2Nv bmZpZyBiL2RyaXZlcnMvZG1hL3RpL0tjb25maWcKPj4gaW5kZXggZjE5NmJlM2IyMjJmLi4yYWRj MmNjYTEwZTkgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZG1hL3RpL0tjb25maWcKPj4gKysrIGIv ZHJpdmVycy9kbWEvdGkvS2NvbmZpZwo+PiBAQCAtNTYsNyArNTYsOCBAQCBjb25maWcgVElfSzNf VURNQV9HTFVFX0xBWUVSCj4+ICAJICBJZiB1bnN1cmUsIHNheSBOLgo+PiAgCj4+ICBjb25maWcg VElfSzNfUFNJTAo+PiAtCWJvb2wKPj4gKyAgICAgICB0cmlzdGF0ZQo+PiArICAgICAgIGRlZmF1 bHQgVElfSzNfVURNQQo+PiAgCj4+ICBjb25maWcgVElfRE1BX0NST1NTQkFSCj4+ICAJYm9vbAo+ PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9kbWEvdGkvazMtcHNpbC1hbTYyLmMgYi9kcml2ZXJzL2Rt YS90aS9rMy1wc2lsLWFtNjIuYwo+PiBpbmRleCAyYjZmZDZlMzdjNjEuLjdjNGNhODVmNjhiMSAx MDA2NDQKPj4gLS0tIGEvZHJpdmVycy9kbWEvdGkvazMtcHNpbC1hbTYyLmMKPj4gKysrIGIvZHJp dmVycy9kbWEvdGkvazMtcHNpbC1hbTYyLmMKPj4gQEAgLTQsNiArNCw3IEBACj4+ICAgKi8KPj4g IAo+PiAgI2luY2x1ZGUgPGxpbnV4L2tlcm5lbC5oPgo+PiArI2luY2x1ZGUgPGxpbnV4L21vZHVs ZS5oPgo+PiAgCj4+ICAjaW5jbHVkZSAiazMtcHNpbC1wcml2LmgiCj4+ICAKPj4gQEAgLTE4NCwz ICsxODUsNiBAQCBzdHJ1Y3QgcHNpbF9lcF9tYXAgYW02Ml9lcF9tYXAgPSB7Cj4+ICAJLmRzdCA9 IGFtNjJfZHN0X2VwX21hcCwKPj4gIAkuZHN0X2NvdW50ID0gQVJSQVlfU0laRShhbTYyX2RzdF9l cF9tYXApLAo+PiAgfTsKPj4gK0VYUE9SVF9TWU1CT0xfR1BMKGFtNjJfZXBfbWFwKTsKPgo+IFdv dWxkbid0IGl0IGJlIGJldHRlciB0byBidWlsZCBvbmUgbW9kdWxlIChrMy1wc2lsLmtvKSBhbmQg bGluayBhbGwgdGhlCj4gcGxhdGZvcm0gbGlicyBpbnRvIHRoYXQ/Cj4gVGhleSBhcmUgdW5jb25k aXRpb25hbGx5IGJ1aWx0IGluIGFsbCBjYXNlcyBhbnl3YXlzIGFuZCBtYWtlcyB0aGUgbHNtb2QK PiB1bmRlciBjb250cm9sLgo+IEFuZCBubyBuZWVkIHRvIGV4cG9ydCB0aGVzZSBtYXBzIGF0IGFs bCBpcyBhIHBsdXMuCgpJIGd1ZXNzIHRoYXQncyBvbmUgb3B0aW9uLCBidXQgc2VlbXMgdG8gYmUg dG8gYmUgdGhlIHdyb25nIGRpcmVjdGlvbiBmb3IKYSBtb2R1bGFyIGtlcm5lbC4gIFRvIG1lLCBp dCBzZWVtcyBsaWtlIHRoZSBuZXh0IHN0ZXAgd291bGQgYmUgdG8gbWFrZQppdCBzbyBvbmx5IHRo ZSBTb0Mgc3BlY2lmaWMgbW9kdWxlIGlzIGxvYWRlZCBpbnN0ZWFkIG9mIGFsd2F5cyBsb2FkaW5n CnRoZW0gYWxsLgoKS2V2aW4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxA bGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK