From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [RFC PATCH 1/1] drm/exynos: Move platform drivers registration to module init Date: Tue, 18 Nov 2014 10:41:44 -0800 Message-ID: <7hh9xwxsev.fsf@deeprootsystems.com> References: <1416318821-7925-1-git-send-email-javier.martinez@collabora.co.uk> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from mail-pd0-f174.google.com ([209.85.192.174]:64114 "EHLO mail-pd0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753848AbaKRSlr (ORCPT ); Tue, 18 Nov 2014 13:41:47 -0500 Received: by mail-pd0-f174.google.com with SMTP id w10so5102173pde.33 for ; Tue, 18 Nov 2014 10:41:47 -0800 (PST) In-Reply-To: <1416318821-7925-1-git-send-email-javier.martinez@collabora.co.uk> (Javier Martinez Canillas's message of "Tue, 18 Nov 2014 14:53:41 +0100") Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Javier Martinez Canillas Cc: Inki Dae , Andrzej Hajda , Krzysztof Kozlowski , dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org Javier Martinez Canillas writes: > The Exynos DRM driver register its sub-devices platform drivers in > the probe function but after commit 43c0767 ("of/platform: Move > platform devices under /sys/devices/platform"), this is causing > a deadlock in __driver_attach(). Fix this by moving the platform > drivers registration to exynos_drm_init(). > > Suggested-by: Andrzej Hajda > Signed-off-by: Javier Martinez Canillas > --- > > This issue was reported by both Krzysztof Kozlowski [0] and Kevin Hilman [1]. > > Inki Dae said that he will fix it property by separating the Exynos DRM > driver in different sub-modules but I post this patch as RFC anyways so > others can test if this fixes their boot issue. It fixes the DRM deadlock, issue for me on exynos5800-peach-pi, but then it proceeds to panic in the workqueue code called by the asoc max98090 codec[1]. If I then disable CONFIG_SND_SOC_SNOW, I can get it to boot to a shell, but I still don't have display output. Is anyone at Samsung testing linux-next? If so, on what platforms? It would really be nice if your linux-next work was tested on these publically-available 542x/5800 platforms (peach-pi, peach-pit, odroid-xu3) which would also allow lots of others to help you test and validate. Kevin