From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [RFC PATCH v3 2/2] clk: exynos5420: Make sure MDMA0 clock is enabled during suspend Date: Tue, 31 Mar 2015 14:02:04 -0700 Message-ID: <7hiodg98z7.fsf@deeprootsystems.com> References: <1427730803-28635-1-git-send-email-javier.martinez@collabora.co.uk> <1427730803-28635-3-git-send-email-javier.martinez@collabora.co.uk> <551976F1.1000605@collabora.co.uk> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from mail-pa0-f52.google.com ([209.85.220.52]:36257 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753716AbbCaVCH (ORCPT ); Tue, 31 Mar 2015 17:02:07 -0400 Received: by padcy3 with SMTP id cy3so30628655pad.3 for ; Tue, 31 Mar 2015 14:02:07 -0700 (PDT) In-Reply-To: <551976F1.1000605@collabora.co.uk> (Javier Martinez Canillas's message of "Mon, 30 Mar 2015 18:16:49 +0200") Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Javier Martinez Canillas Cc: Tomasz Figa , Stephen Boyd , Mike Turquette , Sylwester Nawrocki , Kukjin Kim , Olof Johansson , Doug Anderson , Krzysztof Kozlowski , Tyler Baker , Abhilash Kesavan , Chanwoo Choi , linux-arm-kernel , "linux-samsung-soc@vger.kernel.org" , linux-kernel Javier Martinez Canillas writes: [...] > Unfortunately I don't fully understand why this clock needs to be > enabled. It would be good if someone at Samsung can explain in more > detail what the real problem really is. +1 Maybe Abhilash can shed some light here? We really should know *why* this is needed because having the fix in the clock driver just doesn't seem right. It seems like the DMA driver should be managing this clock. Kevin From mboxrd@z Thu Jan 1 00:00:00 1970 From: khilman@kernel.org (Kevin Hilman) Date: Tue, 31 Mar 2015 14:02:04 -0700 Subject: [RFC PATCH v3 2/2] clk: exynos5420: Make sure MDMA0 clock is enabled during suspend In-Reply-To: <551976F1.1000605@collabora.co.uk> (Javier Martinez Canillas's message of "Mon, 30 Mar 2015 18:16:49 +0200") References: <1427730803-28635-1-git-send-email-javier.martinez@collabora.co.uk> <1427730803-28635-3-git-send-email-javier.martinez@collabora.co.uk> <551976F1.1000605@collabora.co.uk> Message-ID: <7hiodg98z7.fsf@deeprootsystems.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Javier Martinez Canillas writes: [...] > Unfortunately I don't fully understand why this clock needs to be > enabled. It would be good if someone at Samsung can explain in more > detail what the real problem really is. +1 Maybe Abhilash can shed some light here? We really should know *why* this is needed because having the fix in the clock driver just doesn't seem right. It seems like the DMA driver should be managing this clock. Kevin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753783AbbCaVCK (ORCPT ); Tue, 31 Mar 2015 17:02:10 -0400 Received: from mail-pa0-f54.google.com ([209.85.220.54]:34305 "EHLO mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753724AbbCaVCH (ORCPT ); Tue, 31 Mar 2015 17:02:07 -0400 From: Kevin Hilman To: Javier Martinez Canillas Cc: Tomasz Figa , Stephen Boyd , Mike Turquette , Sylwester Nawrocki , Kukjin Kim , Olof Johansson , Doug Anderson , Krzysztof Kozlowski , Tyler Baker , Abhilash Kesavan , Chanwoo Choi , linux-arm-kernel , "linux-samsung-soc\@vger.kernel.org" , linux-kernel Subject: Re: [RFC PATCH v3 2/2] clk: exynos5420: Make sure MDMA0 clock is enabled during suspend References: <1427730803-28635-1-git-send-email-javier.martinez@collabora.co.uk> <1427730803-28635-3-git-send-email-javier.martinez@collabora.co.uk> <551976F1.1000605@collabora.co.uk> Date: Tue, 31 Mar 2015 14:02:04 -0700 In-Reply-To: <551976F1.1000605@collabora.co.uk> (Javier Martinez Canillas's message of "Mon, 30 Mar 2015 18:16:49 +0200") Message-ID: <7hiodg98z7.fsf@deeprootsystems.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Javier Martinez Canillas writes: [...] > Unfortunately I don't fully understand why this clock needs to be > enabled. It would be good if someone at Samsung can explain in more > detail what the real problem really is. +1 Maybe Abhilash can shed some light here? We really should know *why* this is needed because having the fix in the clock driver just doesn't seem right. It seems like the DMA driver should be managing this clock. Kevin