From: Kevin Hilman <khilman@baylibre.com>
To: "Markus Schneider-Pargmann" <msp@baylibre.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Tony Lindgren" <tony@atomide.com>,
"John Ogness" <john.ogness@linutronix.de>,
"Markus Schneider-Pargmann" <msp@baylibre.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Ronald Wahl" <ronald.wahl@raritan.com>,
"Thomas Richard" <thomas.richard@bootlin.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"Vignesh Raghavendra" <vigneshr@ti.com>
Cc: Vibhore Vardhan <vibhore@ti.com>, Dhruva Gole <d-gole@ti.com>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 3/5] serial: 8250: omap: Set wakeup capable, do not enable
Date: Tue, 30 Jul 2024 14:19:13 -0700 [thread overview]
Message-ID: <7hjzh260j2.fsf@baylibre.com> (raw)
In-Reply-To: <20240523075819.1285554-4-msp@baylibre.com>
Markus Schneider-Pargmann <msp@baylibre.com> writes:
> The driver sets wakeup enable by default. But not all uarts are meant to
> be wakeup enabled. Change the default to be wakeup capable but not
> enabled. The user can enable wakeup when needed.
In addition to the user enabling via sysfs, this driver should also look
for the `wakeup-source` DT property, and enable when that property is set.
> Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com>
Reviewed-by: Kevin Hilman <khilman@baylibre.com>
next prev parent reply other threads:[~2024-07-30 21:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-23 7:58 [PATCH 0/5] serial: 8250: omap: Add am62 wakeup support Markus Schneider-Pargmann
2024-05-23 7:58 ` [PATCH 1/5] dt-bindings: serial: 8250_omap: Add wakeup pinctrl state Markus Schneider-Pargmann
2024-05-28 16:01 ` Rob Herring (Arm)
2024-05-23 7:58 ` [PATCH 2/5] serial: 8250: omap: Remove unused wakeups_enabled Markus Schneider-Pargmann
2024-05-23 7:58 ` [PATCH 3/5] serial: 8250: omap: Set wakeup capable, do not enable Markus Schneider-Pargmann
2024-05-27 16:31 ` Andy Shevchenko
2024-07-30 19:33 ` Kevin Hilman
2024-07-30 21:19 ` Kevin Hilman [this message]
2024-05-23 7:58 ` [PATCH 4/5] serial: 8250: omap: Support wakeup pinctrl state Markus Schneider-Pargmann
2024-05-27 16:34 ` Andy Shevchenko
2024-07-30 21:16 ` Kevin Hilman
2024-05-23 7:58 ` [PATCH 5/5] serial: 8250: omap: Set wakeup pinctrl on suspend Markus Schneider-Pargmann
2024-07-30 21:22 ` Kevin Hilman
2024-05-23 19:07 ` [PATCH 0/5] serial: 8250: omap: Add am62 wakeup support Francesco Dolcini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7hjzh260j2.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=conor+dt@kernel.org \
--cc=d-gole@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=msp@baylibre.com \
--cc=robh@kernel.org \
--cc=ronald.wahl@raritan.com \
--cc=tglx@linutronix.de \
--cc=thomas.richard@bootlin.com \
--cc=tony@atomide.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vibhore@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.