From: Kevin Hilman <khilman@baylibre.com>
To: Niel Fourie <lusus@denx.de>, u-boot@lists.denx.de
Cc: Niel Fourie <lusus@denx.de>, Marek Vasut <marex@denx.de>,
Lukasz Majewski <lukma@denx.de>,
Ramon Fried <rfried.dev@gmail.com>
Subject: Re: [PATCH v2] usb: gadget: ether: split start/stop from init/halt
Date: Wed, 25 Jan 2023 14:50:17 -0800 [thread overview]
Message-ID: <7hk01agrfa.fsf@baylibre.com> (raw)
In-Reply-To: <20230120171518.896027-1-lusus@denx.de>
Niel Fourie <lusus@denx.de> writes:
> Split out _usb_eth_start() from _usb_eth_init() and
> usb_eth_stop() from _usb_eth_halt(). Now _usb_eth_init() only
> initialises and registers the gadget device, which _usb_eth_halt()
> reverses, and together are used for probing and removing the
> device. The _usb_eth_start() and _usb_eth_stop() functions connect
> and disconnect the gadget as expected by the start()/stop()
> callbacks.
>
> Previously the gadget device was probed on every start() and
> removed on every stop(), which is inconsistent with other DM_ETH
> drivers.
By suggestion from Marek, I was testing this patch and discovered that
it broke fastboot over USB support. With this patch applied on top of
v2022.10, I'm seeing:
=> fastboot 0
couldn't find an available UDC
g_dnl_register: failed!, error: -19
Kevin
next prev parent reply other threads:[~2023-01-25 22:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-20 17:15 [PATCH v2] usb: gadget: ether: split start/stop from init/halt Niel Fourie
2023-01-20 18:42 ` Marek Vasut
2023-01-23 11:26 ` Niel Fourie
2023-01-25 22:50 ` Kevin Hilman [this message]
2023-01-26 12:35 ` Niel Fourie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7hk01agrfa.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=lukma@denx.de \
--cc=lusus@denx.de \
--cc=marex@denx.de \
--cc=rfried.dev@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.