From: Kevin Hilman <khilman@baylibre.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Linux PM <linux-pm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>
Subject: Re: [PATCH] PM / Domains: defer dev_pm_domain_set() until genpd->attach_dev succeeds if present
Date: Tue, 11 Jul 2017 11:53:05 -0700 [thread overview]
Message-ID: <7hk23evm9a.fsf@baylibre.com> (raw)
In-Reply-To: <CAJZ5v0i42jjbm2M7fBjfPSu88gGz-Rxp3QBJM3uFggaN=8VkcA@mail.gmail.com> (Rafael J. Wysocki's message of "Tue, 4 Jul 2017 22:39:17 +0200")
"Rafael J. Wysocki" <rafael@kernel.org> writes:
> On Thu, Jun 29, 2017 at 8:00 PM, Sudeep Holla <sudeep.holla@arm.com> wrote:
>> If the genpd->attach_dev or genpd->power_on fails, genpd_dev_pm_attach
>> may return -EPROBE_DEFER initially. However genpd_alloc_dev_data sets
>> the PM domain for the device unconditionally.
>>
>> When subsequent attempts are made to call genpd_dev_pm_attach, it may
>> return -EEXISTS checking dev->pm_domain without re-attempting to call
>> attach_dev or power_on.
>>
>> platform_drv_probe then attempts to call drv->probe as the return value
>> -EEXIST != -EPROBE_DEFER, which may end up in a situation where the
>> device is accessed without it's power domain switched on.
>>
>> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
>> Cc: Kevin Hilman <khilman@kernel.org>
>> Cc: Ulf Hansson <ulf.hansson@linaro.org>
>> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
>
> Ulf, this looks like a genuine fix to me, any comments?
>
This looks like the right fix to me.
Acked-by: Kevin Hilman <khilman@baylibre.com>
next prev parent reply other threads:[~2017-07-11 18:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-29 18:00 [PATCH] PM / Domains: defer dev_pm_domain_set() until genpd->attach_dev succeeds if present Sudeep Holla
2017-07-04 20:39 ` Rafael J. Wysocki
2017-07-11 18:53 ` Kevin Hilman [this message]
2017-07-12 13:59 ` Ulf Hansson
2017-07-12 16:36 ` Sudeep Holla
2017-07-14 10:31 ` Sudeep Holla
2017-07-14 10:51 ` [PATCH v2] " Sudeep Holla
2017-07-14 22:06 ` Rafael J. Wysocki
2017-07-17 7:01 ` Ulf Hansson
2017-07-17 10:34 ` Sudeep Holla
2017-07-17 11:36 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7hk23evm9a.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=sudeep.holla@arm.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.