From: Kevin Hilman <khilman@baylibre.com>
To: Guillaume La Roque <glaroque@baylibre.com>,
marcel@holtmann.org, johan.hedberg@gmail.com,
linux-bluetooth@vger.kernel.org, devicetree@vger.kernel.org
Cc: netdev@vger.kernel.org, nsaenzjulienne@suse.de,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/2] bluetooth: hci_bcm: enable IRQ capability from devicetree
Date: Fri, 13 Dec 2019 09:14:57 -0800 [thread overview]
Message-ID: <7ho8wc87vy.fsf@baylibre.com> (raw)
In-Reply-To: <20191213150622.14162-3-glaroque@baylibre.com>
Guillaume La Roque <glaroque@baylibre.com> writes:
> Actually IRQ can be found from GPIO but all platforms don't support
> gpiod_to_irq, it's the case on amlogic chip.
> so to have possibility to use interrupt mode we need to add interrupts
> property in devicetree and support it in driver.
I would reword this slightly (leaving out the amlogic specifics):
"""
Add support for getting IRQ directly from DT instead of relying on
converting a GPIO to IRQ. This is needed for platforms with GPIO
controllers that that do not support gpiod_to_irq().
"""
Other than that, this looks good to me and now it's clear that it only
affects the DT path.
Reviewed-by: Kevin Hilman <khilman@baylibre.com>
Kevin
next prev parent reply other threads:[~2019-12-13 20:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-13 15:06 [PATCH v5 0/2] add support of interrupt for host wakeup from devicetree in BCM HCI driver Guillaume La Roque
2019-12-13 15:06 ` [PATCH v5 1/2] dt-bindings: net: bluetooth: add interrupts properties Guillaume La Roque
2019-12-13 16:19 ` Johan Hovold
2019-12-18 20:38 ` Rob Herring
2019-12-13 15:06 ` [PATCH v5 2/2] bluetooth: hci_bcm: enable IRQ capability from devicetree Guillaume La Roque
2019-12-13 17:14 ` Kevin Hilman [this message]
2019-12-17 7:43 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ho8wc87vy.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=glaroque@baylibre.com \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
--cc=nsaenzjulienne@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.