From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EC2FC32792 for ; Mon, 30 Sep 2019 15:34:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 395A620815 for ; Mon, 30 Sep 2019 15:34:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CGyhAzLn"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="ZOM/o25s" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 395A620815 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6+gv/tq3ftlkvAiOxQCXUdU1nZynSHerBXpNwGFDfSM=; b=CGyhAzLnoEgZyp 49YDAhgCa7NC/ujwC3KQgXCV+kqSerUh5GjxsaJ7QbMwGVe2E9yZXCM2GV4PEFuTEBKgcdU4MslvS kZgLgIZEtUfa59pN+LcTeXAjK421sBClqG+/sJx+ohNvorvwPa6R5nkukqbsoWJsIT77hvX2MSK0x o0dV/lVHET8OLq1R51QZkfLJh5+OWtp2xadpfBAmE4PY+go19toKQa64vgsKF6nwG4XetBgsDgkmL QfiSbmxTiyPT4VQJmH+rxBLFq5cWpwyCS5F/+8rbiBY+DpWh4C9MeckFc9eqlYW5iiNHZGVULoakt K/MUiToW1z3Sx3cJFYrA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iExgw-00074z-Oe; Mon, 30 Sep 2019 15:34:26 +0000 Received: from mail-pf1-x444.google.com ([2607:f8b0:4864:20::444]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iExgt-00074Z-KP for linux-amlogic@lists.infradead.org; Mon, 30 Sep 2019 15:34:25 +0000 Received: by mail-pf1-x444.google.com with SMTP id q7so5818854pfh.8 for ; Mon, 30 Sep 2019 08:34:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=5F08F4HtlDPyvY4r3+PCuN7SNxQH64MKcXi/kd7HCrE=; b=ZOM/o25sxvjMLKRKC3Zd9rAx0hvP1hljMPVRkriGdckO5c1A91PHJh2aCVswAY0hfm Z9d2+3JPNT3jJ++Tc/HA3L7SyJH4D0r0sfgBjqWhP5zpt+8otwCtBg5sX4vlJBmS/SuZ 5YNNFJzir4g9iS35zxDhQYo8JdrSR8dNmcjHW2Idowx7dqtnwQ5Sz1PEy251eYdg+d99 6lthotV8WxDf8zkxx1iEUo9ZoRY36KTswzYimcZUG5CAJ5wqrq03USkkzxteBV0gWX4i WInmhy7mc4CXiohXjvMKqi7zldss7UX2rYu/7RCCQXiIRF+Uc3tF77p2ySjypJKTIMGT 9HuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=5F08F4HtlDPyvY4r3+PCuN7SNxQH64MKcXi/kd7HCrE=; b=PnejuqGiBxiabtah8dYGCcs0h7wwIgneXSax6iXjshhBszzXBOqC/E3Q6pTCn6Nkxw ZNe9k4wF7Krn//Rs1kYECAKSAUPdwACYDJK8T6L6A5I5CG/PvRIk7ySVdWjz7zh0sG56 vJzWPLPnm0ooaw3IoqhGoQWf1CZEEVvD0CVnPXepQELkImFmXbNe3AuvGtN4w8zT/TNW juQ2pjVxqdOiDjNcRb6r1C0Cl1c4YgV7+y2Jeywtl3k+tnTwEh0EikcdtdbGSADhCeJZ 6IqLfbESvou3B44IfooNYrAS8zO58Fg1xqXPSVEm6FEp1plcvH3QlayNV6oOi+5SnLRC GgtA== X-Gm-Message-State: APjAAAXtHXbZ7P995llRevf/VDQBKFMQGW2gPVajH0IZ962cJMLFLtvy S/60dTj78JKRod/sa1jCo2nh2cc30FA= X-Google-Smtp-Source: APXvYqyOvb4d+aPS0cQERmHhssgzbMyfskBVAlx/Xeu3fPMFfwDEFTsiAILnSnwHN3omJUS1nvUcwA== X-Received: by 2002:a63:5652:: with SMTP id g18mr5896531pgm.283.1569857662965; Mon, 30 Sep 2019 08:34:22 -0700 (PDT) Received: from localhost (c-71-197-186-152.hsd1.wa.comcast.net. [71.197.186.152]) by smtp.gmail.com with ESMTPSA id d4sm12397930pjs.9.2019.09.30.08.34.22 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 30 Sep 2019 08:34:22 -0700 (PDT) From: Kevin Hilman To: Neil Armstrong , Kevin Hilman , dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm/meson: enable runtime PM In-Reply-To: References: <20190925193154.20732-1-khilman@kernel.org> Date: Mon, 30 Sep 2019 08:34:21 -0700 Message-ID: <7ho8z1g5mq.fsf@baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190930_083423_673292_87CFA49C X-CRM114-Status: GOOD ( 10.85 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-amlogic@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Neil Armstrong writes: > Hi Kevin, > > On 25/09/2019 21:31, Kevin Hilman wrote: >> From: Kevin Hilman >> >> On some SoCs, the VPU is in a power-domain and needs runtime PM >> enabled and used in order to keep the power domain on. >> >> Signed-off-by: Kevin Hilman >> --- >> drivers/gpu/drm/meson/meson_drv.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/drivers/gpu/drm/meson/meson_drv.c b/drivers/gpu/drm/meson/meson_drv.c >> index 2310c96fff46..256b6a0e9c6b 100644 >> --- a/drivers/gpu/drm/meson/meson_drv.c >> +++ b/drivers/gpu/drm/meson/meson_drv.c >> @@ -14,6 +14,7 @@ >> #include >> #include >> #include >> +#include >> >> #include >> #include >> @@ -274,6 +275,7 @@ static int meson_drv_bind_master(struct device *dev, bool has_components) >> >> /* Hardware Initialization */ >> >> + pm_runtime_get_sync(dev); >> meson_vpu_init(priv); >> meson_venc_init(priv); >> meson_vpp_init(priv); >> @@ -416,6 +418,7 @@ static int meson_drv_probe(struct platform_device *pdev) >> struct device_node *ep, *remote; >> int count = 0; >> >> + pm_runtime_enable(&pdev->dev); >> for_each_endpoint_of_node(np, ep) { >> remote = of_graph_get_remote_port_parent(ep); >> if (!remote || !of_device_is_available(remote)) { >> @@ -440,6 +443,7 @@ static int meson_drv_probe(struct platform_device *pdev) >> } >> >> /* If no output endpoints were available, simply bail out */ >> + pm_runtime_disable(&pdev->dev); >> return 0; >> }; >> >> > > I'll rather implement true runtime PM instead, While this is a minimum implementation, can you explain what you mean by "true" runtime PM? Kevin _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH] drm/meson: enable runtime PM Date: Mon, 30 Sep 2019 08:34:21 -0700 Message-ID: <7ho8z1g5mq.fsf@baylibre.com> References: <20190925193154.20732-1-khilman@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-pg1-x543.google.com (mail-pg1-x543.google.com [IPv6:2607:f8b0:4864:20::543]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7B66D6E47B for ; Mon, 30 Sep 2019 15:34:23 +0000 (UTC) Received: by mail-pg1-x543.google.com with SMTP id d26so2135269pgl.7 for ; Mon, 30 Sep 2019 08:34:23 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Neil Armstrong , Kevin Hilman , dri-devel@lists.freedesktop.org Cc: linux-amlogic@lists.infradead.org List-Id: dri-devel@lists.freedesktop.org TmVpbCBBcm1zdHJvbmcgPG5hcm1zdHJvbmdAYmF5bGlicmUuY29tPiB3cml0ZXM6Cgo+IEhpIEtl dmluLAo+Cj4gT24gMjUvMDkvMjAxOSAyMTozMSwgS2V2aW4gSGlsbWFuIHdyb3RlOgo+PiBGcm9t OiBLZXZpbiBIaWxtYW4gPGtoaWxtYW5AYmF5bGlicmUuY29tPgo+PiAKPj4gT24gc29tZSBTb0Nz LCB0aGUgVlBVIGlzIGluIGEgcG93ZXItZG9tYWluIGFuZCBuZWVkcyBydW50aW1lIFBNCj4+IGVu YWJsZWQgYW5kIHVzZWQgaW4gb3JkZXIgdG8ga2VlcCB0aGUgcG93ZXIgZG9tYWluIG9uLgo+PiAK Pj4gU2lnbmVkLW9mZi1ieTogS2V2aW4gSGlsbWFuIDxraGlsbWFuQGJheWxpYnJlLmNvbT4KPj4g LS0tCj4+ICBkcml2ZXJzL2dwdS9kcm0vbWVzb24vbWVzb25fZHJ2LmMgfCA0ICsrKysKPj4gIDEg ZmlsZSBjaGFuZ2VkLCA0IGluc2VydGlvbnMoKykKPj4gCj4+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vbWVzb24vbWVzb25fZHJ2LmMgYi9kcml2ZXJzL2dwdS9kcm0vbWVzb24vbWVzb25f ZHJ2LmMKPj4gaW5kZXggMjMxMGM5NmZmZjQ2Li4yNTZiNmEwZTljNmIgMTAwNjQ0Cj4+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9tZXNvbi9tZXNvbl9kcnYuYwo+PiArKysgYi9kcml2ZXJzL2dwdS9k cm0vbWVzb24vbWVzb25fZHJ2LmMKPj4gQEAgLTE0LDYgKzE0LDcgQEAKPj4gICNpbmNsdWRlIDxs aW51eC9wbGF0Zm9ybV9kZXZpY2UuaD4KPj4gICNpbmNsdWRlIDxsaW51eC9jb21wb25lbnQuaD4K Pj4gICNpbmNsdWRlIDxsaW51eC9vZl9ncmFwaC5oPgo+PiArI2luY2x1ZGUgPGxpbnV4L3BtX3J1 bnRpbWUuaD4KPj4gIAo+PiAgI2luY2x1ZGUgPGRybS9kcm1QLmg+Cj4+ICAjaW5jbHVkZSA8ZHJt L2RybV9hdG9taWMuaD4KPj4gQEAgLTI3NCw2ICsyNzUsNyBAQCBzdGF0aWMgaW50IG1lc29uX2Ry dl9iaW5kX21hc3RlcihzdHJ1Y3QgZGV2aWNlICpkZXYsIGJvb2wgaGFzX2NvbXBvbmVudHMpCj4+ ICAKPj4gIAkvKiBIYXJkd2FyZSBJbml0aWFsaXphdGlvbiAqLwo+PiAgCj4+ICsJcG1fcnVudGlt ZV9nZXRfc3luYyhkZXYpOwo+PiAgCW1lc29uX3ZwdV9pbml0KHByaXYpOwo+PiAgCW1lc29uX3Zl bmNfaW5pdChwcml2KTsKPj4gIAltZXNvbl92cHBfaW5pdChwcml2KTsKPj4gQEAgLTQxNiw2ICs0 MTgsNyBAQCBzdGF0aWMgaW50IG1lc29uX2Rydl9wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNl ICpwZGV2KQo+PiAgCXN0cnVjdCBkZXZpY2Vfbm9kZSAqZXAsICpyZW1vdGU7Cj4+ICAJaW50IGNv dW50ID0gMDsKPj4gIAo+PiArCXBtX3J1bnRpbWVfZW5hYmxlKCZwZGV2LT5kZXYpOwo+PiAgCWZv cl9lYWNoX2VuZHBvaW50X29mX25vZGUobnAsIGVwKSB7Cj4+ICAJCXJlbW90ZSA9IG9mX2dyYXBo X2dldF9yZW1vdGVfcG9ydF9wYXJlbnQoZXApOwo+PiAgCQlpZiAoIXJlbW90ZSB8fCAhb2ZfZGV2 aWNlX2lzX2F2YWlsYWJsZShyZW1vdGUpKSB7Cj4+IEBAIC00NDAsNiArNDQzLDcgQEAgc3RhdGlj IGludCBtZXNvbl9kcnZfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPj4gIAl9 Cj4+ICAKPj4gIAkvKiBJZiBubyBvdXRwdXQgZW5kcG9pbnRzIHdlcmUgYXZhaWxhYmxlLCBzaW1w bHkgYmFpbCBvdXQgKi8KPj4gKwlwbV9ydW50aW1lX2Rpc2FibGUoJnBkZXYtPmRldik7Cj4+ICAJ cmV0dXJuIDA7Cj4+ICB9Owo+PiAgCj4+IAo+Cj4gSSdsbCByYXRoZXIgaW1wbGVtZW50IHRydWUg cnVudGltZSBQTSBpbnN0ZWFkLAoKV2hpbGUgdGhpcyBpcyBhIG1pbmltdW0gaW1wbGVtZW50YXRp b24sIGNhbiB5b3UgZXhwbGFpbiB3aGF0IHlvdSBtZWFuIGJ5CiJ0cnVlIiBydW50aW1lIFBNPwoK S2V2aW4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJp LWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs