From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH v8 3/5] amba: Don't unprepare the clocks if device driver wants IRQ safe runtime PM Date: Mon, 03 Nov 2014 09:17:08 -0800 Message-ID: <7hoasoi4q3.fsf@deeprootsystems.com> References: <1413795888-18559-1-git-send-email-k.kozlowski@samsung.com> <1413795888-18559-4-git-send-email-k.kozlowski@samsung.com> <1479283.dvHduzBoyf@vostro.rjw.lan> <20141101005514.GY27405@n2100.arm.linux.org.uk> <20141101010113.GA3831@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <20141101010113.GA3831@n2100.arm.linux.org.uk> (Russell King's message of "Sat, 1 Nov 2014 01:01:13 +0000") Sender: linux-doc-owner@vger.kernel.org To: Russell King - ARM Linux Cc: "Rafael J. Wysocki" , Krzysztof Kozlowski , Len Brown , Pavel Machek , Jonathan Corbet , Dan Williams , Vinod Koul , Ulf Hansson , Alan Stern , linux-pm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, Lars-Peter Clausen , Michal Simek , Kyungmin Park , Marek Szyprowski , Bartlomiej Zolnierkiewicz List-Id: linux-pm@vger.kernel.org Russell King - ARM Linux writes: [...] > Would another possible solution be to remember the irq-safeness in the > suspend handler, and use that in the resume handler? Resume should > /always/ undo what the suspend handler previously did wrt clk API stuff. This seems more reasonable to me. Currently, the setting of irq_safe-ness is permanent (there's no exposed API to unset it after you set it.) so assuming it to be the same across suspend resume is a safe assumption. Kevin