All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@linaro.org>
To: Nicolas Pitre <nicolas.pitre@linaro.org>
Cc: Abhilash Kesavan <kesavan.abhilash@gmail.com>,
	Doug Anderson <dianders@google.com>,
	linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
	"Turquette, Mike" <mturquette@linaro.org>,
	Tushar Behera <trblinux@gmail.com>,
	Thomas Abraham <thomas.abraham@linaro.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	Olof Johansson <olof@lixom.net>,
	Sonny Rao <sonnyrao@chromium.org>,
	Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
	Arun Kumar <arun.kk@samsung.com>
Subject: Re: Problems booting exynos5420 with >1 CPU
Date: Mon, 09 Jun 2014 13:27:51 -0700	[thread overview]
Message-ID: <7hoay1rfp4.fsf@paris.lan> (raw)
In-Reply-To: <alpine.LFD.2.11.1406062340480.25775@knanqh.ubzr> (Nicolas Pitre's message of "Sat, 7 Jun 2014 12:10:27 -0400 (EDT)")

Nicolas Pitre <nicolas.pitre@linaro.org> writes:

> On Sat, 7 Jun 2014, Abhilash Kesavan wrote:
>
>> Hi Nicolas,
>> 
>> The first man of the incoming cluster enables its snoops via the
>> power_up_setup function. During secondary boot-up, this does not occur
>> for the boot cluster. Hence, I enable the snoops for the boot cluster
>> as a one-time setup from the u-boot prompt. After secondary boot-up
>> there is no modification that I do.
>
> OK that's good.
>
>> Where should this be ideally done ?
>
> If I remember correctly, the CCI can be safely activated only when the 
> cache is disabled.  So that means the CCI should ideally be turned on 
> for the boot cluster (and *only* for the boot CPU) by the bootloader.
>
> Now... If you _really_ prefer to do it from the kernel to avoid 
> difficulties with bootloader updates, then it should be possible to do 
> it from the kernel by temporarily turning the cache off.  This is not a 
> small thing but the MCPM infrastructure can be leveraged.  Here's what I 
> tried on a TC2 which might just work for you as well:

FWIW, I dropped the u-boot hack I was using to enable CCI and tested
this patch (with a cut/paste of the TC2 specific stuff into
mach-exynos/mcpm-exynos.c) along with Doug's patch[1] and 
and confirm that all 8 cores boot up on the Chromebook2 using linux-next.

Kevin

[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2014-June/262440.html

WARNING: multiple messages have this Message-ID (diff)
From: khilman@linaro.org (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: Problems booting exynos5420 with >1 CPU
Date: Mon, 09 Jun 2014 13:27:51 -0700	[thread overview]
Message-ID: <7hoay1rfp4.fsf@paris.lan> (raw)
In-Reply-To: <alpine.LFD.2.11.1406062340480.25775@knanqh.ubzr> (Nicolas Pitre's message of "Sat, 7 Jun 2014 12:10:27 -0400 (EDT)")

Nicolas Pitre <nicolas.pitre@linaro.org> writes:

> On Sat, 7 Jun 2014, Abhilash Kesavan wrote:
>
>> Hi Nicolas,
>> 
>> The first man of the incoming cluster enables its snoops via the
>> power_up_setup function. During secondary boot-up, this does not occur
>> for the boot cluster. Hence, I enable the snoops for the boot cluster
>> as a one-time setup from the u-boot prompt. After secondary boot-up
>> there is no modification that I do.
>
> OK that's good.
>
>> Where should this be ideally done ?
>
> If I remember correctly, the CCI can be safely activated only when the 
> cache is disabled.  So that means the CCI should ideally be turned on 
> for the boot cluster (and *only* for the boot CPU) by the bootloader.
>
> Now... If you _really_ prefer to do it from the kernel to avoid 
> difficulties with bootloader updates, then it should be possible to do 
> it from the kernel by temporarily turning the cache off.  This is not a 
> small thing but the MCPM infrastructure can be leveraged.  Here's what I 
> tried on a TC2 which might just work for you as well:

FWIW, I dropped the u-boot hack I was using to enable CCI and tested
this patch (with a cut/paste of the TC2 specific stuff into
mach-exynos/mcpm-exynos.c) along with Doug's patch[1] and 
and confirm that all 8 cores boot up on the Chromebook2 using linux-next.

Kevin

[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2014-June/262440.html

  parent reply	other threads:[~2014-06-09 20:27 UTC|newest]

Thread overview: 102+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-06  1:08 Problems booting exynos5420 with >1 CPU Doug Anderson
2014-06-06  1:08 ` Doug Anderson
2014-06-06  4:38 ` Tushar Behera
2014-06-06  4:38   ` Tushar Behera
2014-06-06 17:17   ` Doug Anderson
2014-06-06 17:17     ` Doug Anderson
2014-06-06 17:36     ` Abhilash Kesavan
2014-06-06 17:36       ` Abhilash Kesavan
2014-06-06 18:02       ` Doug Anderson
2014-06-06 18:02         ` Doug Anderson
2014-06-06 18:12         ` Abhilash Kesavan
2014-06-06 18:12           ` Abhilash Kesavan
2014-06-06 18:20           ` Doug Anderson
2014-06-06 18:20             ` Doug Anderson
2014-06-06 18:31             ` Abhilash Kesavan
2014-06-06 18:31               ` Abhilash Kesavan
2014-06-06 18:56               ` Doug Anderson
2014-06-06 18:56                 ` Doug Anderson
2014-06-06 19:09                 ` Abhilash Kesavan
2014-06-06 19:09                   ` Abhilash Kesavan
2014-06-06 19:12                   ` Abhilash Kesavan
2014-06-06 19:12                     ` Abhilash Kesavan
2014-06-06 20:49                   ` Doug Anderson
2014-06-06 20:49                     ` Doug Anderson
2014-06-06 21:01                     ` Russell King - ARM Linux
2014-06-06 21:01                       ` Russell King - ARM Linux
2014-06-06 21:12                       ` Doug Anderson
2014-06-06 21:12                         ` Doug Anderson
2014-06-06 21:44                     ` Doug Anderson
2014-06-06 21:44                       ` Doug Anderson
2014-06-06 20:37             ` Olof Johansson
2014-06-06 20:37               ` Olof Johansson
2014-06-06 20:46               ` Abhilash Kesavan
2014-06-06 20:46                 ` Abhilash Kesavan
2014-06-06 21:01                 ` Olof Johansson
2014-06-06 21:01                   ` Olof Johansson
2014-06-06 21:06                   ` Abhilash Kesavan
2014-06-06 21:06                     ` Abhilash Kesavan
2014-06-06 21:34                   ` Nicolas Pitre
2014-06-06 21:34                     ` Nicolas Pitre
2014-06-06 21:49                     ` Olof Johansson
2014-06-06 21:49                       ` Olof Johansson
2014-06-06 21:59                       ` Doug Anderson
2014-06-06 21:59                         ` Doug Anderson
2014-06-06 22:38                         ` Nicolas Pitre
2014-06-06 22:38                           ` Nicolas Pitre
2014-06-06 23:03                           ` Doug Anderson
2014-06-06 23:03                             ` Doug Anderson
2014-06-06 22:17                       ` Nicolas Pitre
2014-06-06 22:17                         ` Nicolas Pitre
2014-06-06 21:48       ` Nicolas Pitre
2014-06-06 21:48         ` Nicolas Pitre
2014-06-07  3:25         ` Abhilash Kesavan
2014-06-07  3:25           ` Abhilash Kesavan
2014-06-07 16:10           ` Nicolas Pitre
2014-06-07 16:10             ` Nicolas Pitre
2014-06-07 17:56             ` Lorenzo Pieralisi
2014-06-07 17:56               ` Lorenzo Pieralisi
2014-06-07 20:06               ` Nicolas Pitre
2014-06-07 20:06                 ` Nicolas Pitre
2014-06-07 22:36                 ` Lorenzo Pieralisi
2014-06-07 22:36                   ` Lorenzo Pieralisi
2014-06-07 23:53                   ` Olof Johansson
2014-06-07 23:53                     ` Olof Johansson
2014-06-08  0:19                     ` Russell King - ARM Linux
2014-06-08  0:19                       ` Russell King - ARM Linux
2014-06-08  2:52                       ` Olof Johansson
2014-06-08  2:52                         ` Olof Johansson
2014-06-08 18:26                       ` Nicolas Pitre
2014-06-08 18:26                         ` Nicolas Pitre
2014-06-08 18:29                         ` Russell King - ARM Linux
2014-06-08 18:29                           ` Russell King - ARM Linux
2014-06-08 18:55                           ` Nicolas Pitre
2014-06-08 18:55                             ` Nicolas Pitre
2014-06-08 19:02                             ` Russell King - ARM Linux
2014-06-08 19:02                               ` Russell King - ARM Linux
2014-06-08 12:45                     ` Lorenzo Pieralisi
2014-06-08 12:45                       ` Lorenzo Pieralisi
2014-06-08 14:34                       ` Russell King - ARM Linux
2014-06-08 14:34                         ` Russell King - ARM Linux
2014-06-08 17:53                       ` Nicolas Pitre
2014-06-08 17:53                         ` Nicolas Pitre
2014-06-09 20:47                         ` Kevin Hilman
2014-06-09 20:47                           ` Kevin Hilman
2014-06-09 22:26                           ` Lorenzo Pieralisi
2014-06-09 22:26                             ` Lorenzo Pieralisi
2014-06-10  4:25                             ` Nicolas Pitre
2014-06-10  4:25                               ` Nicolas Pitre
2014-06-10  9:19                               ` Lorenzo Pieralisi
2014-06-10  9:19                                 ` Lorenzo Pieralisi
2014-06-10 14:14                               ` Catalin Marinas
2014-06-10 14:14                                 ` Catalin Marinas
2014-06-10 16:49                                 ` Nicolas Pitre
2014-06-10 16:49                                   ` Nicolas Pitre
2014-06-10 17:42                                   ` Catalin Marinas
2014-06-10 17:42                                     ` Catalin Marinas
2014-06-10 19:15                                     ` Nicolas Pitre
2014-06-10 19:15                                       ` Nicolas Pitre
2014-06-09 20:27             ` Kevin Hilman [this message]
2014-06-09 20:27               ` Kevin Hilman
2014-06-09 20:35               ` Doug Anderson
2014-06-09 20:35                 ` Doug Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7hoay1rfp4.fsf@paris.lan \
    --to=khilman@linaro.org \
    --cc=arun.kk@samsung.com \
    --cc=dianders@google.com \
    --cc=javier.martinez@collabora.co.uk \
    --cc=kesavan.abhilash@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=mturquette@linaro.org \
    --cc=nicolas.pitre@linaro.org \
    --cc=olof@lixom.net \
    --cc=sonnyrao@chromium.org \
    --cc=thomas.abraham@linaro.org \
    --cc=trblinux@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.