From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B22A3C2D0C5 for ; Mon, 9 Dec 2019 22:56:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 83579206D5 for ; Mon, 9 Dec 2019 22:56:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bCcQJfvA"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="JgkAL/tQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 83579206D5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uUy6oAPAH+OlIdw6yPTlmLBRld6SfuZsRA107fxM5U0=; b=bCcQJfvAPwmI2U glRWje9HbeC38uBALmhDE4YUP3Tjz34LIewf3wtX7d8+otXnyaGUipqDK/SNPwaWWk3LENJR+u/lg qVC4I5g7pbLAm+eDeLWoxbTvaYFv6ZnGD1037m58a9HZRaPvk9vFt7yIrkhCTqzPiTApB4hO4adgu s5wRQ1A/k6ZUWYxKudrLZWggNFUS4QuTvbCbVTGkgXs6VX9q1zmaNCseVYMcZIEx5InQyX4AD3YRW GW6qibv1rX332ULYHXfk4uNGtPKhE3uvXo/poh+qyJLczN0O37esll8sH6edhtk35VAexI0+rwFpt cDh2DWPIFAnTAfPlljrQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ieRxM-0007sU-QX; Mon, 09 Dec 2019 22:56:44 +0000 Received: from mail-pj1-x1042.google.com ([2607:f8b0:4864:20::1042]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ieRxC-0007jE-SB for linux-amlogic@lists.infradead.org; Mon, 09 Dec 2019 22:56:36 +0000 Received: by mail-pj1-x1042.google.com with SMTP id v93so6525689pjb.6 for ; Mon, 09 Dec 2019 14:56:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=A4KHxg3gak/AwtAzed2CDRcu2q9WfrU2oLQqZp0iE2c=; b=JgkAL/tQtnHUIJMXDnJ5JRXCF1Z71qc3TDDuhsTpEFP3RllanM9RKF62rKGTwwyE/r 3F+sOGcm/Qoo6PW/gV1WjGbEzl/FeQLN+9Cq8B6o/Q5lXLaIFwTagn+oFLmSHZSxT5wq b6JzhAPMN4dgoOvUd1T3L/akyP5q6rTfPhBp8ysDtUbavt46I8knRWQ1TyRgkUNuONAt qVaaz5V4bS8bcd0C+ZgUiZqe9VyiD+g9s7SdS3JyZKfqnWVaMR7XIgdMTaMdsMH6huO/ MRbO40lHiN8iUZ5O6HRQubJqB+jrkEfqlDhDNoF58bhwN74s2mubGrtzDOFQSagWQg9K 07zQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=A4KHxg3gak/AwtAzed2CDRcu2q9WfrU2oLQqZp0iE2c=; b=Lbu6Z9ccyNgSO11HUBzqPQCD445+L3vq/GC3j835ufI5eGsHBYN2TS/f8ugYXrlPkt TQIZ7ZWuEtBZF1GG9syGhhuGqGxAcd71870fwHKB0Vn7jQhUlbaOT26NsqAO6JwbPvog Wv0Ohy1X4fl9yMWM4/X0X3tZz9+6X3JdtyxIyP7f8eZzGtYYyMez/i6U2892wtP4V+Am 0MlA0urKXU3bd52DNVMN57VGiG3jR272xpSv3tiN7ULjzlJCbdIi7a8s+0gkwl1JM3qj 6MOKOmFAeeVfUERM4sA3nwF4ZJY1z0QRDYaaU4WilspaA9he6OAuvI/bElyegWnU8OCi Z+Sw== X-Gm-Message-State: APjAAAXbKBSXc0Fvj0Gigi4eQmq7G5Ge2jHT6vlci+xtzQAskXf/6NT1 26wJhJ3gDworkgUEwSSs8eaqMg== X-Google-Smtp-Source: APXvYqwfy57KUmDE1VA2LS08T92dACffdsdnOJYy9Qvwq4eLq3TN5C71lFIUbtBnAecTSV5jsNQ1Bg== X-Received: by 2002:a17:902:7884:: with SMTP id q4mr30505852pll.285.1575932193897; Mon, 09 Dec 2019 14:56:33 -0800 (PST) Received: from localhost (c-71-197-186-152.hsd1.wa.comcast.net. [71.197.186.152]) by smtp.gmail.com with ESMTPSA id g19sm504235pfh.134.2019.12.09.14.56.33 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 09 Dec 2019 14:56:33 -0800 (PST) From: Kevin Hilman To: Xingyu Chen , Neil Armstrong , Martin Blumenstingl Subject: Re: [PATCH] arm64: dts: a1: add saradc controller In-Reply-To: <1575358332-44866-1-git-send-email-xingyu.chen@amlogic.com> References: <1575358332-44866-1-git-send-email-xingyu.chen@amlogic.com> Date: Mon, 09 Dec 2019 14:56:32 -0800 Message-ID: <7hpngxqfa7.fsf@baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191209_145634_915390_6D44B1B3 X-CRM114-Status: GOOD ( 11.98 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Qianggui Song , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jianxin Pan , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Jian Hu , Xingyu Chen , linux-amlogic@lists.infradead.org, Jonathan Cameron , Jerome Brunet Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Xingyu Chen writes: > The saradc controller in Meson-A1 is the same as the Meson-G12 series SoCs, > so we use the same compatible string. > > Signed-off-by: Xingyu Chen > > --- > This patch is based on A1 clock patchset at [0]. > > [0] https://lore.kernel.org/linux-amlogic/20191129144605.182774-1-jian.hu@amlogic.com > --- > arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi > index 7210ad0..cad1756 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi > @@ -93,6 +93,21 @@ > clock-names = "xtal", "pclk", "baud"; > status = "disabled"; > }; > + > + saradc: adc@2c00 { > + compatible = "amlogic,meson-g12a-saradc", > + "amlogic,meson-saradc"; > + reg = <0x0 0x2c00 0x0 0x48>; Why 0x48 here? AXG uses 0x38 and you're not adding any more registers to this driver. Kevin _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF94EC2BD09 for ; Mon, 9 Dec 2019 22:56:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 97B5D207FF for ; Mon, 9 Dec 2019 22:56:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="JgkAL/tQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727553AbfLIW4g (ORCPT ); Mon, 9 Dec 2019 17:56:36 -0500 Received: from mail-pj1-f68.google.com ([209.85.216.68]:37414 "EHLO mail-pj1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727700AbfLIW4e (ORCPT ); Mon, 9 Dec 2019 17:56:34 -0500 Received: by mail-pj1-f68.google.com with SMTP id ep17so6524635pjb.4 for ; Mon, 09 Dec 2019 14:56:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=A4KHxg3gak/AwtAzed2CDRcu2q9WfrU2oLQqZp0iE2c=; b=JgkAL/tQtnHUIJMXDnJ5JRXCF1Z71qc3TDDuhsTpEFP3RllanM9RKF62rKGTwwyE/r 3F+sOGcm/Qoo6PW/gV1WjGbEzl/FeQLN+9Cq8B6o/Q5lXLaIFwTagn+oFLmSHZSxT5wq b6JzhAPMN4dgoOvUd1T3L/akyP5q6rTfPhBp8ysDtUbavt46I8knRWQ1TyRgkUNuONAt qVaaz5V4bS8bcd0C+ZgUiZqe9VyiD+g9s7SdS3JyZKfqnWVaMR7XIgdMTaMdsMH6huO/ MRbO40lHiN8iUZ5O6HRQubJqB+jrkEfqlDhDNoF58bhwN74s2mubGrtzDOFQSagWQg9K 07zQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=A4KHxg3gak/AwtAzed2CDRcu2q9WfrU2oLQqZp0iE2c=; b=UtRCdEKA9eCxP9pt+Vph548N5zlb69vKOrokGskvkqNxF6861TX4up+r4cMgFuiZO8 cLeNYKiE8tM42sf4qcCmOaq0QkVzrHh8DQACsoI9qlwqeq3hBg3qquPWl7pa1lcCrCs9 vAKhODxIj2LiahDFKCiciVtlihSoCNPCY79q+URCnHVQLIThx/gpYBRSIsMdtIwZydWe fQcfsOgZCMVMy1gHHgOetqDwj95Y5xdYsLqdaaxREfGmcl0vChQFtfSZeX9d6ZBRdyVU vgbh2aoIGItz9PNuYvAO5pfz1K9KvKBNcIW6wnVrRrN8TI+fSNQeNnI6LVktaXKiF/Oh b5lw== X-Gm-Message-State: APjAAAXwLfJtDYNjo/HjdJ3mWOZam+1D5RBUPXUNkA/jF+kAm7ykVEQK HvXhEXzWuRNHwg360bcLBWY1XQ== X-Google-Smtp-Source: APXvYqwfy57KUmDE1VA2LS08T92dACffdsdnOJYy9Qvwq4eLq3TN5C71lFIUbtBnAecTSV5jsNQ1Bg== X-Received: by 2002:a17:902:7884:: with SMTP id q4mr30505852pll.285.1575932193897; Mon, 09 Dec 2019 14:56:33 -0800 (PST) Received: from localhost (c-71-197-186-152.hsd1.wa.comcast.net. [71.197.186.152]) by smtp.gmail.com with ESMTPSA id g19sm504235pfh.134.2019.12.09.14.56.33 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 09 Dec 2019 14:56:33 -0800 (PST) From: Kevin Hilman To: Xingyu Chen , Neil Armstrong , Martin Blumenstingl Cc: Xingyu Chen , Rob Herring , Jonathan Cameron , Jerome Brunet , Qianggui Song , Jianxin Pan , Jian Hu , linux-iio@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH] arm64: dts: a1: add saradc controller In-Reply-To: <1575358332-44866-1-git-send-email-xingyu.chen@amlogic.com> References: <1575358332-44866-1-git-send-email-xingyu.chen@amlogic.com> Date: Mon, 09 Dec 2019 14:56:32 -0800 Message-ID: <7hpngxqfa7.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Xingyu Chen writes: > The saradc controller in Meson-A1 is the same as the Meson-G12 series SoCs, > so we use the same compatible string. > > Signed-off-by: Xingyu Chen > > --- > This patch is based on A1 clock patchset at [0]. > > [0] https://lore.kernel.org/linux-amlogic/20191129144605.182774-1-jian.hu@amlogic.com > --- > arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi > index 7210ad0..cad1756 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi > @@ -93,6 +93,21 @@ > clock-names = "xtal", "pclk", "baud"; > status = "disabled"; > }; > + > + saradc: adc@2c00 { > + compatible = "amlogic,meson-g12a-saradc", > + "amlogic,meson-saradc"; > + reg = <0x0 0x2c00 0x0 0x48>; Why 0x48 here? AXG uses 0x38 and you're not adding any more registers to this driver. Kevin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05021C2BD09 for ; Mon, 9 Dec 2019 22:56:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C89C12071E for ; Mon, 9 Dec 2019 22:56:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Bq3NNJOS"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="JgkAL/tQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C89C12071E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=90Cpl1XSNaaAAkOA1Fed/2JrxnHsARPVbEP90msUgZ4=; b=Bq3NNJOSvkVrDL immq+LHtdT6GZ1GIgAICPVcJrft8jiJtLUWCKeKhUIeeMBR17wT5YxbTvWwE7x+e67EinwMS49Hhm 1ws3R7lni8VasybWNI2ltlg1RAof5djxxGmE29fIkQ2NyBmQRIgtC3XRLv88+NGbPubpivV449Djp +ymNj+ULUbndhtwCx3ihrTN0VV+nfKEw2KX5+d+a4qPrMgmfL5Jrth/zv2uqs3FaqtU3oeceeWV+t /bXpgwZe7g4ENhgmECIV52t+eWz/KLT3HDyrTT8nuDTrFcdacOyLnx/TAzcLLoorVeNtoo2IAEMy/ TN8gn3h1DvS0XnEwPbRg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ieRxG-0007kN-7S; Mon, 09 Dec 2019 22:56:38 +0000 Received: from mail-pl1-x642.google.com ([2607:f8b0:4864:20::642]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ieRxC-0007jF-SA for linux-arm-kernel@lists.infradead.org; Mon, 09 Dec 2019 22:56:36 +0000 Received: by mail-pl1-x642.google.com with SMTP id w7so6412172plz.12 for ; Mon, 09 Dec 2019 14:56:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=A4KHxg3gak/AwtAzed2CDRcu2q9WfrU2oLQqZp0iE2c=; b=JgkAL/tQtnHUIJMXDnJ5JRXCF1Z71qc3TDDuhsTpEFP3RllanM9RKF62rKGTwwyE/r 3F+sOGcm/Qoo6PW/gV1WjGbEzl/FeQLN+9Cq8B6o/Q5lXLaIFwTagn+oFLmSHZSxT5wq b6JzhAPMN4dgoOvUd1T3L/akyP5q6rTfPhBp8ysDtUbavt46I8knRWQ1TyRgkUNuONAt qVaaz5V4bS8bcd0C+ZgUiZqe9VyiD+g9s7SdS3JyZKfqnWVaMR7XIgdMTaMdsMH6huO/ MRbO40lHiN8iUZ5O6HRQubJqB+jrkEfqlDhDNoF58bhwN74s2mubGrtzDOFQSagWQg9K 07zQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=A4KHxg3gak/AwtAzed2CDRcu2q9WfrU2oLQqZp0iE2c=; b=VDUBkSr++VlyYfbQWhv8jbdM2Ib6BIi0f4fb6x8uzsWqPYiFixF8jlZ27C/8JDysea v/U+fzbLkMmR9mnZ3q1pw/rfLeq9rMH50sqLtJTjo4tGdQbU0iLnuh3UZJDmBh/+aUEh 6ZaQEdoXI8sKZJ7CNli8CNcAXjF/rdwaoyUMrs/NtHzoSq6ZfXjvMJQcAi0R0WDtLgbC j/X5SKNv9RI0ol8qBmTa4dKB0Wyk9n0QOw4lXu36T5l3mIFYuZR/ILgzxvtaph7gPgEA heE2umSEshQBholkvRa9LqY9DlYKnCls5BxiVKniHUzy/RV+8bWJlF1huRE7LzP6Suef UfHg== X-Gm-Message-State: APjAAAUJZAF6fkkOUJVdsRKCGkdZVyJCeMUDMmi4vYZJNygzIiASYHdY HIO49g0s9lK0hDdZLRjwRZUO5g== X-Google-Smtp-Source: APXvYqwfy57KUmDE1VA2LS08T92dACffdsdnOJYy9Qvwq4eLq3TN5C71lFIUbtBnAecTSV5jsNQ1Bg== X-Received: by 2002:a17:902:7884:: with SMTP id q4mr30505852pll.285.1575932193897; Mon, 09 Dec 2019 14:56:33 -0800 (PST) Received: from localhost (c-71-197-186-152.hsd1.wa.comcast.net. [71.197.186.152]) by smtp.gmail.com with ESMTPSA id g19sm504235pfh.134.2019.12.09.14.56.33 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 09 Dec 2019 14:56:33 -0800 (PST) From: Kevin Hilman To: Xingyu Chen , Neil Armstrong , Martin Blumenstingl Subject: Re: [PATCH] arm64: dts: a1: add saradc controller In-Reply-To: <1575358332-44866-1-git-send-email-xingyu.chen@amlogic.com> References: <1575358332-44866-1-git-send-email-xingyu.chen@amlogic.com> Date: Mon, 09 Dec 2019 14:56:32 -0800 Message-ID: <7hpngxqfa7.fsf@baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191209_145634_913888_A410DEF9 X-CRM114-Status: GOOD ( 13.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Qianggui Song , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jianxin Pan , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Jian Hu , Xingyu Chen , linux-amlogic@lists.infradead.org, Jonathan Cameron , Jerome Brunet Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Xingyu Chen writes: > The saradc controller in Meson-A1 is the same as the Meson-G12 series SoCs, > so we use the same compatible string. > > Signed-off-by: Xingyu Chen > > --- > This patch is based on A1 clock patchset at [0]. > > [0] https://lore.kernel.org/linux-amlogic/20191129144605.182774-1-jian.hu@amlogic.com > --- > arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi > index 7210ad0..cad1756 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi > @@ -93,6 +93,21 @@ > clock-names = "xtal", "pclk", "baud"; > status = "disabled"; > }; > + > + saradc: adc@2c00 { > + compatible = "amlogic,meson-g12a-saradc", > + "amlogic,meson-saradc"; > + reg = <0x0 0x2c00 0x0 0x48>; Why 0x48 here? AXG uses 0x38 and you're not adding any more registers to this driver. Kevin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel