All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@linaro.org>
To: Lina Iyer <lina.iyer@linaro.org>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>,
	sboyd@codeaurora.org, davidb@codeaurora.org,
	galak@codeaurora.org, linux-arm-msm@vger.kernel.org,
	lorenzo.pieralisi@arm.com, msivasub@codeaurora.org
Subject: Re: [PATCH v4 7/8] qcom: cpuidle: Add cpuidle driver for QCOM cpus
Date: Wed, 27 Aug 2014 10:31:26 -0700	[thread overview]
Message-ID: <7hvbpdet5d.fsf@paris.lan> (raw)
In-Reply-To: <20140821143643.GA60920@ilina-mac.local> (Lina Iyer's message of "Thu, 21 Aug 2014 08:36:43 -0600")

Lina Iyer <lina.iyer@linaro.org> writes:

> On Thu, Aug 21, 2014 at 03:24:44AM +0200, Daniel Lezcano wrote:
>>On 08/20/2014 12:15 AM, Lina Iyer wrote:

[...]

>>
>> So IIUC, if you specify the index 1, that means the state[0] will be
>> the default WFI. But you override the callback below in the loop.
>>
>> I recommend you use the default arm wfi callback but you implement
>> the cpu_do_idle for your platform.
>
> Yes, it was intended. I dont want to define two WFI states. The
> architectural WFI does not buy us enough compared to WFI that SoC can
> do. L2 can go into low power modes when the core is in WFI and for that
> I would like to have all WFI's enter SoC framework.

If the L2 is going into low-power, that means there will be higher
latency coming out compared to the architectural WFI, correct? 

If you have both, and the latency/residency numbers are accurate, the
governor is then left to pick the right one.  So, what's wrong with
having both?

Kevin

  parent reply	other threads:[~2014-08-27 17:31 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-19 22:15 [PATCH v4 0/8] QCOM 8074 cpuidle driver Lina Iyer
2014-08-19 22:15 ` [PATCH v4 1/8] msm: scm: Move scm-boot files to drivers/soc and include/soc Lina Iyer
2014-08-19 22:15 ` [PATCH v4 2/8] msm: scm: Add SCM warmboot flags for quad core targets Lina Iyer
2014-08-19 22:15 ` [PATCH v4 3/8] qcom: spm: Add Subsystem Power Manager driver (SAW2) Lina Iyer
2014-08-20  2:01   ` Stephen Boyd
2014-08-20  3:24     ` Lina Iyer
2014-08-21  0:25       ` Stephen Boyd
2014-08-21  0:25         ` Stephen Boyd
2014-08-21 15:50         ` Lina Iyer
2014-08-21 15:50           ` Lina Iyer
2014-08-19 22:15 ` [PATCH v4 4/8] qcom: spm-devices: Add SPM device manager for the SoC Lina Iyer
2014-08-25 23:40   ` Stephen Boyd
2014-08-26  0:31     ` Lina Iyer
2014-08-26  2:17       ` Stephen Boyd
2014-08-26  2:17         ` Stephen Boyd
     [not found]         ` <53FBEE2B.7020008-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2014-08-26 15:33           ` Lina Iyer
2014-08-26 15:33             ` Lina Iyer
2014-08-26 15:33             ` Lina Iyer
2014-08-27 14:00   ` Kumar Gala
2014-08-27 15:35     ` Lina Iyer
2014-08-19 22:15 ` [PATCH v4 5/8] arm: dts: qcom: Add SPM device bindings for 8974 Lina Iyer
2014-08-19 22:15 ` [PATCH v4 6/8] qcom: msm-pm: Add cpu low power mode functions Lina Iyer
2014-08-19 22:15 ` [PATCH v4 7/8] qcom: cpuidle: Add cpuidle driver for QCOM cpus Lina Iyer
2014-08-21  1:24   ` Daniel Lezcano
2014-08-21 14:36     ` Lina Iyer
2014-08-21 15:07       ` Lorenzo Pieralisi
2014-08-27 17:31       ` Kevin Hilman [this message]
2014-08-27 20:35         ` Lina Iyer
2014-08-22 15:36     ` Lina Iyer
2014-08-23 10:37       ` Lorenzo Pieralisi
2014-08-19 22:15 ` [PATCH v4 8/8] arm: dts: qcom: Add idle states device nodes for 8974 Lina Iyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7hvbpdet5d.fsf@paris.lan \
    --to=khilman@linaro.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=davidb@codeaurora.org \
    --cc=galak@codeaurora.org \
    --cc=lina.iyer@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=msivasub@codeaurora.org \
    --cc=sboyd@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.