From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH v2] cpuidle/cpuidle-big_little: fix reading cpu id part number Date: Fri, 15 Aug 2014 09:32:16 -0700 Message-ID: <7hwqa9ww6n.fsf@paris.lan> References: <1408004865-27525-1-git-send-email-juri.lelli@arm.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from mail-pa0-f47.google.com ([209.85.220.47]:55234 "EHLO mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752219AbaHOQcU (ORCPT ); Fri, 15 Aug 2014 12:32:20 -0400 Received: by mail-pa0-f47.google.com with SMTP id kx10so3733396pab.20 for ; Fri, 15 Aug 2014 09:32:20 -0700 (PDT) In-Reply-To: <1408004865-27525-1-git-send-email-juri.lelli@arm.com> (Juri Lelli's message of "Thu, 14 Aug 2014 09:27:45 +0100") Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Juri Lelli Cc: linux@arm.linux.org.uk, Lorenzo Pieralisi , Daniel Lezcano , "Rafael J. Wysocki" , Will Deacon , Chao Xie , Stephen Warren , Sebastian Hesselbarth , Rob Herring , Jonathan Austin , Chao Xie Linux , Juri Lelli , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Juri Lelli writes: > Commit af040ffc9ba1 ("ARM: make it easier to check the CPU part number > correctly") changed ARM_CPU_PART_X masks, and the way they are returned and > checked against. Usage of read_cpuid_part_number() is now deprecated, and > calling places updated accordingly. This actually broke cpuidle-big_little > initialization, as bl_idle_driver_init() performs a check using an hardcoded > mask on cpu_id. > > Create an interface to perform the check (that is now even easier to read). > Define also a proper mask (ARM_CPU_PART_MASK) that makes this kind of checks > cleaner and helps preventing bugs in the future. Update usage accordingly. [...] Tested-by: Kevin Hilman FWIW, I can confirm that this patch is needed for cpuidle-big_little to work on the Exynos5800/Chromebook2. Kevin From mboxrd@z Thu Jan 1 00:00:00 1970 From: khilman@linaro.org (Kevin Hilman) Date: Fri, 15 Aug 2014 09:32:16 -0700 Subject: [PATCH v2] cpuidle/cpuidle-big_little: fix reading cpu id part number In-Reply-To: <1408004865-27525-1-git-send-email-juri.lelli@arm.com> (Juri Lelli's message of "Thu, 14 Aug 2014 09:27:45 +0100") References: <1408004865-27525-1-git-send-email-juri.lelli@arm.com> Message-ID: <7hwqa9ww6n.fsf@paris.lan> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Juri Lelli writes: > Commit af040ffc9ba1 ("ARM: make it easier to check the CPU part number > correctly") changed ARM_CPU_PART_X masks, and the way they are returned and > checked against. Usage of read_cpuid_part_number() is now deprecated, and > calling places updated accordingly. This actually broke cpuidle-big_little > initialization, as bl_idle_driver_init() performs a check using an hardcoded > mask on cpu_id. > > Create an interface to perform the check (that is now even easier to read). > Define also a proper mask (ARM_CPU_PART_MASK) that makes this kind of checks > cleaner and helps preventing bugs in the future. Update usage accordingly. [...] Tested-by: Kevin Hilman FWIW, I can confirm that this patch is needed for cpuidle-big_little to work on the Exynos5800/Chromebook2. Kevin