From: Kevin Hilman <khilman@baylibre.com>
To: Otto Meier <gf435@gmx.net>, linux-amlogic@lists.infradead.org
Subject: Re: [PATCH] pinctrl: meson: add tsin pinctrl for meson gxbb/gxl/gxm
Date: Wed, 04 Mar 2020 10:27:31 +0100 [thread overview]
Message-ID: <7hy2sgo4fw.fsf@baylibre.com> (raw)
In-Reply-To: <0522f4cb-936d-50e0-1b6f-c885c94d7aa9@gmx.net>
Hi Otto,
Otto Meier <gf435@gmx.net> writes:
> Hello
>
> after having fixed the uart_c pinctrl definitions during September,
>
> this patch would revert part of the formerly Patch.
You only sent this to the linux-amlogic list.
Can you resend your comments replying to all of the original recipients
so that the pinctrl maintainers can see your concerns/comments.
Thanks,
Kevin
>
> /* Bank Y */
> - GROUP(uart_cts_c, 1, 17),
> - GROUP(uart_rts_c, 1, 16),
> - GROUP(uart_tx_c, 1, 19),
> - GROUP(uart_rx_c, 1, 18),
> + GROUP(tsin_a_fail, 3, 3),
> + GROUP(tsin_a_d_valid, 3, 2),
> + GROUP(tsin_a_sop, 3, 1),
> + GROUP(tsin_a_clk, 3, 0),
> + GROUP(tsin_a_d0, 3, 4),
> + GROUP(tsin_a_dp, 3, 5),
> + GROUP(uart_cts_c, 1, 19),
> + GROUP(uart_rts_c, 1, 18),
> + GROUP(uart_tx_c, 1, 17),
> + GROUP(uart_rx_c, 1, 16),
>
> The Numbering of uart_C pins is changed by this patch.
>
> This patch definitly breaks the sdcard, if uart_c is enabled.
>
> bye
>
> Otto
>
>
> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-amlogic
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2020-03-04 9:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-03 13:23 [PATCH] pinctrl: meson: add tsin pinctrl for meson gxbb/gxl/gxm Otto Meier
2020-03-03 14:05 ` Neil Armstrong
2020-03-04 9:27 ` Kevin Hilman [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-03-02 4:40 Christian Hewitt
2020-03-02 4:40 ` Christian Hewitt
2020-03-02 4:40 ` Christian Hewitt
2020-03-03 12:40 ` Linus Walleij
2020-03-03 12:40 ` Linus Walleij
2020-03-03 12:40 ` Linus Walleij
2020-03-04 10:03 ` Neil Armstrong
2020-03-04 10:03 ` Neil Armstrong
2020-03-04 10:03 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7hy2sgo4fw.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=gf435@gmx.net \
--cc=linux-amlogic@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.