From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8B360C433F5 for ; Thu, 26 May 2022 16:28:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=P9IkCqddLYy+llz8sQW1ti3+Wz4ME5jnVwWZ+J/koOE=; b=Q73jye8HkSwgg8 UvRip7x3CugV1cFhoXVgye/wZrAHksRhfvR4oNur7aVb2qbjoI6lxTzQbaOsf3T2/Jzmtc3jtlLo+ 5qIt+DxGkUZdxR9epEbEOS4+9p20FttzgFAO7kmWgAKiiMjOYOtX/Q1t4Hj5zZJK9B0pN8Cb1xGLc e1Et4Kz/AL8Zr/75vj07LFoOildM8r+JaK625teY8MJKZaGQfLDwU4Vqf37KXJQu2pbPdGQRMhucB IIV/6RIAa6TxjGubiejnuI1dZALp5PvC0t9yM24nFXmzZHigcYJHwkLhX++OpAhrxTin8lBwypECd +bT8eQwADRLcAJRYssSQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nuGL9-00FP0u-HY; Thu, 26 May 2022 16:27:59 +0000 Received: from mail-pj1-x1034.google.com ([2607:f8b0:4864:20::1034]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nuGKw-00FOyL-Nw for linux-amlogic@lists.infradead.org; Thu, 26 May 2022 16:27:49 +0000 Received: by mail-pj1-x1034.google.com with SMTP id l20-20020a17090a409400b001dd2a9d555bso2151384pjg.0 for ; Thu, 26 May 2022 09:27:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=4vutIBHqxzPtRizpru9FIl4V8pZQd9bQbIhzf9Wl6YM=; b=fYIUii+ilJ6xYpJ/aW7FWU4cHzVZhJ8tF7CN/IwV+ecrBavxUSQQmuxvcSMjL8U44x 6iTAlBS0cN5hnPjmUPOQ00jVxY3DvWF7Q1tgpZfPecxbsGAPvss7VFtwcUxvsY/CCFP8 MNGkHYNq9RQNdtiYWoWygRrZQKj+DuPAs+mA8b2Vr5QYSYJ+ItH65JCWkewhQ54JWhIl SpNdnhSy7WqZbPBldKQaDf6gYtVJXIylFYmWgVw7BrlpDsVfNNDBWlew3a2+ZoTM4rSH Gm9Rn7/5LA7G8yquhdsNw2RzlGViPAQWVT/5hWQIHshikVeBCWobCqmIqJvpvDjkdh3d jLKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=4vutIBHqxzPtRizpru9FIl4V8pZQd9bQbIhzf9Wl6YM=; b=2nvEvxUw6wrhfG6zguLjIDpoKZ38eXEjbSHBPrvapXDzMPzTfXctufzfrZ9MIReVSk I8QFvukHGcNlVutFWOlBx2mwJPYo4B04ZfNqRzz7BMD3ydk05ALcW0U05eZQ/NZ3mQ05 tXlW/W52XrK177dSSoX1cZKomvR0T4uBUIYRIEaVlKt7mNLY8y+EnaQsKyshDDaVJLzU cTqFB/M1pusI+pRWk63UPowTyklaA+CrHn8JRqgigQreKEiCqJxaaBHqW/eRUBFE9qKg fQMaL6kYIcmUGrhWYD3Z/49TZtgMGXVPtgJESIIPTh1dZFEtIbIpcGHMEKTtSyzCgmLW obWg== X-Gm-Message-State: AOAM532/SfJEQn4axtzD0IZ83+b5ivYcVc2vZ+gDuUAldDj75FcPsMbn 1Ot7usYuIeDliNnp0LyqE8bdbw== X-Google-Smtp-Source: ABdhPJxDqS/Z3pSXV5Ra/3fFBt04uf3IzrKccw9F+aLXlXccc6U1sN8lO/y6czwPUNvcJgeJcgf6AQ== X-Received: by 2002:a17:902:a413:b0:156:15b:524a with SMTP id p19-20020a170902a41300b00156015b524amr38615941plq.106.1653582464964; Thu, 26 May 2022 09:27:44 -0700 (PDT) Received: from localhost (c-71-197-186-152.hsd1.wa.comcast.net. [71.197.186.152]) by smtp.gmail.com with ESMTPSA id x1-20020a633101000000b003f60a8d7dadsm1733424pgx.15.2022.05.26.09.27.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 May 2022 09:27:44 -0700 (PDT) From: Kevin Hilman To: Liang Yang , Miquel Raynal , linux-mtd@lists.infradead.org Cc: Liang Yang , Rob Herring , Richard Weinberger , Vignesh Raghavendra , Jerome Brunet , Neil Armstrong , Martin Blumenstingl , Jianxin Pan , Victor Wan , XianWei Zhao , Kelvin Zhang , BiChao Zheng , YongHui Yu , linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 3/4] mtd: rawnand: meson: refine resource getting in probe In-Reply-To: <20220513123404.48513-4-liang.yang@amlogic.com> References: <20220513123404.48513-1-liang.yang@amlogic.com> <20220513123404.48513-4-liang.yang@amlogic.com> Date: Thu, 26 May 2022 09:27:43 -0700 Message-ID: <7hzgj48dj4.fsf@baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220526_092746_787522_95F1D21C X-CRM114-Status: GOOD ( 15.24 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Liang Yang writes: > Signed-off-by: Liang Yang Patch should have a changelog. Reviewed-by: Kevin Hilman > --- > drivers/mtd/nand/raw/meson_nand.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c > index cc93667a1e7f..6e50387475bb 100644 > --- a/drivers/mtd/nand/raw/meson_nand.c > +++ b/drivers/mtd/nand/raw/meson_nand.c > @@ -1378,7 +1378,6 @@ static int meson_nfc_probe(struct platform_device *pdev) > { > struct device *dev = &pdev->dev; > struct meson_nfc *nfc; > - struct resource *res; > int ret, irq; > > nfc = devm_kzalloc(dev, sizeof(*nfc), GFP_KERNEL); > @@ -1395,8 +1394,7 @@ static int meson_nfc_probe(struct platform_device *pdev) > > nfc->dev = dev; > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - nfc->reg_base = devm_ioremap_resource(dev, res); > + nfc->reg_base = devm_platform_ioremap_resource_byname(pdev, "nfc"); > if (IS_ERR(nfc->reg_base)) > return PTR_ERR(nfc->reg_base); > > -- > 2.34.1 > > > _______________________________________________ > linux-amlogic mailing list > linux-amlogic@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-amlogic _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3AC7FC433EF for ; Thu, 26 May 2022 16:28:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HYGGLFKdIU6/nw2jH8ePltUpWNNTRNdwRYDHXFGWAOU=; b=Siuy0D7zwPrGr/ RwwbVb/WMdsIVIVYyOLQRxUw7fheYn6rb6Kijyir5tiZljLuiQq/6PeGWSC0g3hUD1U/V+A8aSYuJ E3zOKnbN4+rkhPMPey9wlJY2Qtv2KfG8aLrleJ16fEjst2+FiVKXcXe5fKI9UNS2KtfIGVh9GaCd7 U4qOqOPRe4qXeaTGlHAlU1+ttnsCtlweRJRsvtDa04YpY47hzrO3Aa/27st1ckoTbWRvqGIsU3T6p NFEcH5cunfIHgZOuNQiaJ1qNBS7lin4eKdh2uk9jibbWvoZ0BIoqlseXiUiNvm8h8YfdBaZYXudGS +8b1PcAt+d3cWo/3z3GQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nuGLB-00FP13-KH; Thu, 26 May 2022 16:28:01 +0000 Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nuGKw-00FOyM-O1 for linux-mtd@lists.infradead.org; Thu, 26 May 2022 16:27:50 +0000 Received: by mail-pl1-x629.google.com with SMTP id n8so1872619plh.1 for ; Thu, 26 May 2022 09:27:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=4vutIBHqxzPtRizpru9FIl4V8pZQd9bQbIhzf9Wl6YM=; b=fYIUii+ilJ6xYpJ/aW7FWU4cHzVZhJ8tF7CN/IwV+ecrBavxUSQQmuxvcSMjL8U44x 6iTAlBS0cN5hnPjmUPOQ00jVxY3DvWF7Q1tgpZfPecxbsGAPvss7VFtwcUxvsY/CCFP8 MNGkHYNq9RQNdtiYWoWygRrZQKj+DuPAs+mA8b2Vr5QYSYJ+ItH65JCWkewhQ54JWhIl SpNdnhSy7WqZbPBldKQaDf6gYtVJXIylFYmWgVw7BrlpDsVfNNDBWlew3a2+ZoTM4rSH Gm9Rn7/5LA7G8yquhdsNw2RzlGViPAQWVT/5hWQIHshikVeBCWobCqmIqJvpvDjkdh3d jLKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=4vutIBHqxzPtRizpru9FIl4V8pZQd9bQbIhzf9Wl6YM=; b=tXVpPOeGrNuhqLXuAl7AAC6R2jyGEJFvL7bNFoGAKkEiXWEE0z/rmewdnWXCi/PSwb RMHldP/UAFniRTWGjPdCiIV1KVF2OJaETVKMDJoj6T0EFOCncnjVqeKmr4tusgAQRAin rni22LvheT16l5bzAkj689w0iVMGmtccCu/CKQTeL7uW1Ainj3g/looPOgWO3espT8Vv PivT3N+ohSs9IHvsVRmFdB7kgelr8TagKcLpLnYElju7K7MhD4K9dd7tM9tOVdWBxk5c B7fuNv/+6nwCVK2WsP15PNjez36/DAq2350VAGLj3yoMxL/B6c3aTHXUUsF6PLItSoDe IKDw== X-Gm-Message-State: AOAM531ezqH2swqTM5e6znqwjw/6PA/CAwDLfT2DsDko6u990druI/Tb urMt6vgVEucve0NFsy4/M77rTA== X-Google-Smtp-Source: ABdhPJxDqS/Z3pSXV5Ra/3fFBt04uf3IzrKccw9F+aLXlXccc6U1sN8lO/y6czwPUNvcJgeJcgf6AQ== X-Received: by 2002:a17:902:a413:b0:156:15b:524a with SMTP id p19-20020a170902a41300b00156015b524amr38615941plq.106.1653582464964; Thu, 26 May 2022 09:27:44 -0700 (PDT) Received: from localhost (c-71-197-186-152.hsd1.wa.comcast.net. [71.197.186.152]) by smtp.gmail.com with ESMTPSA id x1-20020a633101000000b003f60a8d7dadsm1733424pgx.15.2022.05.26.09.27.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 May 2022 09:27:44 -0700 (PDT) From: Kevin Hilman To: Liang Yang , Miquel Raynal , linux-mtd@lists.infradead.org Cc: Liang Yang , Rob Herring , Richard Weinberger , Vignesh Raghavendra , Jerome Brunet , Neil Armstrong , Martin Blumenstingl , Jianxin Pan , Victor Wan , XianWei Zhao , Kelvin Zhang , BiChao Zheng , YongHui Yu , linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 3/4] mtd: rawnand: meson: refine resource getting in probe In-Reply-To: <20220513123404.48513-4-liang.yang@amlogic.com> References: <20220513123404.48513-1-liang.yang@amlogic.com> <20220513123404.48513-4-liang.yang@amlogic.com> Date: Thu, 26 May 2022 09:27:43 -0700 Message-ID: <7hzgj48dj4.fsf@baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220526_092746_790461_F8EB049F X-CRM114-Status: GOOD ( 15.98 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org Liang Yang writes: > Signed-off-by: Liang Yang Patch should have a changelog. Reviewed-by: Kevin Hilman > --- > drivers/mtd/nand/raw/meson_nand.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c > index cc93667a1e7f..6e50387475bb 100644 > --- a/drivers/mtd/nand/raw/meson_nand.c > +++ b/drivers/mtd/nand/raw/meson_nand.c > @@ -1378,7 +1378,6 @@ static int meson_nfc_probe(struct platform_device *pdev) > { > struct device *dev = &pdev->dev; > struct meson_nfc *nfc; > - struct resource *res; > int ret, irq; > > nfc = devm_kzalloc(dev, sizeof(*nfc), GFP_KERNEL); > @@ -1395,8 +1394,7 @@ static int meson_nfc_probe(struct platform_device *pdev) > > nfc->dev = dev; > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - nfc->reg_base = devm_ioremap_resource(dev, res); > + nfc->reg_base = devm_platform_ioremap_resource_byname(pdev, "nfc"); > if (IS_ERR(nfc->reg_base)) > return PTR_ERR(nfc->reg_base); > > -- > 2.34.1 > > > _______________________________________________ > linux-amlogic mailing list > linux-amlogic@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-amlogic ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EF02CC433EF for ; Thu, 26 May 2022 16:29:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=K8a8KST1eC1Z8A2xPhS7GtzMcL1REsgikLScAX98q4Y=; b=Qp4l/4m182XaSi ffRc3Cw9Bw0zKAVJ0T0wXyLA8GbeLP/m/Ifn3alj0zPJZsYnDqluuOF4cq/Eaj5tzK3Atl79Jb5Oz +at44dQo9JKb1wU3WNQQSkJeMPhtBuzRpJPMLXhD/3cRSJsnZcRKvRZhFuCXb8qlAwaq4K1rhM+SC iHhLeSCzchn76NUXpzCUvClpUN0IsVDMaQa+DYRrl2FMMDHZLq40CfxjxgCG0hDzIUekyVUWTtXeG rPdvVQJ1UqDOGNVeMVPMABk7xspzcHywkis4LfnlfdyzknOOd3dfvNNvXq26GlQ+Dd/XhXP50Plf+ TLD9reZPpsvTcvEcc8/w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nuGL1-00FP00-6d; Thu, 26 May 2022 16:27:51 +0000 Received: from mail-pj1-x1033.google.com ([2607:f8b0:4864:20::1033]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nuGKw-00FOyN-8L for linux-arm-kernel@lists.infradead.org; Thu, 26 May 2022 16:27:49 +0000 Received: by mail-pj1-x1033.google.com with SMTP id gk22so2201432pjb.1 for ; Thu, 26 May 2022 09:27:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=4vutIBHqxzPtRizpru9FIl4V8pZQd9bQbIhzf9Wl6YM=; b=fYIUii+ilJ6xYpJ/aW7FWU4cHzVZhJ8tF7CN/IwV+ecrBavxUSQQmuxvcSMjL8U44x 6iTAlBS0cN5hnPjmUPOQ00jVxY3DvWF7Q1tgpZfPecxbsGAPvss7VFtwcUxvsY/CCFP8 MNGkHYNq9RQNdtiYWoWygRrZQKj+DuPAs+mA8b2Vr5QYSYJ+ItH65JCWkewhQ54JWhIl SpNdnhSy7WqZbPBldKQaDf6gYtVJXIylFYmWgVw7BrlpDsVfNNDBWlew3a2+ZoTM4rSH Gm9Rn7/5LA7G8yquhdsNw2RzlGViPAQWVT/5hWQIHshikVeBCWobCqmIqJvpvDjkdh3d jLKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=4vutIBHqxzPtRizpru9FIl4V8pZQd9bQbIhzf9Wl6YM=; b=b+a8NmQCSqn+iReYjJhMfxgOg1VfAKlTOxjTU2gqsNvgU04GqpZMLs1FvcCZJaaLKZ nZjonfFAcByoQVPzJk+q3px/OolPjEXobBO8QnPwgKiKQTMoEQ6ggu9S08+HlqWB4NR1 FpnqAk0z8N5k+Vpq/T+5eK8PlKi3tLDrAKhDz+OVvP1LkmTAAvwyLzfx9DQYWHP+wg3z IXzH2LrMBVebZjrOS79Gy5U23PjT7l0D4UxrVJbsSi0x2nonu5ZHO8Onq5TS6q7oEJUf 3JyYGA6ybccgGjNqWhy/t1zNqWdAu0cs9ny9yTAdlceAZdXaH9Frof62fqfaHmenfCIJ 2EWQ== X-Gm-Message-State: AOAM533mAfop+sDEmnmwjanbJh6keSGyj6+MI6iJJ3+LlKb7m3ydKPN1 8iuPVXjiC6jlcz1W4Q7CzN3dPQ== X-Google-Smtp-Source: ABdhPJxDqS/Z3pSXV5Ra/3fFBt04uf3IzrKccw9F+aLXlXccc6U1sN8lO/y6czwPUNvcJgeJcgf6AQ== X-Received: by 2002:a17:902:a413:b0:156:15b:524a with SMTP id p19-20020a170902a41300b00156015b524amr38615941plq.106.1653582464964; Thu, 26 May 2022 09:27:44 -0700 (PDT) Received: from localhost (c-71-197-186-152.hsd1.wa.comcast.net. [71.197.186.152]) by smtp.gmail.com with ESMTPSA id x1-20020a633101000000b003f60a8d7dadsm1733424pgx.15.2022.05.26.09.27.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 May 2022 09:27:44 -0700 (PDT) From: Kevin Hilman To: Liang Yang , Miquel Raynal , linux-mtd@lists.infradead.org Cc: Liang Yang , Rob Herring , Richard Weinberger , Vignesh Raghavendra , Jerome Brunet , Neil Armstrong , Martin Blumenstingl , Jianxin Pan , Victor Wan , XianWei Zhao , Kelvin Zhang , BiChao Zheng , YongHui Yu , linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 3/4] mtd: rawnand: meson: refine resource getting in probe In-Reply-To: <20220513123404.48513-4-liang.yang@amlogic.com> References: <20220513123404.48513-1-liang.yang@amlogic.com> <20220513123404.48513-4-liang.yang@amlogic.com> Date: Thu, 26 May 2022 09:27:43 -0700 Message-ID: <7hzgj48dj4.fsf@baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220526_092746_602413_51BFA51F X-CRM114-Status: GOOD ( 16.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Liang Yang writes: > Signed-off-by: Liang Yang Patch should have a changelog. Reviewed-by: Kevin Hilman > --- > drivers/mtd/nand/raw/meson_nand.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c > index cc93667a1e7f..6e50387475bb 100644 > --- a/drivers/mtd/nand/raw/meson_nand.c > +++ b/drivers/mtd/nand/raw/meson_nand.c > @@ -1378,7 +1378,6 @@ static int meson_nfc_probe(struct platform_device *pdev) > { > struct device *dev = &pdev->dev; > struct meson_nfc *nfc; > - struct resource *res; > int ret, irq; > > nfc = devm_kzalloc(dev, sizeof(*nfc), GFP_KERNEL); > @@ -1395,8 +1394,7 @@ static int meson_nfc_probe(struct platform_device *pdev) > > nfc->dev = dev; > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - nfc->reg_base = devm_ioremap_resource(dev, res); > + nfc->reg_base = devm_platform_ioremap_resource_byname(pdev, "nfc"); > if (IS_ERR(nfc->reg_base)) > return PTR_ERR(nfc->reg_base); > > -- > 2.34.1 > > > _______________________________________________ > linux-amlogic mailing list > linux-amlogic@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-amlogic _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FFB7C433F5 for ; Thu, 26 May 2022 16:27:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344562AbiEZQ1t (ORCPT ); Thu, 26 May 2022 12:27:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49836 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229780AbiEZQ1r (ORCPT ); Thu, 26 May 2022 12:27:47 -0400 Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 79548506F8 for ; Thu, 26 May 2022 09:27:45 -0700 (PDT) Received: by mail-pl1-x62e.google.com with SMTP id m1so1866934plx.3 for ; Thu, 26 May 2022 09:27:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=4vutIBHqxzPtRizpru9FIl4V8pZQd9bQbIhzf9Wl6YM=; b=fYIUii+ilJ6xYpJ/aW7FWU4cHzVZhJ8tF7CN/IwV+ecrBavxUSQQmuxvcSMjL8U44x 6iTAlBS0cN5hnPjmUPOQ00jVxY3DvWF7Q1tgpZfPecxbsGAPvss7VFtwcUxvsY/CCFP8 MNGkHYNq9RQNdtiYWoWygRrZQKj+DuPAs+mA8b2Vr5QYSYJ+ItH65JCWkewhQ54JWhIl SpNdnhSy7WqZbPBldKQaDf6gYtVJXIylFYmWgVw7BrlpDsVfNNDBWlew3a2+ZoTM4rSH Gm9Rn7/5LA7G8yquhdsNw2RzlGViPAQWVT/5hWQIHshikVeBCWobCqmIqJvpvDjkdh3d jLKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=4vutIBHqxzPtRizpru9FIl4V8pZQd9bQbIhzf9Wl6YM=; b=vbCyST8C+cHancbRaHnmUj9S3Bn6jD5WnWKpA6KpEC9p9m0ie//+Vf/nvZqmGSrjTd fJbw06IHKui0cCrV9Xej97ZbL3/qdi0rzfVsL6rjPjGs7L2YU5ZDKkToeSLOvr0Ttgy+ 3xnbzmfUnmfJVAOUGw4f1kXD+HV+cCxUPjoVciojxL5hgKYChggYYiWAoJc3anqF3+fE RjpNfKtws1Zy3vCOp+OhXn+0GokUEiJMg+/jTj4uaUTd/nmfj6cL43B4JAqfUjTUUoDW ES118LhI9Oy8bknXqjyFRlppNHQP6exJt2sPgMZuVWXLQVZ7Qhk6FbHWarrGC6ufSxHa TvPw== X-Gm-Message-State: AOAM531ixFyRiQZTvQOoXyC1oSh08VaEQ4jG/aL6L3Hf/4Bp4s6+BoQ/ ezv2++ccTzHCgraOwVGz5bgxcA== X-Google-Smtp-Source: ABdhPJxDqS/Z3pSXV5Ra/3fFBt04uf3IzrKccw9F+aLXlXccc6U1sN8lO/y6czwPUNvcJgeJcgf6AQ== X-Received: by 2002:a17:902:a413:b0:156:15b:524a with SMTP id p19-20020a170902a41300b00156015b524amr38615941plq.106.1653582464964; Thu, 26 May 2022 09:27:44 -0700 (PDT) Received: from localhost (c-71-197-186-152.hsd1.wa.comcast.net. [71.197.186.152]) by smtp.gmail.com with ESMTPSA id x1-20020a633101000000b003f60a8d7dadsm1733424pgx.15.2022.05.26.09.27.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 May 2022 09:27:44 -0700 (PDT) From: Kevin Hilman To: Liang Yang , Miquel Raynal , linux-mtd@lists.infradead.org Cc: Liang Yang , Rob Herring , Richard Weinberger , Vignesh Raghavendra , Jerome Brunet , Neil Armstrong , Martin Blumenstingl , Jianxin Pan , Victor Wan , XianWei Zhao , Kelvin Zhang , BiChao Zheng , YongHui Yu , linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 3/4] mtd: rawnand: meson: refine resource getting in probe In-Reply-To: <20220513123404.48513-4-liang.yang@amlogic.com> References: <20220513123404.48513-1-liang.yang@amlogic.com> <20220513123404.48513-4-liang.yang@amlogic.com> Date: Thu, 26 May 2022 09:27:43 -0700 Message-ID: <7hzgj48dj4.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Liang Yang writes: > Signed-off-by: Liang Yang Patch should have a changelog. Reviewed-by: Kevin Hilman > --- > drivers/mtd/nand/raw/meson_nand.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c > index cc93667a1e7f..6e50387475bb 100644 > --- a/drivers/mtd/nand/raw/meson_nand.c > +++ b/drivers/mtd/nand/raw/meson_nand.c > @@ -1378,7 +1378,6 @@ static int meson_nfc_probe(struct platform_device *pdev) > { > struct device *dev = &pdev->dev; > struct meson_nfc *nfc; > - struct resource *res; > int ret, irq; > > nfc = devm_kzalloc(dev, sizeof(*nfc), GFP_KERNEL); > @@ -1395,8 +1394,7 @@ static int meson_nfc_probe(struct platform_device *pdev) > > nfc->dev = dev; > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - nfc->reg_base = devm_ioremap_resource(dev, res); > + nfc->reg_base = devm_platform_ioremap_resource_byname(pdev, "nfc"); > if (IS_ERR(nfc->reg_base)) > return PTR_ERR(nfc->reg_base); > > -- > 2.34.1 > > > _______________________________________________ > linux-amlogic mailing list > linux-amlogic@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-amlogic