All of lore.kernel.org
 help / color / mirror / Atom feed
From: khilman@baylibre.com (Kevin Hilman)
To: linus-amlogic@lists.infradead.org
Subject: [RFC PATCH 1/3] reset: Add support for the Amlogic Meson GXBB Reset Controller
Date: Sat, 14 May 2016 10:45:54 -0700	[thread overview]
Message-ID: <7hzirsh6st.fsf@baylibre.com> (raw)
In-Reply-To: <1463148012-25988-2-git-send-email-narmstrong@baylibre.com> (Neil Armstrong's message of "Fri, 13 May 2016 16:00:10 +0200")

Neil Armstrong <narmstrong@baylibre.com> writes:

> This patch adds the platform driver for the Amlogic Meson GXBB Reset
> Controller.
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>

[...]

> +struct meson_gxbb_reset {
> +	void *reg_base;

nit: along wit the readw/writel, this should be void __iomem *.

> +	struct reset_controller_dev rcdev;
> +};

Kevin

WARNING: multiple messages have this Message-ID (diff)
From: khilman@baylibre.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 1/3] reset: Add support for the Amlogic Meson GXBB Reset Controller
Date: Sat, 14 May 2016 10:45:54 -0700	[thread overview]
Message-ID: <7hzirsh6st.fsf@baylibre.com> (raw)
In-Reply-To: <1463148012-25988-2-git-send-email-narmstrong@baylibre.com> (Neil Armstrong's message of "Fri, 13 May 2016 16:00:10 +0200")

Neil Armstrong <narmstrong@baylibre.com> writes:

> This patch adds the platform driver for the Amlogic Meson GXBB Reset
> Controller.
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>

[...]

> +struct meson_gxbb_reset {
> +	void *reg_base;

nit: along wit the readw/writel, this should be void __iomem *.

> +	struct reset_controller_dev rcdev;
> +};

Kevin

WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: Neil Armstrong <narmstrong@baylibre.com>
Cc: linux-kernel@vger.kernel.org, p.zabel@pengutronix.de,
	linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org
Subject: Re: [RFC PATCH 1/3] reset: Add support for the Amlogic Meson GXBB Reset Controller
Date: Sat, 14 May 2016 10:45:54 -0700	[thread overview]
Message-ID: <7hzirsh6st.fsf@baylibre.com> (raw)
In-Reply-To: <1463148012-25988-2-git-send-email-narmstrong@baylibre.com> (Neil Armstrong's message of "Fri, 13 May 2016 16:00:10 +0200")

Neil Armstrong <narmstrong@baylibre.com> writes:

> This patch adds the platform driver for the Amlogic Meson GXBB Reset
> Controller.
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>

[...]

> +struct meson_gxbb_reset {
> +	void *reg_base;

nit: along wit the readw/writel, this should be void __iomem *.

> +	struct reset_controller_dev rcdev;
> +};

Kevin

  parent reply	other threads:[~2016-05-14 17:45 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-13 14:00 [RFC PATCH 0/3] Amlogic: GXBB: Add reset controller Neil Armstrong
2016-05-13 14:00 ` Neil Armstrong
2016-05-13 14:00 ` Neil Armstrong
2016-05-13 14:00 ` [RFC PATCH 1/3] reset: Add support for the Amlogic Meson GXBB Reset Controller Neil Armstrong
2016-05-13 14:00   ` Neil Armstrong
2016-05-13 14:00   ` Neil Armstrong
2016-05-14 15:07   ` Kevin Hilman
2016-05-14 15:07     ` Kevin Hilman
2016-05-14 15:07     ` Kevin Hilman
2016-05-16  8:49     ` Neil Armstrong
2016-05-16  8:49       ` Neil Armstrong
2016-05-16  8:49       ` Neil Armstrong
2016-05-14 17:45   ` Kevin Hilman [this message]
2016-05-14 17:45     ` Kevin Hilman
2016-05-14 17:45     ` Kevin Hilman
2016-05-13 14:00 ` [RFC PATCH 2/3] dt-bindings: reset: Add bindings for the " Neil Armstrong
2016-05-13 14:00   ` Neil Armstrong
2016-05-13 14:00   ` Neil Armstrong
2016-05-14 14:45   ` Kevin Hilman
2016-05-14 14:45     ` Kevin Hilman
2016-05-14 14:45     ` Kevin Hilman
2016-05-13 14:00 ` [RFC PATCH 3/3] ARM64: dts: amlogic: Enable Reset Controller on GXBB-based platforms Neil Armstrong
2016-05-13 14:00   ` Neil Armstrong
2016-05-13 14:00   ` Neil Armstrong
2016-05-14 15:09 ` [RFC PATCH 0/3] Amlogic: GXBB: Add reset controller Kevin Hilman
2016-05-14 15:09   ` Kevin Hilman
2016-05-14 15:09   ` Kevin Hilman
2016-05-14 15:11 ` Kevin Hilman
2016-05-14 15:11   ` Kevin Hilman
2016-05-14 15:11   ` Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7hzirsh6st.fsf@baylibre.com \
    --to=khilman@baylibre.com \
    --cc=linus-amlogic@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.