From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Finn Arne Gangstad <finnag@pvv.org>, git@vger.kernel.org
Subject: Re: [PATCH 1/3] git remote update: Report error for non-existing groups
Date: Wed, 08 Apr 2009 11:48:49 -0700 [thread overview]
Message-ID: <7v1vs3nfqm.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20090408170844.GB28069@coredump.intra.peff.net> (Jeff King's message of "Wed, 8 Apr 2009 13:08:45 -0400")
Jeff King <peff@peff.net> writes:
> On Wed, Apr 08, 2009 at 01:20:36AM -0700, Junio C Hamano wrote:
>
>> I don't know what users want to see when they say "default" explicitly
>> without having an explicit configuration. Should it do the same thing as
>> "git remote update"?
>
> I'm not sure we have a choice anymore; is it worth breaking
> compatibility to "fix" something that doesn't actually seem to be
> harming anyone?
Nope. I do not use the "remote update" myself to begin with, and I
somehow suspect that the reason it does not seem to be harming anyone is
because nobody sane uses these "remote groups".
Anyway, I took the patch as-is already.
next prev parent reply other threads:[~2009-04-08 18:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-06 13:40 [PATCH 0/3] git remote update: Check args and fallback to remotes Finn Arne Gangstad
2009-04-06 13:41 ` [PATCH 1/3] git remote update: Report error for non-existing groups Finn Arne Gangstad
2009-04-08 2:16 ` Junio C Hamano
2009-04-08 8:07 ` Finn Arne Gangstad
2009-04-08 8:20 ` Junio C Hamano
2009-04-08 17:08 ` Jeff King
2009-04-08 18:48 ` Junio C Hamano [this message]
2009-04-06 13:41 ` [PATCH 2/3] remote: New function remote_is_configured() Finn Arne Gangstad
2009-04-06 13:41 ` [PATCH 3/3] git remote update: Fallback to remote if group does not exist Finn Arne Gangstad
2009-04-06 20:18 ` [PATCH 0/3] git remote update: Check args and fallback to remotes Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v1vs3nfqm.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=finnag@pvv.org \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.