All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: git am and the wrong chunk of ---
Date: Thu, 09 Aug 2012 18:26:21 -0700	[thread overview]
Message-ID: <7v393vmtaa.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <5024523F.3050208@zytor.com> (H. Peter Anvin's message of "Thu, 09 Aug 2012 17:13:51 -0700")

"H. Peter Anvin" <hpa@zytor.com> writes:

> Hello,
>
> I have some contributors who consistently put their commentary
> *before* the "---" line rather than *after* it, presumably with the
> notion that it is some kind of "cover text".  This messes with "git
> am", and so I end up having to edit those posts manually.
>
> I have tried git am --scissors and it doesn't seem to solve the problem.
>
> Is there any other option which can be used to automatically process
> such a patch?

I hate to be the one who is telling you this, but if the submitter
cannot be trained to write supporting material after "---" as the
convention across git using projects suggest him to do, it is likely
that he didn't write supporting material before the scissors, or did
not resist the temptation to deviate from the accepted shape of the
scissors (e.g. "-- >8 --") just to be creative.  For that matter, I
would be mildly surprised if the material in the middle is usable as
is as an acceptable log message from such a submitter X-<.

So in short, no, --scissors (or -c in short) is not any more magical
than the traditional "---".

  reply	other threads:[~2012-08-10  1:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-10  0:13 git am and the wrong chunk of --- H. Peter Anvin
2012-08-10  1:26 ` Junio C Hamano [this message]
2012-08-10 10:36 ` Jeff King
2012-08-10 11:00   ` Andreas Ericsson
2012-08-10 14:46   ` Junio C Hamano
2012-08-10 14:48     ` H. Peter Anvin
2012-08-10 16:15       ` Junio C Hamano
2012-08-10 16:39         ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v393vmtaa.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=hpa@zytor.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.