From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, "Nguyen Thai Ngoc Duy" <pclouds@gmail.com>,
"Ævar Arnfjörð" <avarab@gmail.com>
Subject: Re: [PATCH 00/22] Refactor to accept NUL in commit messages
Date: Thu, 27 Oct 2011 12:14:34 -0700 [thread overview]
Message-ID: <7v39eez1ph.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20111027185220.GA26621@sigill.intra.peff.net> (Jeff King's message of "Thu, 27 Oct 2011 11:52:21 -0700")
Jeff King <peff@peff.net> writes:
> On Thu, Oct 27, 2011 at 11:47:27AM -0700, Junio C Hamano wrote:
>
>> Jeff King <peff@peff.net> writes:
>>
>> > I'm tempted to detect the UTF-{16,32}{LE,BE} by their BOM, reencode them
>> > to utf8, and then display them in utf8. Is that too gross for us to
>> > consider?
>>
>> I tend to think so; it is entirely a different matter if the user
>> instructed us to clean/smudge UTF-16 payload into/outof UTF-8.
>
> Minor nit, but this is just for diff, so it is not about clean/smudge
> but rather about doing something like textconv.
I can understand if some tools in the Windows land prefer to work with
these encodings, so clean/smudge to have the checkout in these encodings
would be a reasonable thing not just diff but things like grep. On the
other hand, I do doubt the sanity of these people if they want to have
in-repository representation also in these encodings.
So I do not think "it is just for diff" is any improvement.
next prev parent reply other threads:[~2011-10-27 19:14 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1319277881-4128-1-git-send-email-pclouds@gmail.com>
2011-10-22 19:09 ` [PATCH 00/22] Refactor to accept NUL in commit messages Jeff King
2011-10-23 10:44 ` Robin Rosenberg
2011-10-23 16:09 ` Jeff King
2011-10-22 22:47 ` Junio C Hamano
2011-10-23 1:24 ` Nguyen Thai Ngoc Duy
2011-10-23 5:51 ` Junio C Hamano
2011-10-23 6:37 ` Nguyen Thai Ngoc Duy
2011-10-23 9:46 ` Junio C Hamano
2011-10-23 10:17 ` Nguyen Thai Ngoc Duy
2011-10-23 16:07 ` Jeff King
2011-10-23 20:16 ` Junio C Hamano
2011-10-24 4:40 ` Junio C Hamano
2011-10-24 5:10 ` Nguyen Thai Ngoc Duy
2011-10-24 11:09 ` Štěpán Němec
2011-10-24 22:45 ` Jeff King
2011-10-25 10:16 ` Štěpán Němec
2011-10-25 14:07 ` Junio C Hamano
2011-10-27 18:13 ` Jeff King
2011-10-27 18:47 ` Junio C Hamano
2011-10-27 18:52 ` Jeff King
2011-10-27 19:14 ` Junio C Hamano [this message]
2011-10-27 23:44 ` Jeff King
2011-10-28 0:03 ` Junio C Hamano
2011-10-28 0:19 ` Jeff King
2011-10-28 1:40 ` Miles Bader
2011-10-28 4:07 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v39eez1ph.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.