From: Junio C Hamano <gitster@pobox.com>
To: Dmitry Ivankov <divanorama@gmail.com>
Cc: git@vger.kernel.org, Johannes Sixt <j.sixt@viscovery.net>
Subject: Re: [PATCH di/fast-import-deltified-tree] Windows: define S_ISUID properly
Date: Wed, 21 Sep 2011 05:07:59 -0700 [thread overview]
Message-ID: <7v39fq3xpc.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <loom.20110921T092135-714@post.gmane.org> (Dmitry Ivankov's message of "Wed, 21 Sep 2011 07:38:18 +0000 (UTC)")
Dmitry Ivankov <divanorama@gmail.com> writes:
> Johannes Sixt <j.sixt <at> viscovery.net> writes:
>>
>> From: Johannes Sixt <j6t <at> kdbg.org>
>>
>> 8fb3ad76 (fast-import: prevent producing bad delta) introduced the first
>> use of S_ISUID. Since before this commit the value was irrelevant, we had
>> only a dummy definition in mingw.h. But beginning with this commit the
>> macro must expand to a reasonable value. Make it so.
>> #define S_ISVTX 0
>> ...
> Ow, it's awkward that the issue was discussed in [1] but slipped and nobody
> noticed, especially me being a patch sender.
>
> If we choose patch from [1] I'd also change a comment to smth like
> /*
> * We abuse the 04000 bit on directories to mean "do not delta".
> * It is a S_ISUID bit on setuid platforms and an unused bit on
> * non-setuid platforms supported in git. In either case git ignores
> * the bit, so it's safe to abuse it locally.
> */
>
> [1] http://thread.gmane.org/gmane.comp.version-control.git/179223/focus=179762
I think that the fix from Jonathan to stop abusing S_ISUID is much more
preferrable; the Windows platform shouldn't have to worry about this.
And it would be even better to use a value that does not overlap with the
usual bits for do-not-delta bit if possible.
next prev parent reply other threads:[~2011-09-21 12:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-21 6:33 [PATCH di/fast-import-deltified-tree] Windows: define S_ISUID properly Johannes Sixt
2011-09-21 7:38 ` Dmitry Ivankov
2011-09-21 12:07 ` Junio C Hamano [this message]
2011-09-21 12:08 ` Junio C Hamano
2011-09-21 13:44 ` Dmitry Ivankov
2011-09-21 15:13 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v39fq3xpc.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=divanorama@gmail.com \
--cc=git@vger.kernel.org \
--cc=j.sixt@viscovery.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.