From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Alexander Potashev <aspotashev@gmail.com>,
Junio C Hamano <gitster@pobox.com>,
Git Mailing List <git@vger.kernel.org>,
Thomas Rast <trast@student.ethz.ch>
Subject: Re: [PATCH] diesys calls die and also reports strerror(errno)
Date: Thu, 04 Jun 2009 14:13:03 -0700 [thread overview]
Message-ID: <7v3aafwvmo.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20090604205055.GB17478@sigill.intra.peff.net> (Jeff King's message of "Thu\, 4 Jun 2009 16\:50\:55 -0400")
Jeff King <peff@peff.net> writes:
> Should we be calling malloc here? One of the possible error conditions
> is that we're out of memory (though xmalloc itself just uses "die"). I
> don't think there is a good reason not to use a reasonably-sized static
> buffer, which should increase robustness (report() is already using a
> 1024-character buffer, so any message would be truncated there anyway).
Yup, and at that point, tacking strerror value while expanding possible %
becomes even easier.
next prev parent reply other threads:[~2009-06-04 21:13 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-02 21:34 [PATCH] add strerror(errno) to die() calls where applicable Thomas Rast
2009-06-03 1:55 ` Jeff King
[not found] ` <2325a7950906031855t1977448lbb1c8aa671c72f3d@mail.gmail.com>
2009-06-04 1:58 ` Alexander Potashev
2009-06-04 20:32 ` Jeff King
2009-06-04 2:05 ` [PATCH] diesys calls die and also reports strerror(errno) Alexander Potashev
2009-06-04 20:50 ` Jeff King
2009-06-04 21:13 ` Junio C Hamano [this message]
2009-06-05 6:25 ` Johannes Sixt
2009-06-05 7:12 ` Junio C Hamano
2009-06-06 22:09 ` Jeff King
2009-06-06 13:09 ` [PATCH] add strerror(errno) to die() calls where applicable Thomas Rast
2009-06-06 14:44 ` [PATCH v2 0/3] Thomas Rast <trast@student.ethz.ch> Thomas Rast
2009-06-06 14:44 ` [PATCH v2 1/3] Introduce die_errno() that appends strerror(errno) to die() Thomas Rast
2009-06-06 20:36 ` Johannes Sixt
2009-06-06 20:56 ` Thomas Rast
2009-06-06 21:17 ` Johannes Sixt
2009-06-06 22:47 ` Jeff King
2009-06-06 22:13 ` Jeff King
2009-06-07 11:12 ` Alexander Potashev
2009-06-07 16:57 ` Junio C Hamano
2009-06-08 12:36 ` Jeff King
2009-06-08 15:35 ` Alexander Potashev
2009-06-08 22:04 ` Jeff King
2009-06-06 14:44 ` [PATCH v2 2/3] Convert existing die(..., strerror(errno)) to die_errno() Thomas Rast
2009-06-06 20:31 ` Johannes Sixt
2009-06-06 14:44 ` [PATCH v2 3/3] Use die_errno() instead of die() when checking syscalls Thomas Rast
2009-06-06 21:02 ` Johannes Sixt
2009-06-06 22:27 ` Thomas Rast
2009-06-08 21:02 ` [PATCH v3 0/3] die_errno() Thomas Rast
2009-06-08 21:02 ` [PATCH v3 1/3] Introduce die_errno() that appends strerror(errno) to die() Thomas Rast
2009-06-08 22:07 ` Jeff King
2009-06-09 8:22 ` Thomas Rast
2009-06-09 8:53 ` Jeff King
2009-06-09 9:29 ` Andreas Ericsson
2009-06-08 21:02 ` [PATCH v3 2/3] Convert existing die(..., strerror(errno)) to die_errno() Thomas Rast
2009-06-08 21:02 ` [PATCH v3 3/3] Use die_errno() instead of die() when checking syscalls Thomas Rast
2009-06-27 15:58 ` [PATCH v4 0/4] die_errno() Thomas Rast
2009-06-27 15:58 ` [PATCH v4 1/4] Introduce die_errno() that appends strerror(errno) to die() Thomas Rast
2009-06-27 15:58 ` [PATCH v4 2/4] die_errno(): double % in strerror() output just in case Thomas Rast
2009-06-27 15:58 ` [PATCH v4 3/4] Convert existing die(..., strerror(errno)) to die_errno() Thomas Rast
2009-06-27 15:58 ` [PATCH v4 4/4] Use die_errno() instead of die() when checking syscalls Thomas Rast
2009-06-27 18:38 ` [PATCH v4 0/4] die_errno() Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v3aafwvmo.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=aspotashev@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.