From: Junio C Hamano <gitster@pobox.com>
To: Charles Bailey <charles@hashpling.org>
Cc: git@vger.kernel.org, "Jonas Flodén" <jonas.floden@gmail.com>
Subject: Re: [PATCH 2/2] mergetool: fix running mergetool in sub-directories
Date: Sat, 07 Feb 2009 13:48:55 -0800 [thread overview]
Message-ID: <7v3aepuddk.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <49877F68.30509@hashpling.org> (Charles Bailey's message of "Mon, 02 Feb 2009 23:19:04 +0000")
Charles Bailey <charles@hashpling.org> writes:
> Junio C Hamano wrote:
>>
>> I wonder if it would be cleaner to keep $prefix and instead cd_to_toplevel
>> at the beginning.
>> ...
> Possibly, and I certainly wouldn't object if mergetool moved to the
> latter mode of operation in the medium term.
>
> In general, though, mergetool is pretty happy running from the users
> directory and there may be cases in which users expect the merge tool to
> be running from the directory that they started in (saving extra files
> during the merge process?).
A very sensible consideration that I agree with. I am happy that you
were the one who volunteered to take this script over.
prev parent reply other threads:[~2009-02-07 21:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-30 23:20 [PATCH 1/2] mergetool: Add a test for running mergetool in a sub-directory Charles Bailey
2009-01-30 23:20 ` [PATCH 2/2] mergetool: fix running mergetool in sub-directories Charles Bailey
2009-02-01 1:32 ` Junio C Hamano
2009-02-02 23:19 ` Charles Bailey
2009-02-07 21:48 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v3aepuddk.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=charles@hashpling.org \
--cc=git@vger.kernel.org \
--cc=jonas.floden@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.