From: Junio C Hamano <junio@pobox.com>
To: Alex Riesen <raa.lkml@gmail.com>
Cc: "Git Mailing List" <git@vger.kernel.org>,
"Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
"Dirk Süsserott" <newsletter@dirk.my1.cc>
Subject: Re: [PATCH] Add a test for git-add --ignore-errors
Date: Mon, 12 May 2008 20:48:22 -0700 [thread overview]
Message-ID: <7v3aomx3sp.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20080512175848.GF3128@steel.home> (Alex Riesen's message of "Mon, 12 May 2008 19:58:48 +0200")
Alex Riesen <raa.lkml@gmail.com> writes:
> Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
> ---
> t/t3700-add.sh | 9 +++++++++
> 1 files changed, 9 insertions(+), 0 deletions(-)
>
> diff --git a/t/t3700-add.sh b/t/t3700-add.sh
> index 287e058..ca3e33d 100755
> --- a/t/t3700-add.sh
> +++ b/t/t3700-add.sh
> @@ -179,4 +179,13 @@ test_expect_success 'git add --refresh' '
> test -z "`git diff-index HEAD -- foo`"
> '
>
> +test_expect_success 'git add --ignore-errors' '
> + git reset --hard &&
> + date >foo1 &&
> + date >foo2 &&
> + chmod 0 foo2 &&
> + git add --verbose --ignore-errors .
> + git ls-files |grep foo1
> +'
> +
> test_done
I like the fact that you added --ignore-errors and made it still error out
when it cannot read some files. Shouldn't we be testing it here with
"must-fail"?
next prev parent reply other threads:[~2008-05-13 3:49 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-01 13:46 How to "git add ." when some files are not accessible (permission denied)? Dirk Süsserott
2008-03-02 1:19 ` Jeff King
2008-03-03 19:17 ` Dirk Süsserott
2008-03-03 20:06 ` Junio C Hamano
2008-03-03 20:32 ` Dirk Süsserott
2008-03-02 15:41 ` Alex Riesen
2008-03-02 15:42 ` [PATCH] Make the exit code of add_file_to_index actually useful Alex Riesen
2008-03-02 15:43 ` [PATCH] Extend interface of add_files_to_cache to allow ignore indexing errors Alex Riesen
2008-03-02 15:44 ` [PATCH] Add --ignore-errors to git-add to allow it to skip files with read errors Alex Riesen
2008-03-02 15:44 ` [PATCH] Add a test for git-add --ignore-errors Alex Riesen
2008-03-02 15:57 ` [PATCH] Make the exit code of add_file_to_index actually useful Johannes Schindelin
2008-03-02 16:59 ` Junio C Hamano
2008-03-02 21:42 ` Alex Riesen
2008-03-02 22:04 ` Joachim B Haga
2008-03-03 6:57 ` Alex Riesen
2008-05-12 17:56 ` Alex Riesen
2008-05-12 17:57 ` Alex Riesen
2008-05-12 17:58 ` [PATCH] Extend interface of add_files_to_cache to allow ignore indexing errors Alex Riesen
2008-05-12 17:58 ` [PATCH] Add --ignore-errors to git-add to allow it to skip files with read errors Alex Riesen
2008-05-12 17:58 ` [PATCH] Add a test for git-add --ignore-errors Alex Riesen
2008-05-12 17:59 ` [PATCH] Add a config option to ignore errors for git-add Alex Riesen
2008-05-13 3:48 ` Junio C Hamano [this message]
2008-05-13 6:04 ` [PATCH] Add a test for git-add --ignore-errors Alex Riesen
2008-05-13 6:05 ` Junio C Hamano
2008-05-13 22:28 ` Alex Riesen
2008-05-12 18:42 ` [PATCH] Make the exit code of add_file_to_index actually useful Junio C Hamano
2008-05-12 20:54 ` Alex Riesen
2008-05-12 22:19 ` Junio C Hamano
2008-05-12 22:48 ` Alex Riesen
2008-05-12 23:32 ` Junio C Hamano
2008-05-13 6:00 ` Alex Riesen
2008-03-03 18:01 ` Daniel Barkalow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v3aomx3sp.fsf@gitster.siamese.dyndns.org \
--to=junio@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=newsletter@dirk.my1.cc \
--cc=raa.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.