From: Junio C Hamano <gitster@pobox.com>
To: Jakub Narebski <jnareb@gmail.com>
Cc: "J. Bruce Fields" <bfields@fieldses.org>,
Daniel Barkalow <barkalow@iabervon.org>,
git@vger.kernel.org
Subject: Re: [PATCH] Add gitattributes file making whitespace checking pickier
Date: Sun, 10 Feb 2008 13:52:28 -0800 [thread overview]
Message-ID: <7v3as0fpib.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <200802101231.16847.jnareb@gmail.com> (Jakub Narebski's message of "Sun, 10 Feb 2008 12:31:15 +0100")
Jakub Narebski <jnareb@gmail.com> writes:
> Junio C Hamano wrote:
>> Jakub Narebski <jnareb@gmail.com> writes:
>>
>>>> *.py whitespace=!indent,trail,space
>>>> *.el whitespace=!indent,trail,space
>
> Emacs Lisp is (like Perl, and contrary to Python) whitespace agnostic,
What does agnostic have anything to do with anything?
C is whitespace agnostic and outside obvious places like string
constants and #preprocessor directives you can have SP and HT
and LF interchangeably. It does not mean you do not need
whitespace policy.
If gitweb historically used SP everywhere like git.el, I think
that is a very good reason to treat it just like *.py and *.el,
though. See the updated set of patterns I sent to Daniel just
now.
>> It also happens that I do not personally believe in "alignment
>> with spaces" argument. If you accept W and a SP occupy the same
>> horizontal space (which "alignment with spaces" assume), I do
>> not think it is unreasonable to accept HT goes to the next
>> column that is multiple of 8 places.
>
> My argument is ...
Wasn't my 5 lines enough clue to save you from repeating that?
I said I do not agree with it, so please don't even try wasting
everybody's time on bikeshedding.
next prev parent reply other threads:[~2008-02-10 21:53 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-09 16:22 [PATCH] Add gitattributes file making whitespace checking pickier J. Bruce Fields
2008-02-09 17:56 ` Daniel Barkalow
2008-02-09 18:50 ` J. Bruce Fields
2008-02-09 19:05 ` J. Bruce Fields
2008-02-09 19:36 ` Jakub Narebski
2008-02-09 20:04 ` J. Bruce Fields
2008-02-09 20:22 ` Jakub Narebski
2008-02-09 23:39 ` J. Bruce Fields
2008-02-09 20:57 ` Junio C Hamano
2008-02-09 23:36 ` J. Bruce Fields
2008-02-09 23:45 ` Jakub Narebski
2008-02-10 4:01 ` Junio C Hamano
2008-02-10 11:31 ` Jakub Narebski
2008-02-10 21:52 ` Junio C Hamano [this message]
2008-02-10 10:52 ` Junio C Hamano
2008-02-10 18:56 ` J. Bruce Fields
2008-02-10 20:22 ` Daniel Barkalow
2008-02-10 21:47 ` Junio C Hamano
2008-02-10 22:34 ` Daniel Barkalow
2008-02-11 3:34 ` Junio C Hamano
2008-02-12 7:43 ` Brian Downing
2008-02-12 21:42 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v3as0fpib.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=barkalow@iabervon.org \
--cc=bfields@fieldses.org \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.