From: Junio C Hamano <gitster@pobox.com>
To: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>, git@vger.kernel.org
Subject: Re: [PATCH] Do check_repository_format() early
Date: Fri, 30 Nov 2007 18:36:03 -0800 [thread overview]
Message-ID: <7v3aunb0q4.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: Pine.LNX.4.64.0711281810410.27959@racer.site
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> On Thu, 29 Nov 2007, Nguyen Thai Ngoc Duy wrote:
>
>> The comment is clearly not clear enough. Maybe this?
>>
>> + if (!work_tree_env) {
>> + retval = set_work_tree(gitdirenv);
>> + /* config may override worktree (see
>> set_work_tree comment) */
>> + check_repository_format();
>> + return retval;
>> + }
>
> Perfect. Please make it so, and add my ACK.
Looks sensible, but can this be accompanied with a trivial test to
demonstrate the existing breakage?
next prev parent reply other threads:[~2007-12-01 2:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-28 16:58 [PATCH] Do check_repository_format() early Nguyễn Thái Ngọc Duy
2007-11-28 17:05 ` Johannes Schindelin
2007-11-28 17:10 ` Nguyen Thai Ngoc Duy
2007-11-28 17:18 ` Johannes Schindelin
2007-11-28 17:24 ` Nguyen Thai Ngoc Duy
2007-11-28 18:11 ` Johannes Schindelin
2007-12-01 2:36 ` Junio C Hamano [this message]
2007-12-01 6:50 ` Nguyen Thai Ngoc Duy
2007-12-01 18:58 ` Junio C Hamano
2007-12-03 4:03 ` Nguyen Thai Ngoc Duy
2007-12-03 10:44 ` Johannes Schindelin
2007-12-03 14:04 ` Nguyen Thai Ngoc Duy
2007-12-03 18:07 ` Junio C Hamano
2007-12-05 13:33 ` Nguyễn Thái Ngọc Duy
2007-12-05 15:39 ` Nguyen Thai Ngoc Duy
2007-12-06 1:18 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v3aunb0q4.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.