From: Junio C Hamano <gitster@pobox.com>
To: David Kastrup <dak@gnu.org>
Cc: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>,
git@vger.kernel.org,
Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: [PATCH] git-filter-branch: document --original option
Date: Thu, 30 Aug 2007 16:13:34 -0700 [thread overview]
Message-ID: <7v3ay07h0h.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <7vodgo7jbn.fsf@gitster.siamese.dyndns.org> (Junio C. Hamano's message of "Thu, 30 Aug 2007 15:23:40 -0700")
Junio C Hamano <gitster@pobox.com> writes:
> I agree we do not give the "portable to version 7" prize
> anymore. But you made me realize another thing.
>
> I think it should make sure orig_namespace has one and only one
> trailing slash, because otherwise "--original refs/heads//"
> would lead you to the same disaster.
Perhaps,
orig_namespace=$(expr "$OPTARG/" : '\(.*[^/]\)/*$')/
Well, I know people hate colon-expr, but we earlier ruled out
(and we still do) ${parameter//pattern/string} as bashism beyond
the portability line, and I do not see an alternative easier to
read than this...
next prev parent reply other threads:[~2007-08-30 23:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-30 15:56 [PATCH] git-filter-branch: more detailed USAGE Giuseppe Bilotta
2007-08-30 16:20 ` Johannes Sixt
2007-08-30 17:11 ` Giuseppe Bilotta
2007-08-30 17:10 ` Giuseppe Bilotta
2007-08-30 17:10 ` [PATCH] git-filter-branch: document --original option Giuseppe Bilotta
2007-08-30 21:55 ` Junio C Hamano
2007-08-30 22:00 ` David Kastrup
2007-08-30 22:23 ` Junio C Hamano
2007-08-30 23:13 ` Junio C Hamano [this message]
2007-08-31 6:16 ` David Kastrup
2007-08-31 6:13 ` David Kastrup
2007-08-30 23:04 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v3ay07h0h.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=dak@gnu.org \
--cc=git@vger.kernel.org \
--cc=giuseppe.bilotta@gmail.com \
--cc=johannes.schindelin@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.