From: Junio C Hamano <junkio@cox.net>
To: Andy Parkins <andyparkins@gmail.com>
Cc: git@vger.kernel.org, Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH] Trim hint printed when gecos is empty.
Date: Tue, 28 Nov 2006 10:29:50 -0800 [thread overview]
Message-ID: <7v3b834e75.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: 200611281506.53518.andyparkins@gmail.com
Andy Parkins <andyparkins@gmail.com> writes:
> On Tuesday 2006 November 28 14:40, Johannes Schindelin wrote:
>
>> You are probably different than me. What with my track record, I _trust_
>> my patches to be not perfect at all...
>
> ... I had understood it was a
> legal tool to trace the provenance of a patch - not to sign off on it being
> bug free (which surely is impossible).
Johannes, Andy's interpretation is in line with the policy in
SubmittingPatches. S-o-b is about warranty of provenance, and
not about correctness or cheering (Acked-by).
And I think it makes sense to add "-s" automatically to commits
made in a private working repository in which the developer who
configured "-s" to be added automatically is the only person who
makes commits. As already mentioned in the thread, one of the
hooks should be usable for that. And it certainly is a
possibility to add a config to turn "-s" on.
But I suspect that it would be cleaner and more useful to teach
"git commit" to use a commit message template per repository and
put the S-o-b in there -- that mechanism would be usable for
things other than just S-o-b lines as projects see fit.
next prev parent reply other threads:[~2006-11-28 18:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-28 10:27 [PATCH] Trim hint printed when gecos is empty Han-Wen Nienhuys
2006-11-28 10:52 ` Han-Wen Nienhuys
2006-11-28 11:15 ` Jakub Narebski
2006-11-28 11:46 ` Andy Parkins
2006-11-28 13:28 ` Johannes Schindelin
2006-11-28 14:03 ` Andy Parkins
2006-11-28 14:40 ` Johannes Schindelin
2006-11-28 15:06 ` Andy Parkins
2006-11-28 15:31 ` Shawn Pearce
2006-11-28 18:29 ` Junio C Hamano [this message]
2006-11-29 9:29 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v3b834e75.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=andyparkins@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.