From: Junio C Hamano <junkio@cox.net>
To: Jakub Narebski <jnareb@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] gitweb: Do not use esc_html in esc_path
Date: Sat, 25 Nov 2006 01:45:06 -0800 [thread overview]
Message-ID: <7v3b876esd.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <11644442392444-git-send-email-jnareb@gmail.com> (Jakub Narebski's message of "Sat, 25 Nov 2006 09:43:59 +0100")
Jakub Narebski <jnareb@gmail.com> writes:
> Do not use esc_html in esc_path subroutine to avoid double quoting;
> expand esc_html body (except quoting) in esc_path.
>
> Move esc_path before quot_cec and quot_upr. Add some comments.
>
> Signed-off-by: Jakub Narebski <jnareb@gmail.com>
> ---
> This patch was send to git mailing list; I don't know if it
> was missed, or rejected.
I do not remember looking at it deeply, so probably it was just
lost in the noise.
Unless there was a list discussion that was unfavorable, that
is; but I do not recall one and the patch looks sane.
next prev parent reply other threads:[~2006-11-25 9:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-25 8:43 [PATCH] gitweb: Do not use esc_html in esc_path Jakub Narebski
2006-11-25 9:45 ` Junio C Hamano [this message]
2006-11-25 9:54 ` Jakub Narebski
-- strict thread matches above, loose matches on Subject: below --
2006-11-21 20:43 Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v3b876esd.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.