All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: Don Zickus <dzickus@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: bad git pull
Date: Fri, 16 Dec 2005 09:40:45 -0800	[thread overview]
Message-ID: <7v3bktj5ya.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: 68948ca0512160739g12a3e25en256bae8c354c3a45@mail.gmail.com

Don Zickus <dzickus@gmail.com> writes:

>> While I am sympathetic, this "Oops, I said pull when I meant
>> fetch" sounds remotely similar to "oops, I said 'rm -r' when I
>> meant to say 'ls -r'".  Is it that the tool is too fragile?
>
> Sorry, wrong choice of words.  Didn't mean to imply anything negative.
> Though, I am still learning the tool and its features, I do appreciate
> your feedback and your last email was correct in understanding the
> mess I created.  I'll go read up on the differences between 'fetch'
> and 'pull'.

I too was a bit too defensive, and I agree the tool is prone to
easy errors; the worst part is that there is no "rm -i"
equivalent to be extra careful [*1*].  On the other hand, we
have "git reset" to recover from, so it is not as bad as
a mistake with "rm" ;-).

If for example there were a way to say "this `origin' shortcut
is to be pulled into `master' branch and nothing else", we could
have caught the "git pull" you had trouble with.  There was a
discussion on the list in the past to extend remotes/ files to
allow such restriction of the patchflow to be expressed, but
back then I felt the kind of restriction the proposal could
express was too limiting, and the discussion was a bit premature
because we did not have recommended patterns yet.

We might want to revive the discussion post 1.0.  Taking the
example of the topic-branch workflow by Tony, the "patch flow"
language needs to be able to express something at least this:

 - topic branches -- branched from 'origin' somewhere in the
   past; commits accumulated but usually nothing is merged
   into them.

 - 'test' -- branched from 'origin' somewhere in the past; used
   solely to merge topic branches into it and no commits are
   made into it directly; branches that are regularly merged
   into it are:

   - topic branches
   - 'origin'
   - 'release'

 - 'release' -- branched from 'origin' somewhere in the
   past; trivial/obviously correct commits are made into it
   directly; proven to be good topic branches are merged into it
   for consumption by others; branches that are regularly merged
   into it are:

   - topic branches
   - 'origin'
   - never 'test' 



[Footnote]

*1* IMHO "rm -i" is not that safe, though.  If one overuses it,
it trains one's fingers to say "y" without much thinking.

  reply	other threads:[~2005-12-16 17:40 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-15 23:37 bad git pull Don Zickus
2005-12-15 23:42 ` Junio C Hamano
2005-12-15 23:53   ` Junio C Hamano
2005-12-16 15:39     ` Don Zickus
2005-12-16 17:40       ` Junio C Hamano [this message]
2005-12-16 17:25     ` Carl Baldwin
2005-12-16 19:20       ` Junio C Hamano
2005-12-16 18:07     ` Morten Welinder
2005-12-16 19:21       ` Junio C Hamano
2005-12-16 22:12         ` Linus Torvalds
2005-12-17  0:37           ` Morten Welinder
2005-12-17  1:05             ` Linus Torvalds
2005-12-17  1:49               ` Junio C Hamano
2005-12-17  7:44                 ` Linus Torvalds
2005-12-17  9:28                   ` Junio C Hamano
2005-12-17 21:04                     ` Nicolas Pitre
2005-12-18  3:02                       ` Junio C Hamano
2005-12-18  4:17                         ` Nicolas Pitre
2005-12-18  6:31                           ` Linus Torvalds
2005-12-18  7:15                           ` Junio C Hamano
2005-12-18 17:16                             ` Nicolas Pitre
2005-12-17  2:19             ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v3bktj5ya.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=dzickus@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.