From: Junio C Hamano <gitster@pobox.com>
To: Michal Kiedrowicz <michal.kiedrowicz@gmail.com>
Cc: Git List <git@vger.kernel.org>,
Martin Langhoff <martin.langhoff@gmail.com>,
Bert Wesarg <bert.wesarg@googlemail.com>,
Johannes Sixt <j.sixt@viscovery.net>,
Alex Riesen <raa.lkml@gmail.com>
Subject: Re: [PATCH v3 6/6] git-grep: Bail out when -P is used with -F or -E
Date: Mon, 09 May 2011 23:11:25 -0700 [thread overview]
Message-ID: <7v4o53m6eq.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20110510072439.6b288715@mkiedrowicz> (Michal Kiedrowicz's message of "Tue, 10 May 2011 07:24:39 +0200")
Michal Kiedrowicz <michal.kiedrowicz@gmail.com> writes:
>> We would need some tests for "grep -P", no?
>
> What about those in patch 5/6?
There are some, but we would also want to see negative cases where
compilation detects an incorrect regexp.
>> Please throw in the
>> "last one wins" and "command line defeats configuration" when you add
>> one.
> +test_expect_success LIBPCRE 'grep -P -i pattern' '
>
> in patch 5/6 :). Or perhaps it doesn't work for you?
These I overlooked. Will remove the "-i -P does not work yet".
Thanks.
prev parent reply other threads:[~2011-05-10 6:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-09 21:52 [PATCH v3 0/6] Add PCRE support to git-grep Michał Kiedrowicz
2011-05-09 21:52 ` [PATCH v3 1/6] grep: Fix a typo in a comment Michał Kiedrowicz
2011-05-09 21:52 ` [PATCH v3 2/6] grep: Extract compile_regexp_failed() from compile_regexp() Michał Kiedrowicz
2011-05-09 21:52 ` [PATCH v3 3/6] git-grep: Learn PCRE Michał Kiedrowicz
2011-05-09 21:52 ` [PATCH v3 4/6] configure: Check for libpcre Michał Kiedrowicz
2011-05-09 21:52 ` [PATCH v3 5/6] grep: Add basic tests Michał Kiedrowicz
2011-05-09 21:52 ` [PATCH v3 6/6] git-grep: Bail out when -P is used with -F or -E Michał Kiedrowicz
2011-05-10 1:48 ` Junio C Hamano
2011-05-10 5:24 ` Michal Kiedrowicz
2011-05-10 6:11 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v4o53m6eq.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=bert.wesarg@googlemail.com \
--cc=git@vger.kernel.org \
--cc=j.sixt@viscovery.net \
--cc=martin.langhoff@gmail.com \
--cc=michal.kiedrowicz@gmail.com \
--cc=raa.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.