From: Junio C Hamano <gitster@pobox.com>
To: Kevin Ballard <kevin@sb.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] diff: handle lines containing only whitespace better
Date: Wed, 20 Oct 2010 09:08:49 -0700 [thread overview]
Message-ID: <7v4ocgx2we.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <780B144B-03E0-4ED5-8E92-D4EB3CBBBF71@sb.org> (Kevin Ballard's message of "Tue\, 19 Oct 2010 23\:38\:41 -0700")
Kevin Ballard <kevin@sb.org> writes:
> Incidentally, I just realized the description of the patch is slightly
> wrong. The problem only occurs when the line contains at least one
> tab...
That exactly is why I asked for tests, as I couldn't reproduce it from the
description at all.
But I see it now.
$ HT=' '
$ mv Makefile Makefile+
$ sed -e "3s/^.*/$HT/" Makefile+ >Makefile
$ git diff --color
> ...Should I resend the patch with an updated description? I can also
> attempt to write tests if you can give me some guidance on how to deal
> with the need for ansi color codes.
This may show us a good starting point.
$ git grep RED t/
next prev parent reply other threads:[~2010-10-20 16:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-20 4:46 [PATCH] diff: handle lines containing only whitespace better Kevin Ballard
2010-10-20 6:16 ` Junio C Hamano
2010-10-20 6:38 ` Kevin Ballard
2010-10-20 7:51 ` Nazri Ramliy
2010-10-20 16:08 ` Junio C Hamano [this message]
2010-10-20 22:17 ` [PATCH v2 1/2] test-lib: extend test_decode_color to handle more color codes Kevin Ballard
2010-10-20 23:40 ` Junio C Hamano
2010-10-21 0:11 ` Kevin Ballard
2010-10-20 22:17 ` [PATCH v2 2/2] diff: handle lines containing only whitespace and tabs better Kevin Ballard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v4ocgx2we.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=kevin@sb.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.